From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: <pabeni@redhat.com>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>,
<egallen@redhat.com>, <hgani@marvell.com>, <mschmidt@redhat.com>,
<netdev@vger.kernel.org>, <sedara@marvell.com>,
<vburru@marvell.com>, <vimleshk@marvell.com>
Subject: Re: [net PATCH v2] octeon_ep: update BQL sent bytes before ringing doorbell
Date: Mon, 16 Oct 2023 14:54:08 -0700 [thread overview]
Message-ID: <20231016145408.539968d1@kernel.org> (raw)
In-Reply-To: <20231012101706.2291551-1-srasheed@marvell.com>
On Thu, 12 Oct 2023 03:17:06 -0700 Shinas Rasheed wrote:
> - netdev_tx_sent_queue(iq->netdev_q, skb->len);
> iq->stats.instr_posted++;
> skb_tx_timestamp(skb);
The skb_tx_timestamp() here will do the same exact UAF, no?
I think you should move them both.
--
pw-bot: cr
prev parent reply other threads:[~2023-10-16 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 11:50 [net PATCH] octeon_ep: update BQL sent bytes before ringing doorbell Shinas Rasheed
2023-10-12 8:31 ` Paolo Abeni
2023-10-12 10:00 ` [EXT] " Shinas Rasheed
2023-10-12 10:17 ` [net PATCH v2] " Shinas Rasheed
2023-10-13 0:01 ` Jakub Kicinski
2023-10-13 9:04 ` [EXT] " Shinas Rasheed
2023-10-16 21:52 ` Jakub Kicinski
2023-10-16 21:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016145408.539968d1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=hgani@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.