From: Stefan Hajnoczi <stefanha@redhat.com>
To: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
Fam Zheng <fam@euphon.net>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Lieven <pl@kamp.de>,
Jeff Cody <codyprime@gmail.com>,
"open list:Block Jobs" <qemu-block@nongnu.org>
Subject: Re: [RFC PATCH v3 02/78] block: add fallthrough pseudo-keyword
Date: Mon, 16 Oct 2023 11:03:33 -0400 [thread overview]
Message-ID: <20231016150333.GC119987@fedora> (raw)
In-Reply-To: <e54aa70630d6d524886d7950b84d5bda39c3d605.1697186560.git.manos.pitsidianakis@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Fri, Oct 13, 2023 at 11:45:30AM +0300, Emmanouil Pitsidianakis wrote:
> In preparation of raising -Wimplicit-fallthrough to 5, replace all
> fall-through comments with the fallthrough attribute pseudo-keyword.
>
> Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
> ---
> block/block-copy.c | 1 +
> block/file-posix.c | 1 +
> block/io.c | 1 +
> block/iscsi.c | 1 +
> block/qcow2-cluster.c | 5 ++++-
> block/vhdx.c | 17 +++++++++++++----
> 6 files changed, 21 insertions(+), 5 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-10-16 15:05 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 8:45 [RFC PATCH v3 00/78] Strict disable implicit fallthrough Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 01/78] include/qemu/compiler.h: replace QEMU_FALLTHROUGH with fallthrough Emmanouil Pitsidianakis
2023-10-13 9:13 ` gaosong
2023-10-13 8:45 ` [RFC PATCH v3 02/78] block: add fallthrough pseudo-keyword Emmanouil Pitsidianakis
2023-10-16 15:03 ` Stefan Hajnoczi [this message]
2023-10-13 8:45 ` [RFC PATCH v3 03/78] fpu/softfloat: " Emmanouil Pitsidianakis
2023-10-16 18:56 ` Alex Bennée
2023-10-13 8:45 ` [RFC PATCH v3 04/78] qapi/opts-visitor: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 05/78] qobject/json: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 06/78] tcg: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 07/78] hw/virtio/virtio-balloon.c: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 08/78] hw/block: " Emmanouil Pitsidianakis
2023-10-16 15:03 ` Stefan Hajnoczi
2023-10-13 8:45 ` [RFC PATCH v3 09/78] hw/acpi/aml-build.c: " Emmanouil Pitsidianakis
2023-10-17 8:40 ` Ani Sinha
2023-10-13 8:45 ` [RFC PATCH v3 10/78] hw/ide/atapi.c: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 11/78] hw/timer: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 12/78] hw/usb: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 13/78] hw/adc: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 14/78] util/error-report.c: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 15/78] accel/tcg: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 16/78] audio: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 17/78] ui/sdl2.c: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 18/78] ui/win32-kbd-hook.c: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 19/78] target/hppa: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 20/78] target/mips: " Emmanouil Pitsidianakis
2023-10-16 16:51 ` Philippe Mathieu-Daudé
2023-10-13 8:45 ` [RFC PATCH v3 21/78] target/sparc: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 22/78] target/ppc: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 23/78] target/arm: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 24/78] target/alpha: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 25/78] target/i386: " Emmanouil Pitsidianakis
2023-10-19 7:17 ` Zhao Liu
2023-10-13 8:45 ` [RFC PATCH v3 26/78] target/s390x: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 27/78] target/riscv: " Emmanouil Pitsidianakis
2023-10-13 18:17 ` Daniel Henrique Barboza
2023-10-16 1:52 ` Alistair Francis
2023-10-13 8:45 ` [RFC PATCH v3 28/78] target/avr: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 29/78] target/cris: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 30/78] target/nios2: " Emmanouil Pitsidianakis
2023-10-13 8:45 ` [RFC PATCH v3 31/78] target/xtensa: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 32/78] target/m68k: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 33/78] target/rx: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 34/78] target/tricore: " Emmanouil Pitsidianakis
2023-10-13 14:26 ` Bastian Koppelmann
2023-10-13 8:46 ` [RFC PATCH v3 35/78] target/sh4: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 36/78] target/openrisc: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 37/78] target/hexagon: " Emmanouil Pitsidianakis
2023-10-16 19:30 ` Anton Johansson via
2023-10-16 19:30 ` Anton Johansson
2023-10-13 8:46 ` [RFC PATCH v3 38/78] system/rtc.c: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 39/78] hw/scsi: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 40/78] hw/sd/sdhci.c: " Emmanouil Pitsidianakis
2023-10-17 10:31 ` Philippe Mathieu-Daudé
2023-10-13 8:46 ` [RFC PATCH v3 41/78] linux-user: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 42/78] hw/i386: " Emmanouil Pitsidianakis
2023-10-17 12:38 ` Paul Durrant
2023-10-13 8:46 ` [RFC PATCH v3 43/78] hw/misc: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 44/78] hw/m68k/mcf_intc.c: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 45/78] hw/dma: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 46/78] disas: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 47/78] contrib/rdmacm-mux: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 48/78] contrib/vhost-user-scsi: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 49/78] hw/arm: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 50/78] hw/audio: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 51/78] chardev: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 52/78] hw/char: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 53/78] nbd: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 54/78] hw/core: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 55/78] hw/display: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 56/78] hw/input: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 57/78] hw/net: " Emmanouil Pitsidianakis
2023-10-13 9:11 ` Akihiko Odaki
2023-10-13 9:20 ` Manos Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 58/78] hw/ppc: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 59/78] hw/intc: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 60/78] qga: " Emmanouil Pitsidianakis
2023-10-17 7:48 ` Konstantin Kostiuk
2023-10-13 8:46 ` [RFC PATCH v3 61/78] semihosting: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 62/78] hw/gpio: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 63/78] hw/ipmi: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 64/78] hw/mips: " Emmanouil Pitsidianakis
2023-10-17 10:30 ` Philippe Mathieu-Daudé
2023-10-13 8:46 ` [RFC PATCH v3 65/78] hw/nvme: " Emmanouil Pitsidianakis
2023-11-15 9:30 ` Klaus Jensen
2023-10-13 8:46 ` [RFC PATCH v3 66/78] hw/nvram/eeprom_at24c.c: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 67/78] hw/pci-host/pnv_phb3.c: " Emmanouil Pitsidianakis
2023-10-13 12:53 ` Cédric Le Goater
2023-10-13 8:46 ` [RFC PATCH v3 68/78] hw/pci: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 69/78] hw/rdma/rdma_backend.c: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 70/78] hw/rtc: " Emmanouil Pitsidianakis
2023-10-13 12:53 ` Cédric Le Goater
2023-10-13 8:46 ` [RFC PATCH v3 71/78] hw/s390x: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 72/78] hw/ssi: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 73/78] hw/watchdog/wdt_diag288.c: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 74/78] hw/cxl/cxl-device-utils.c: " Emmanouil Pitsidianakis
2023-10-16 10:31 ` Jonathan Cameron via
2023-10-16 10:31 ` Jonathan Cameron
2023-10-13 8:46 ` [RFC PATCH v3 75/78] migration: " Emmanouil Pitsidianakis
2023-10-16 14:02 ` Fabiano Rosas
2023-10-13 8:46 ` [RFC PATCH v3 76/78] qemu-img.c: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 77/78] tests/unit/test-char.c: " Emmanouil Pitsidianakis
2023-10-13 8:46 ` [RFC PATCH v3 78/78] meson.build: increase -Wimplicit-fallthrough to 5 Emmanouil Pitsidianakis
2023-10-13 10:44 ` [RFC PATCH v3 00/78] Strict disable implicit fallthrough Philippe Mathieu-Daudé
2023-10-13 13:52 ` Richard Henderson
2023-10-13 13:59 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016150333.GC119987@fedora \
--to=stefanha@redhat.com \
--cc=codyprime@gmail.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.