From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F03A30F97 for ; Mon, 16 Oct 2023 16:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wfi4BNsm" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-66d17bdabe1so29698106d6.0 for ; Mon, 16 Oct 2023 09:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697474446; x=1698079246; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QMErPVjbDQWKUZJi0yx3PHwgd44uCsmqExmEKyoGenQ=; b=wfi4BNsmzEMdvVFAdM+AytMJ11vduCOgAg1rGr8EPH2frLDi04PuPIJGbUCfStgTN5 988HWE8lg8kik+R9oq/vwrkMImQkklYDlECjQIb5O6IlHjFvPL8V56zlP5xW46/qwSRD jzUgHOx9Sy7OUxEJcd2R6QT1BOZqzooFx1P+HhAeTfiW1fiiD4pz7df/SRbadvxrgNW6 PtA04w3JiUcLI1iARmjAor6AiiAVWuro8b7FRv1PDxsc/nsKal7llIrY7wxjDGQPgY77 Ei2d0hw4GSD/fhp3uPeDrovy6rJYI/XmU57ceB50c0jh7rtRq/iT/m4dlDzHT5HmxOo8 1FHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697474446; x=1698079246; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QMErPVjbDQWKUZJi0yx3PHwgd44uCsmqExmEKyoGenQ=; b=cWOUaktk1dDMOcMVPGwBuWXy/gcc1CzRNx3T6dod+8g5Xu9NJ/2kAUtdQyPvlinYdD NYNE8mxa0DaKG9EQJB9I+Z7yAbJS0+PJQRnygRIQR4Ucuf5gyXOA2VpscXOX34iql6fT FdVzYmy3LAUtPsXbgVBgdSBlar+S4Dxbt6wiFM9sVRLYVkn/ojbpcaiaaJOxX7htKkw+ npGyTQnxpucGHIMSvNG8e0vAKmnAVt7ohhhB4rFRj35P/BVJvLhMHEOjzllVFvSeZ7nk g5VhqHc0rdrgjCCxf4nkInCn57RfK7v72rvfP/DNSdmNbn8iPKSVDNccPduhEtXFxT9E MlqQ== X-Gm-Message-State: AOJu0Yx+8DYoZG3hH55fAQZlyimdb3gT+20g3oxvDBmqIvfxcxRPFc5o RReR2OXA+UJtCNFmp/+0NH+X X-Google-Smtp-Source: AGHT+IEJrtLsab3W/titRBbEr+F6cON9aYDks19MkUWPWxcQNbAkkCh7gLRrSjOouWXUxCmZiVJgZQ== X-Received: by 2002:a05:6214:cae:b0:66d:28a5:d153 with SMTP id s14-20020a0562140cae00b0066d28a5d153mr11497866qvs.47.1697474445956; Mon, 16 Oct 2023 09:40:45 -0700 (PDT) Received: from thinkpad ([117.207.31.199]) by smtp.gmail.com with ESMTPSA id dn8-20020a056214094800b0065b0e724f83sm3548177qvb.6.2023.10.16.09.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:40:45 -0700 (PDT) Date: Mon, 16 Oct 2023 22:10:36 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , imx@lists.linux.dev Subject: Re: [PATCH 1/3] PCI: layerscape: add function pointer for exit_from_l2() Message-ID: <20231016164036.GE39962@thinkpad> References: <20230915184306.2374670-1-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230915184306.2374670-1-Frank.Li@nxp.com> On Fri, Sep 15, 2023 at 02:43:04PM -0400, Frank Li wrote: > Difference layerscape chip have not difference exit_from_l2() method. > Using function pointer for ls1028. It prepare for other layerscape > suspend/resume support. > How about: Since difference SoCs require different sequence for exiting L2, let's add a separate "exit_from_l2()" callback. This callback can be used to execute SoC specific sequence. > Signed-off-by: Frank Li > --- > drivers/pci/controller/dwc/pci-layerscape.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index b931d597656f6..20c48c06e2248 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -39,6 +39,8 @@ > > struct ls_pcie_drvdata { > const u32 pf_off; > + const struct dw_pcie_host_ops *ops; Where is this ops used? If this is added as a preparatory for next patches, I'd suggest you to move it to the respective one instead to avoid confusion. > + void (*exit_from_l2)(struct dw_pcie_rp *pp); > bool pm_support; > }; > > @@ -180,6 +182,7 @@ static const struct ls_pcie_drvdata ls1021a_drvdata = { > static const struct ls_pcie_drvdata layerscape_drvdata = { > .pf_off = 0xc0000, > .pm_support = true, > + .exit_from_l2 = ls_pcie_exit_from_l2, > }; > > static const struct of_device_id ls_pcie_of_match[] = { > @@ -213,7 +216,7 @@ static int ls_pcie_probe(struct platform_device *pdev) > pcie->drvdata = of_device_get_match_data(dev); > > pci->dev = dev; > - pci->pp.ops = &ls_pcie_host_ops; > + pci->pp.ops = pcie->drvdata->ops ? pcie->drvdata->ops : &ls_pcie_host_ops; This one also. > > pcie->pci = pci; > > @@ -251,7 +254,7 @@ static int ls_pcie_resume_noirq(struct device *dev) > if (!pcie->drvdata->pm_support) > return 0; > > - ls_pcie_exit_from_l2(&pcie->pci->pp); > + pcie->drvdata->exit_from_l2(&pcie->pci->pp); You should always check for the existence of the callback first before invoking it. - Mani > > return dw_pcie_resume_noirq(pcie->pci); > } > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 549C5CDB465 for ; Mon, 16 Oct 2023 16:41:47 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=j3TPYKUB; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S8NDT6Jd9z3c5b for ; Tue, 17 Oct 2023 03:41:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=j3TPYKUB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::f2a; helo=mail-qv1-xf2a.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S8NCV2Rn5z3c4y for ; Tue, 17 Oct 2023 03:40:52 +1100 (AEDT) Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-66d09b6d007so31974406d6.1 for ; Mon, 16 Oct 2023 09:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697474446; x=1698079246; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QMErPVjbDQWKUZJi0yx3PHwgd44uCsmqExmEKyoGenQ=; b=j3TPYKUB9FLUhJ2B7W0vT8SulJOgKuBE5A8uj7Z5lEbOwdEfZ/Bd15x/a8NxVvFgmy nyVMM3O35k8rdka7/YLEi93WYmUkj3J2teU+mFn3Kt+RWg7xHgDO3dgY7jNbldh7av8H TbKc6e+VvSYRI3xW376Vdncl2+ZaAZ1g3TocS1DPOUMs2g8cw9HLRremX9+bDi1JTK9m WYZlaLT+msYk4sBsFmtm5UWtDnlkRTUJiCRrOsALPOGLygPhRIoJ/Rf4mQDqGiS+vQG5 PHN/21a+mxWqYJnSGf67uxskhxYSOxLdS5rfVvF02hp/qRg4X/ordH7eYUqNR/UQvp4A 5ynA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697474446; x=1698079246; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QMErPVjbDQWKUZJi0yx3PHwgd44uCsmqExmEKyoGenQ=; b=COpLCuURznd5L0GsU9+ZcZ60ws6zIiHlJ/pyhhuxf2wJyhJ+zbudjzjcJeQmJMptJj 5DKqtmSmwNkJj5HV7oHAJPwMOUf6EX+WJ7sS/eq02EtebAvz2vF9xFAhmSlR45ptnDWl fO1Vpea5aA19G3s8PxjcHRtizQ0trAmdnZC7XCJIbtS5uMa4jd/+z3zrvl7mjydkUi2H uHL+HJqWSI2KEYfT2kvGEmd/yMBtTK2PiH2VyoeZmvH6ne6skIB8bZlBhzHwe8d2k3rD /hkFnxBxbMsVQMKXpVWtnZEJHBL2Qin1Ujbw12aZFBZsBrc+feJM96rDKHopQA7j7OWd oaJA== X-Gm-Message-State: AOJu0YyxTesGlwapSoGOwol62AAMWRSv/Tkr1RzKmIcrvXVPYvpnlbSx M+PIK0Cb4gZPF6tdk8efJrdW X-Google-Smtp-Source: AGHT+IEJrtLsab3W/titRBbEr+F6cON9aYDks19MkUWPWxcQNbAkkCh7gLRrSjOouWXUxCmZiVJgZQ== X-Received: by 2002:a05:6214:cae:b0:66d:28a5:d153 with SMTP id s14-20020a0562140cae00b0066d28a5d153mr11497866qvs.47.1697474445956; Mon, 16 Oct 2023 09:40:45 -0700 (PDT) Received: from thinkpad ([117.207.31.199]) by smtp.gmail.com with ESMTPSA id dn8-20020a056214094800b0065b0e724f83sm3548177qvb.6.2023.10.16.09.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:40:45 -0700 (PDT) Date: Mon, 16 Oct 2023 22:10:36 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH 1/3] PCI: layerscape: add function pointer for exit_from_l2() Message-ID: <20231016164036.GE39962@thinkpad> References: <20230915184306.2374670-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230915184306.2374670-1-Frank.Li@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , imx@lists.linux.dev, Rob Herring , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Lorenzo Pieralisi , open list , Minghuan Lian , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Roy Zang , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Mingkai Hu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 15, 2023 at 02:43:04PM -0400, Frank Li wrote: > Difference layerscape chip have not difference exit_from_l2() method. > Using function pointer for ls1028. It prepare for other layerscape > suspend/resume support. > How about: Since difference SoCs require different sequence for exiting L2, let's add a separate "exit_from_l2()" callback. This callback can be used to execute SoC specific sequence. > Signed-off-by: Frank Li > --- > drivers/pci/controller/dwc/pci-layerscape.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index b931d597656f6..20c48c06e2248 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -39,6 +39,8 @@ > > struct ls_pcie_drvdata { > const u32 pf_off; > + const struct dw_pcie_host_ops *ops; Where is this ops used? If this is added as a preparatory for next patches, I'd suggest you to move it to the respective one instead to avoid confusion. > + void (*exit_from_l2)(struct dw_pcie_rp *pp); > bool pm_support; > }; > > @@ -180,6 +182,7 @@ static const struct ls_pcie_drvdata ls1021a_drvdata = { > static const struct ls_pcie_drvdata layerscape_drvdata = { > .pf_off = 0xc0000, > .pm_support = true, > + .exit_from_l2 = ls_pcie_exit_from_l2, > }; > > static const struct of_device_id ls_pcie_of_match[] = { > @@ -213,7 +216,7 @@ static int ls_pcie_probe(struct platform_device *pdev) > pcie->drvdata = of_device_get_match_data(dev); > > pci->dev = dev; > - pci->pp.ops = &ls_pcie_host_ops; > + pci->pp.ops = pcie->drvdata->ops ? pcie->drvdata->ops : &ls_pcie_host_ops; This one also. > > pcie->pci = pci; > > @@ -251,7 +254,7 @@ static int ls_pcie_resume_noirq(struct device *dev) > if (!pcie->drvdata->pm_support) > return 0; > > - ls_pcie_exit_from_l2(&pcie->pci->pp); > + pcie->drvdata->exit_from_l2(&pcie->pci->pp); You should always check for the existence of the callback first before invoking it. - Mani > > return dw_pcie_resume_noirq(pcie->pci); > } > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D596FCDB465 for ; Mon, 16 Oct 2023 16:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WtvICQaTNHx6X/Jks832V7iTEFVu5Kkzqs5SxoLQHaE=; b=Mc6Nc7URYHHpJS T9iYtawF23oEXSGZgsfb7bTREzdXk8WkzlkADh3iPp6QLXy97E1oyglHaNm2oEUvgTRwLZ0gAFvlw GpKs2kq/o3W/YWittLdT9kMgvh0Y26LFLw8W94jsX5oQ7EkhPwOfVk16zfjS2962sIdc49C2Ona/x XFrvLCq3vHMI+2EHkjFQ42kRo/oELS3sd+3dPHrg40JCiNyNvHfkdoNIDoh7ZzRrrd0jcnjgSwYRz myziWSgzG8sFH0wdPljKgQ8abxAjOMe4BrU/iGvc3Zcys6IU2++h0hWP0EtOef653vwV4Bees0kbb cBQ4Gvsou2nDem9ArkfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsQeC-00A9mY-2C; Mon, 16 Oct 2023 16:40:52 +0000 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsQe9-00A9lV-2a for linux-arm-kernel@lists.infradead.org; Mon, 16 Oct 2023 16:40:51 +0000 Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-66d134a019cso30842576d6.3 for ; Mon, 16 Oct 2023 09:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697474446; x=1698079246; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QMErPVjbDQWKUZJi0yx3PHwgd44uCsmqExmEKyoGenQ=; b=hoBdRITNfd33ZQxjTAxQ6nVtow0WJW5bIhzX6KX4nqt6zFhqcr962FctA1JHnRTaHn slxONUTDhXpNUrzEwhyYH7jUvgIQnsRGJoarntag/L4O32NJ46xiS2eYwCxEAeIjk2HU UxFKINWvg1dPnZQdH/Y3hfyKWXp0uAWOgJTBdaToG9e1qCY+ZsSBszmjNmtm9tXKpyUl wYMQWT1/SLSL3FP5W5+RIKStnI10tPXd5XW/aqu/iTIwyldIAIsOeKymqewzBwSZALSI X/cANTrSwIP+b/jayTi5J6Ibp3zx5/QbtlNNaw2bU2Wz6MUbrLUk2cmOwT/id8Yo5a+O MQSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697474446; x=1698079246; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QMErPVjbDQWKUZJi0yx3PHwgd44uCsmqExmEKyoGenQ=; b=cOxWhaKR6fC3b5eXb6psAPfW7MRmByZjg0wjhkKAjeooILkcDyaDRy47PGAlKLWltz hVO8NqWxSRhp85mbvVvRUZ2EWKIkx6pu5r7Fp6MXEbOACX7cXTCSP8LIlDSLKQUQqQoH h3klCl8ghmbPWh9F9uEIETsUnY+Yfcac2flpZdjDlPDLsPMgSahp101nxcWd0WxhDVgK vb1Ije0cgon2QYlvap/wCGPaJPDC/kk//6qEV+6dGJO1FUHQCILLKmeMbwLjAeiEUbcd mpD85LzgXIpZicZygWG5mg0wBY2bu6XN1y+dD6D/3B2b7xdcsXQuEjrb/bOaWHcf/dUV 0PXg== X-Gm-Message-State: AOJu0YyXNcDqrvSScNhjiTAzbBRrKOY1/G6+29J59PEqyAwHWNf3kpFT UXTjxfO0q4UNdEfZWxHd2du2 X-Google-Smtp-Source: AGHT+IEJrtLsab3W/titRBbEr+F6cON9aYDks19MkUWPWxcQNbAkkCh7gLRrSjOouWXUxCmZiVJgZQ== X-Received: by 2002:a05:6214:cae:b0:66d:28a5:d153 with SMTP id s14-20020a0562140cae00b0066d28a5d153mr11497866qvs.47.1697474445956; Mon, 16 Oct 2023 09:40:45 -0700 (PDT) Received: from thinkpad ([117.207.31.199]) by smtp.gmail.com with ESMTPSA id dn8-20020a056214094800b0065b0e724f83sm3548177qvb.6.2023.10.16.09.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:40:45 -0700 (PDT) Date: Mon, 16 Oct 2023 22:10:36 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , imx@lists.linux.dev Subject: Re: [PATCH 1/3] PCI: layerscape: add function pointer for exit_from_l2() Message-ID: <20231016164036.GE39962@thinkpad> References: <20230915184306.2374670-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230915184306.2374670-1-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231016_094049_851167_0246AE11 X-CRM114-Status: GOOD ( 21.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBTZXAgMTUsIDIwMjMgYXQgMDI6NDM6MDRQTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gRGlmZmVyZW5jZSBsYXllcnNjYXBlIGNoaXAgaGF2ZSBub3QgZGlmZmVyZW5jZSBleGl0X2Zy b21fbDIoKSBtZXRob2QuCj4gVXNpbmcgZnVuY3Rpb24gcG9pbnRlciBmb3IgbHMxMDI4LiBJdCBw cmVwYXJlIGZvciBvdGhlciBsYXllcnNjYXBlCj4gc3VzcGVuZC9yZXN1bWUgc3VwcG9ydC4KPiAK CkhvdyBhYm91dDoKClNpbmNlIGRpZmZlcmVuY2UgU29DcyByZXF1aXJlIGRpZmZlcmVudCBzZXF1 ZW5jZSBmb3IgZXhpdGluZyBMMiwgbGV0J3MgYWRkIGEKc2VwYXJhdGUgImV4aXRfZnJvbV9sMigp IiBjYWxsYmFjay4gVGhpcyBjYWxsYmFjayBjYW4gYmUgdXNlZCB0byBleGVjdXRlIFNvQwpzcGVj aWZpYyBzZXF1ZW5jZS4KCj4gU2lnbmVkLW9mZi1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMg fCA3ICsrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWxh eWVyc2NhcGUuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMK PiBpbmRleCBiOTMxZDU5NzY1NmY2Li4yMGM0OGMwNmUyMjQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMKPiArKysgYi9kcml2ZXJzL3Bj aS9jb250cm9sbGVyL2R3Yy9wY2ktbGF5ZXJzY2FwZS5jCj4gQEAgLTM5LDYgKzM5LDggQEAKPiAg Cj4gIHN0cnVjdCBsc19wY2llX2RydmRhdGEgewo+ICAJY29uc3QgdTMyIHBmX29mZjsKPiArCWNv bnN0IHN0cnVjdCBkd19wY2llX2hvc3Rfb3BzICpvcHM7CgpXaGVyZSBpcyB0aGlzIG9wcyB1c2Vk PyBJZiB0aGlzIGlzIGFkZGVkIGFzIGEgcHJlcGFyYXRvcnkgZm9yIG5leHQgcGF0Y2hlcywgSSdk CnN1Z2dlc3QgeW91IHRvIG1vdmUgaXQgdG8gdGhlIHJlc3BlY3RpdmUgb25lIGluc3RlYWQgdG8g YXZvaWQgY29uZnVzaW9uLgoKPiArCXZvaWQgKCpleGl0X2Zyb21fbDIpKHN0cnVjdCBkd19wY2ll X3JwICpwcCk7Cj4gIAlib29sIHBtX3N1cHBvcnQ7Cj4gIH07Cj4gIAo+IEBAIC0xODAsNiArMTgy LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBsc19wY2llX2RydmRhdGEgbHMxMDIxYV9kcnZkYXRh ID0gewo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGxzX3BjaWVfZHJ2ZGF0YSBsYXllcnNjYXBlX2Ry dmRhdGEgPSB7Cj4gIAkucGZfb2ZmID0gMHhjMDAwMCwKPiAgCS5wbV9zdXBwb3J0ID0gdHJ1ZSwK PiArCS5leGl0X2Zyb21fbDIgPSBsc19wY2llX2V4aXRfZnJvbV9sMiwKPiAgfTsKPiAgCj4gIHN0 YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIGxzX3BjaWVfb2ZfbWF0Y2hbXSA9IHsKPiBA QCAtMjEzLDcgKzIxNiw3IEBAIHN0YXRpYyBpbnQgbHNfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2KQo+ICAJcGNpZS0+ZHJ2ZGF0YSA9IG9mX2RldmljZV9nZXRfbWF0Y2hf ZGF0YShkZXYpOwo+ICAKPiAgCXBjaS0+ZGV2ID0gZGV2Owo+IC0JcGNpLT5wcC5vcHMgPSAmbHNf cGNpZV9ob3N0X29wczsKPiArCXBjaS0+cHAub3BzID0gcGNpZS0+ZHJ2ZGF0YS0+b3BzID8gcGNp ZS0+ZHJ2ZGF0YS0+b3BzIDogJmxzX3BjaWVfaG9zdF9vcHM7CgpUaGlzIG9uZSBhbHNvLgoKPiAg Cj4gIAlwY2llLT5wY2kgPSBwY2k7Cj4gIAo+IEBAIC0yNTEsNyArMjU0LDcgQEAgc3RhdGljIGlu dCBsc19wY2llX3Jlc3VtZV9ub2lycShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAlpZiAoIXBjaWUt PmRydmRhdGEtPnBtX3N1cHBvcnQpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+IC0JbHNfcGNpZV9leGl0 X2Zyb21fbDIoJnBjaWUtPnBjaS0+cHApOwo+ICsJcGNpZS0+ZHJ2ZGF0YS0+ZXhpdF9mcm9tX2wy KCZwY2llLT5wY2ktPnBwKTsKCllvdSBzaG91bGQgYWx3YXlzIGNoZWNrIGZvciB0aGUgZXhpc3Rl bmNlIG9mIHRoZSBjYWxsYmFjayBmaXJzdCBiZWZvcmUgaW52b2tpbmcKaXQuCgotIE1hbmkKCj4g IAo+ICAJcmV0dXJuIGR3X3BjaWVfcmVzdW1lX25vaXJxKHBjaWUtPnBjaSk7Cj4gIH0KPiAtLSAK PiAyLjM0LjEKPiAKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a 4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==