From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 983D030FA3 for ; Mon, 16 Oct 2023 16:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p6RTuco8" Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-d9a518d66a1so5618265276.0 for ; Mon, 16 Oct 2023 09:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697475515; x=1698080315; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Afu5xdjrM60kr5jPKowmDpQRJUH3WWvLNXM6VlnD7Ds=; b=p6RTuco8YIAKe+EY39PcErkcfG3u1bY4k9GDNz4l9adXRpOJQEBk03FRPT4UrNJqPj sq5aIQ3Mr+ob54qIJexYG2NWee4M65w146wukhBWfqBuQw/vXZqZq27SDGtV+7Jgddor hAkbB9zC3FQgpHtAvHo4R8pl5SeCm1upYaFJLQONuHmsga/56WrICkQ1v/m5jBqdQ5xN Pg17s6rCd41cdRsWyxzgg1Mn3Haz78xOVWLIXJB1p2T7E+FhP2rerZTKqwr0d8UY2Hzy 6s0kA4qqZj0K96NN8xK5cZmSoxfbHHNVl/O6bv3y19Vfwm9/lZl12cu2C0g6BP3Vp9zv WEhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697475515; x=1698080315; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Afu5xdjrM60kr5jPKowmDpQRJUH3WWvLNXM6VlnD7Ds=; b=vbfOhUd7se5P+/1VHPIEEqywqQ81eB6TK6ZuZevuCvLa2FAGjqMDufJGtw2efJ/jkp 0YfxwhwGieiSlkrkHto5c29UiFqoEfZ1pv8DxQmEdor0SW+85tBxez+6KikFJiIOOmSV JyaNtp0gacvaHeK/3Au65n5E63p5VoYMLaMPNEnFUiUris7U4xvyZd9+0KEDbnKwTSk8 uOqJRIykzBaVzB4R90UVO1tCY7HKXhPlNMGC7ZpRlLTf7kHNtefayKMI16Pj14I8q3cg tM+uEo4VF0PtvE5MFeTZEp2m+D6KvxkE0V1ufYw5PBivVsru5DLAcHo+hUY5VYlcKM0z z7Yw== X-Gm-Message-State: AOJu0Yw1TrjWXgrz1bWqHaTg7sjy9TyQGvX6S0QBUYCNanaahz3Rxo9S 8Iaqs2MBZff5aHUxNnZ9u1ze X-Google-Smtp-Source: AGHT+IEFaxm77O8Qvj9+hGJ9O76en3aHbv05oX+Ne6kwKs5h2XLGTM7ESsLfBmjCk7ynOa6kMoTGzw== X-Received: by 2002:a25:ae85:0:b0:d9a:4362:67ac with SMTP id b5-20020a25ae85000000b00d9a436267acmr18122044ybj.15.1697475515480; Mon, 16 Oct 2023 09:58:35 -0700 (PDT) Received: from thinkpad ([117.207.31.199]) by smtp.gmail.com with ESMTPSA id s8-20020ad45008000000b0065afd35c762sm3564494qvo.91.2023.10.16.09.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:58:35 -0700 (PDT) Date: Mon, 16 Oct 2023 22:28:24 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , imx@lists.linux.dev Subject: Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a Message-ID: <20231016165824.GF39962@thinkpad> References: <20230915184306.2374670-1-Frank.Li@nxp.com> <20230915184306.2374670-2-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230915184306.2374670-2-Frank.Li@nxp.com> On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote: > ls1021a add suspend/resume support. > Please add what the driver is doing during suspend/resume. > Signed-off-by: Frank Li > --- > drivers/pci/controller/dwc/pci-layerscape.c | 88 ++++++++++++++++++++- > 1 file changed, 87 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 20c48c06e2248..bc5a8ff1a26ce 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -35,6 +35,12 @@ > #define PF_MCR_PTOMR BIT(0) > #define PF_MCR_EXL2S BIT(1) > > +/* LS1021A PEXn PM Write Control Register */ > +#define SCFG_PEXPMWRCR(idx) (0x5c + (idx) * 0x64) > +#define PMXMTTURNOFF BIT(31) > +#define SCFG_PEXSFTRSTCR 0x190 > +#define PEXSR(idx) BIT(idx) > + > #define PCIE_IATU_NUM 6 > > struct ls_pcie_drvdata { > @@ -48,6 +54,8 @@ struct ls_pcie { > struct dw_pcie *pci; > const struct ls_pcie_drvdata *drvdata; > void __iomem *pf_base; > + struct regmap *scfg; > + int index; > bool big_endian; > }; > > @@ -170,13 +178,91 @@ static int ls_pcie_host_init(struct dw_pcie_rp *pp) > return 0; > } > > +static void ls1021a_pcie_send_turnoff_msg(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + > + if (!pcie->scfg) { Can this ever happen? > + dev_dbg(pcie->pci->dev, "SYSCFG is NULL\n"); > + return; > + } > + > + /* Send Turn_off message */ "Send PME_Turn_Off message" > + regmap_read(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), &val); > + val |= PMXMTTURNOFF; > + regmap_write(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), val); > + > + /* There are not register to check ACK, so wait PCIE_PME_TO_L2_TIMEOUT_US */ "There is no specific register to check for PME_To_Ack from endpoint. So on the safe side, wait for PCIE_PME_TO_L2_TIMEOUT_US." > + mdelay(PCIE_PME_TO_L2_TIMEOUT_US/1000); > + > + /* Clear Turn_off message */ "PME_Turn_off". But I'm not sure if this is really required. Are you doing it because the layerspace hw implements the PME_Turn_Off bit as "level triggered"? > + regmap_read(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), &val); > + val &= ~PMXMTTURNOFF; > + regmap_write(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), val); > +} > + > +static void ls1021a_pcie_exit_from_l2(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + A comment here would be good. > + regmap_read(pcie->scfg, SCFG_PEXSFTRSTCR, &val); > + val |= PEXSR(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXSFTRSTCR, val); > + > + regmap_read(pcie->scfg, SCFG_PEXSFTRSTCR, &val); > + val &= ~PEXSR(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXSFTRSTCR, val); > +} > + > +static int ls1021a_pcie_host_init(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + struct device *dev = pcie->pci->dev; > + u32 index[2]; > + int ret; > + > + ret = ls_pcie_host_init(pp); > + if (ret) > + return ret; > + > + pcie->scfg = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,pcie-scfg"); > + if (IS_ERR(pcie->scfg)) { > + ret = PTR_ERR(pcie->scfg); > + dev_err(dev, "No syscfg phandle specified\n"); > + pcie->scfg = NULL; > + return ret; > + } > + > + ret = of_property_read_u32_array(dev->of_node, "fsl,pcie-scfg", index, 2); > + if (ret) { > + pcie->scfg = NULL; > + return ret; > + } > + > + pcie->index = index[1]; > + The above syscon parsing could be done conditionally during probe itself. There is no need to do it during host_init() time. - Mani > + return ret; > +} > + > static const struct dw_pcie_host_ops ls_pcie_host_ops = { > .host_init = ls_pcie_host_init, > .pme_turn_off = ls_pcie_send_turnoff_msg, > }; > > +static const struct dw_pcie_host_ops ls1021a_pcie_host_ops = { > + .host_init = ls1021a_pcie_host_init, > + .pme_turn_off = ls1021a_pcie_send_turnoff_msg, > +}; > + > static const struct ls_pcie_drvdata ls1021a_drvdata = { > - .pm_support = false, > + .pm_support = true, > + .ops = &ls1021a_pcie_host_ops, > + .exit_from_l2 = ls1021a_pcie_exit_from_l2, > }; > > static const struct ls_pcie_drvdata layerscape_drvdata = { > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AA7DCDB465 for ; Mon, 16 Oct 2023 16:59:32 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=TO2NiRvQ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S8Ncy3y62z3dDq for ; Tue, 17 Oct 2023 03:59:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=TO2NiRvQ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::b33; helo=mail-yb1-xb33.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S8Nc03zL3z2xl6 for ; Tue, 17 Oct 2023 03:58:38 +1100 (AEDT) Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-d9beb863816so1267977276.1 for ; Mon, 16 Oct 2023 09:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697475515; x=1698080315; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Afu5xdjrM60kr5jPKowmDpQRJUH3WWvLNXM6VlnD7Ds=; b=TO2NiRvQk70CFuEKNHhONrFDdjPwc/qB2T1/JbnSOH4VZX1kcfRVOAi9Bx3KxJgYAI K8LoXElT2mVXTQnAun0ldpwLWRfVyrNlcw5AZpduRV4tdDH3TOGcDkJGu/JojQLuH9zE kykISItNTzZznFNlYG4eGIjPEfMWYN09mWfNIodMrciYMul0b0HzPkaOproKMDPbzO54 eyY2LRCPDZZxJFH3j4vuZCoGUbNPYrIMj2gm16n8J22A4dCpB7RZ3rJiLfdfmXw72N6s zr4WeA9Mm1mlXewnziESaRNc3tzTyKHqTYQizlfpbWnw1Oboun/7TGgwkAKSlXMAJUmc LMfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697475515; x=1698080315; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Afu5xdjrM60kr5jPKowmDpQRJUH3WWvLNXM6VlnD7Ds=; b=IDWr41q9UkwDsaGmoYKh/e3eL22283W1Pzli2m0KR7N4WFkjuy5jV6CbSoSiizBuKe j3Dw1bxGVFZnTT88LCAPzAslaFIvJFPFE6weNDHflipJdo8lhbxPrDReyvat/ACNLJht vXmVWxfX/ZM2v7ZcT3d5iyuSBngi05YwQj1OFv9YPd/zBYIG+nBAwpchIF+ZWqv26Y74 ZyIkM031G9EgdbXotQS4hovfFCwy+YRJUx/k/jDXEcBiMBs/zcsp/iPjof5IdhPRDCPs E/LoPZ6NtgncFOeQzh/1RY00locr9dnsnRv7lv5Ix4QaAl6xxZqe4UfYApsxTb+0WD54 XQTA== X-Gm-Message-State: AOJu0YwHFalH9jan7/mjDPDSzFaBdWhavqiPrSgL4fQFcY39NL07H2yy M29zw5NBXcfDcEMeZ1ma5JUB X-Google-Smtp-Source: AGHT+IEFaxm77O8Qvj9+hGJ9O76en3aHbv05oX+Ne6kwKs5h2XLGTM7ESsLfBmjCk7ynOa6kMoTGzw== X-Received: by 2002:a25:ae85:0:b0:d9a:4362:67ac with SMTP id b5-20020a25ae85000000b00d9a436267acmr18122044ybj.15.1697475515480; Mon, 16 Oct 2023 09:58:35 -0700 (PDT) Received: from thinkpad ([117.207.31.199]) by smtp.gmail.com with ESMTPSA id s8-20020ad45008000000b0065afd35c762sm3564494qvo.91.2023.10.16.09.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:58:35 -0700 (PDT) Date: Mon, 16 Oct 2023 22:28:24 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a Message-ID: <20231016165824.GF39962@thinkpad> References: <20230915184306.2374670-1-Frank.Li@nxp.com> <20230915184306.2374670-2-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230915184306.2374670-2-Frank.Li@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , imx@lists.linux.dev, Rob Herring , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Lorenzo Pieralisi , open list , Minghuan Lian , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Roy Zang , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Mingkai Hu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote: > ls1021a add suspend/resume support. > Please add what the driver is doing during suspend/resume. > Signed-off-by: Frank Li > --- > drivers/pci/controller/dwc/pci-layerscape.c | 88 ++++++++++++++++++++- > 1 file changed, 87 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 20c48c06e2248..bc5a8ff1a26ce 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -35,6 +35,12 @@ > #define PF_MCR_PTOMR BIT(0) > #define PF_MCR_EXL2S BIT(1) > > +/* LS1021A PEXn PM Write Control Register */ > +#define SCFG_PEXPMWRCR(idx) (0x5c + (idx) * 0x64) > +#define PMXMTTURNOFF BIT(31) > +#define SCFG_PEXSFTRSTCR 0x190 > +#define PEXSR(idx) BIT(idx) > + > #define PCIE_IATU_NUM 6 > > struct ls_pcie_drvdata { > @@ -48,6 +54,8 @@ struct ls_pcie { > struct dw_pcie *pci; > const struct ls_pcie_drvdata *drvdata; > void __iomem *pf_base; > + struct regmap *scfg; > + int index; > bool big_endian; > }; > > @@ -170,13 +178,91 @@ static int ls_pcie_host_init(struct dw_pcie_rp *pp) > return 0; > } > > +static void ls1021a_pcie_send_turnoff_msg(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + > + if (!pcie->scfg) { Can this ever happen? > + dev_dbg(pcie->pci->dev, "SYSCFG is NULL\n"); > + return; > + } > + > + /* Send Turn_off message */ "Send PME_Turn_Off message" > + regmap_read(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), &val); > + val |= PMXMTTURNOFF; > + regmap_write(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), val); > + > + /* There are not register to check ACK, so wait PCIE_PME_TO_L2_TIMEOUT_US */ "There is no specific register to check for PME_To_Ack from endpoint. So on the safe side, wait for PCIE_PME_TO_L2_TIMEOUT_US." > + mdelay(PCIE_PME_TO_L2_TIMEOUT_US/1000); > + > + /* Clear Turn_off message */ "PME_Turn_off". But I'm not sure if this is really required. Are you doing it because the layerspace hw implements the PME_Turn_Off bit as "level triggered"? > + regmap_read(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), &val); > + val &= ~PMXMTTURNOFF; > + regmap_write(pcie->scfg, SCFG_PEXPMWRCR(pcie->index), val); > +} > + > +static void ls1021a_pcie_exit_from_l2(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + A comment here would be good. > + regmap_read(pcie->scfg, SCFG_PEXSFTRSTCR, &val); > + val |= PEXSR(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXSFTRSTCR, val); > + > + regmap_read(pcie->scfg, SCFG_PEXSFTRSTCR, &val); > + val &= ~PEXSR(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXSFTRSTCR, val); > +} > + > +static int ls1021a_pcie_host_init(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + struct device *dev = pcie->pci->dev; > + u32 index[2]; > + int ret; > + > + ret = ls_pcie_host_init(pp); > + if (ret) > + return ret; > + > + pcie->scfg = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,pcie-scfg"); > + if (IS_ERR(pcie->scfg)) { > + ret = PTR_ERR(pcie->scfg); > + dev_err(dev, "No syscfg phandle specified\n"); > + pcie->scfg = NULL; > + return ret; > + } > + > + ret = of_property_read_u32_array(dev->of_node, "fsl,pcie-scfg", index, 2); > + if (ret) { > + pcie->scfg = NULL; > + return ret; > + } > + > + pcie->index = index[1]; > + The above syscon parsing could be done conditionally during probe itself. There is no need to do it during host_init() time. - Mani > + return ret; > +} > + > static const struct dw_pcie_host_ops ls_pcie_host_ops = { > .host_init = ls_pcie_host_init, > .pme_turn_off = ls_pcie_send_turnoff_msg, > }; > > +static const struct dw_pcie_host_ops ls1021a_pcie_host_ops = { > + .host_init = ls1021a_pcie_host_init, > + .pme_turn_off = ls1021a_pcie_send_turnoff_msg, > +}; > + > static const struct ls_pcie_drvdata ls1021a_drvdata = { > - .pm_support = false, > + .pm_support = true, > + .ops = &ls1021a_pcie_host_ops, > + .exit_from_l2 = ls1021a_pcie_exit_from_l2, > }; > > static const struct ls_pcie_drvdata layerscape_drvdata = { > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B864CDB465 for ; Mon, 16 Oct 2023 16:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pqj/U3bsZKxA3TQeAuVHiJosNOlowf5pp+PFWnmTX0g=; b=1fOZgoQ3RTgZo5 bsrkXJ1XB8qcFFM9kQb2TmJjSZ93pRz4YEYuG2i97/BRNXK50SFF1OYamWfVIcUpKJMK7I97FSuuP TKA2Hm5vBqnrTjgWm5gQcctO3wBO5/TPKroO6k9OuTPUXP2zN8rORLKza0HuqtfXzdCnf6jD5z0oG 8KDPkaHzeDCnlxi3fswpd5clldjOs5L2Jm4+3KeFQiRhjLUH/cNa8qLwntUGgfX9Jt1i3ShSzAyL6 toX67UCmQDk41U8SClKNerOokPnhZqJUNqsvDv5Nu5Wgk4A4YYohT1zKXi6/KwCcB9Twb28ho3WXg oldXca+7Li8A6ZVQR+HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsQvQ-00ACEV-1e; Mon, 16 Oct 2023 16:58:40 +0000 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsQvN-00ACE7-31 for linux-arm-kernel@lists.infradead.org; Mon, 16 Oct 2023 16:58:39 +0000 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-d9a518d66a1so5618266276.0 for ; Mon, 16 Oct 2023 09:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697475515; x=1698080315; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Afu5xdjrM60kr5jPKowmDpQRJUH3WWvLNXM6VlnD7Ds=; b=N9f9zVik1yI5BtMyoD0b+M7Ze1eLXLYCs59UlulhQ1EaWow9T8kq941Xm9UhOX6ycR 4uX5gwMBX52dpbl2cKAaitZy2W18Y5qFvgTCqE0Qyy8VNth3Ys9USIYBAo4YQyKCYH0n A4+KoYVcAhHeF34zqeTVw69WarXdSANnntVQEJxQunPcNZJwHmIosulpWesakBGrIqkV wOTRf6BQ3KbuVbF+tnpG66c2CF9cDrwhUcAQxRUgV5j39Sm1cIvSRFxHUsVSaa0zeDOG nVQmIHFDOiv2p+h//a467S+S/cVchZuiarEtYoL95en/2OIT/1q26ZeE4ax1Q0kD6z/A 3FbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697475515; x=1698080315; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Afu5xdjrM60kr5jPKowmDpQRJUH3WWvLNXM6VlnD7Ds=; b=C4R12xlaNk7ZcVDQEjMB79N9r0BeszSqCrKCE3CMS2qsxlzJ+qTM0jeoV9rtOAWKn1 ljv+r1IccxtrpJ5Cw3jPmMpA43NUN7P5uhzXwj6u1N0LCIhJ7TBEYH7wEkqtn++KmP3p fgCAhAYi4YpImGlXlelGTbtSb+z+6ldkYAED13W2wIEzdvwsLt+gngpkDu0dc7T4zT0x b97INy2itBDCupakusExHz+Dm9ZgesiTGBnlHfLlMct+b9U8t4zzo0h356ClaoIWtuRG B+puc4Pf5CozeILG0mMvllF+nGlqZQSdBMgmSg+BmGwpdvdU017Gg9CDfwGPnke8ECyt 9VyA== X-Gm-Message-State: AOJu0Yx2yH2WVFDPDDphh5iRxxodYWiE+ZQKfP4e5pd3k4C03lDRfNUq oNy/YZkcO0/bhjg2FNbUhlNT X-Google-Smtp-Source: AGHT+IEFaxm77O8Qvj9+hGJ9O76en3aHbv05oX+Ne6kwKs5h2XLGTM7ESsLfBmjCk7ynOa6kMoTGzw== X-Received: by 2002:a25:ae85:0:b0:d9a:4362:67ac with SMTP id b5-20020a25ae85000000b00d9a436267acmr18122044ybj.15.1697475515480; Mon, 16 Oct 2023 09:58:35 -0700 (PDT) Received: from thinkpad ([117.207.31.199]) by smtp.gmail.com with ESMTPSA id s8-20020ad45008000000b0065afd35c762sm3564494qvo.91.2023.10.16.09.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:58:35 -0700 (PDT) Date: Mon, 16 Oct 2023 22:28:24 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , imx@lists.linux.dev Subject: Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a Message-ID: <20231016165824.GF39962@thinkpad> References: <20230915184306.2374670-1-Frank.Li@nxp.com> <20230915184306.2374670-2-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230915184306.2374670-2-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231016_095837_984475_A0559560 X-CRM114-Status: GOOD ( 27.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBTZXAgMTUsIDIwMjMgYXQgMDI6NDM6MDVQTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gbHMxMDIxYSBhZGQgc3VzcGVuZC9yZXN1bWUgc3VwcG9ydC4KPiAKClBsZWFzZSBhZGQgd2hh dCB0aGUgZHJpdmVyIGlzIGRvaW5nIGR1cmluZyBzdXNwZW5kL3Jlc3VtZS4KCj4gU2lnbmVkLW9m Zi1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMgfCA4OCArKysrKysrKysrKysrKysrKysrKy0K PiAgMSBmaWxlIGNoYW5nZWQsIDg3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWxheWVyc2NhcGUuYyBi L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMKPiBpbmRleCAyMGM0 OGMwNmUyMjQ4Li5iYzVhOGZmMWEyNmNlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMKPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2ktbGF5ZXJzY2FwZS5jCj4gQEAgLTM1LDYgKzM1LDEyIEBACj4gICNkZWZpbmUgUEZf TUNSX1BUT01SCQlCSVQoMCkKPiAgI2RlZmluZSBQRl9NQ1JfRVhMMlMJCUJJVCgxKQo+ICAKPiAr LyogTFMxMDIxQSBQRVhuIFBNIFdyaXRlIENvbnRyb2wgUmVnaXN0ZXIgKi8KPiArI2RlZmluZSBT Q0ZHX1BFWFBNV1JDUihpZHgpCSgweDVjICsgKGlkeCkgKiAweDY0KQo+ICsjZGVmaW5lIFBNWE1U VFVSTk9GRgkJQklUKDMxKQo+ICsjZGVmaW5lIFNDRkdfUEVYU0ZUUlNUQ1IJMHgxOTAKPiArI2Rl ZmluZSBQRVhTUihpZHgpCQlCSVQoaWR4KQo+ICsKPiAgI2RlZmluZSBQQ0lFX0lBVFVfTlVNCQk2 Cj4gIAo+ICBzdHJ1Y3QgbHNfcGNpZV9kcnZkYXRhIHsKPiBAQCAtNDgsNiArNTQsOCBAQCBzdHJ1 Y3QgbHNfcGNpZSB7Cj4gIAlzdHJ1Y3QgZHdfcGNpZSAqcGNpOwo+ICAJY29uc3Qgc3RydWN0IGxz X3BjaWVfZHJ2ZGF0YSAqZHJ2ZGF0YTsKPiAgCXZvaWQgX19pb21lbSAqcGZfYmFzZTsKPiArCXN0 cnVjdCByZWdtYXAgKnNjZmc7Cj4gKwlpbnQgaW5kZXg7Cj4gIAlib29sIGJpZ19lbmRpYW47Cj4g IH07Cj4gIAo+IEBAIC0xNzAsMTMgKzE3OCw5MSBAQCBzdGF0aWMgaW50IGxzX3BjaWVfaG9zdF9p bml0KHN0cnVjdCBkd19wY2llX3JwICpwcCkKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtzdGF0 aWMgdm9pZCBsczEwMjFhX3BjaWVfc2VuZF90dXJub2ZmX21zZyhzdHJ1Y3QgZHdfcGNpZV9ycCAq cHApCj4gK3sKPiArCXN0cnVjdCBkd19wY2llICpwY2kgPSB0b19kd19wY2llX2Zyb21fcHAocHAp Owo+ICsJc3RydWN0IGxzX3BjaWUgKnBjaWUgPSB0b19sc19wY2llKHBjaSk7Cj4gKwl1MzIgdmFs Owo+ICsKPiArCWlmICghcGNpZS0+c2NmZykgewoKQ2FuIHRoaXMgZXZlciBoYXBwZW4/Cgo+ICsJ CWRldl9kYmcocGNpZS0+cGNpLT5kZXYsICJTWVNDRkcgaXMgTlVMTFxuIik7Cj4gKwkJcmV0dXJu Owo+ICsJfQo+ICsKPiArCS8qIFNlbmQgVHVybl9vZmYgbWVzc2FnZSAqLwoKIlNlbmQgUE1FX1R1 cm5fT2ZmIG1lc3NhZ2UiCgo+ICsJcmVnbWFwX3JlYWQocGNpZS0+c2NmZywgU0NGR19QRVhQTVdS Q1IocGNpZS0+aW5kZXgpLCAmdmFsKTsKPiArCXZhbCB8PSBQTVhNVFRVUk5PRkY7Cj4gKwlyZWdt YXBfd3JpdGUocGNpZS0+c2NmZywgU0NGR19QRVhQTVdSQ1IocGNpZS0+aW5kZXgpLCB2YWwpOwo+ ICsKPiArCS8qIFRoZXJlIGFyZSBub3QgcmVnaXN0ZXIgdG8gY2hlY2sgQUNLLCBzbyB3YWl0IFBD SUVfUE1FX1RPX0wyX1RJTUVPVVRfVVMgKi8KCiJUaGVyZSBpcyBubyBzcGVjaWZpYyByZWdpc3Rl ciB0byBjaGVjayBmb3IgUE1FX1RvX0FjayBmcm9tIGVuZHBvaW50LiBTbyBvbiB0aGUKc2FmZSBz aWRlLCB3YWl0IGZvciBQQ0lFX1BNRV9UT19MMl9USU1FT1VUX1VTLiIKCj4gKwltZGVsYXkoUENJ RV9QTUVfVE9fTDJfVElNRU9VVF9VUy8xMDAwKTsKPiArCj4gKwkvKiBDbGVhciBUdXJuX29mZiBt ZXNzYWdlICovCgoiUE1FX1R1cm5fb2ZmIi4gQnV0IEknbSBub3Qgc3VyZSBpZiB0aGlzIGlzIHJl YWxseSByZXF1aXJlZC4gQXJlIHlvdSBkb2luZyBpdApiZWNhdXNlIHRoZSBsYXllcnNwYWNlIGh3 IGltcGxlbWVudHMgdGhlIFBNRV9UdXJuX09mZiBiaXQgYXMgImxldmVsIHRyaWdnZXJlZCI/Cgo+ ICsJcmVnbWFwX3JlYWQocGNpZS0+c2NmZywgU0NGR19QRVhQTVdSQ1IocGNpZS0+aW5kZXgpLCAm dmFsKTsKPiArCXZhbCAmPSB+UE1YTVRUVVJOT0ZGOwo+ICsJcmVnbWFwX3dyaXRlKHBjaWUtPnNj ZmcsIFNDRkdfUEVYUE1XUkNSKHBjaWUtPmluZGV4KSwgdmFsKTsKPiArfQo+ICsKPiArc3RhdGlj IHZvaWQgbHMxMDIxYV9wY2llX2V4aXRfZnJvbV9sMihzdHJ1Y3QgZHdfcGNpZV9ycCAqcHApCj4g K3sKPiArCXN0cnVjdCBkd19wY2llICpwY2kgPSB0b19kd19wY2llX2Zyb21fcHAocHApOwo+ICsJ c3RydWN0IGxzX3BjaWUgKnBjaWUgPSB0b19sc19wY2llKHBjaSk7Cj4gKwl1MzIgdmFsOwo+ICsK CkEgY29tbWVudCBoZXJlIHdvdWxkIGJlIGdvb2QuCgo+ICsJcmVnbWFwX3JlYWQocGNpZS0+c2Nm ZywgU0NGR19QRVhTRlRSU1RDUiwgJnZhbCk7Cj4gKwl2YWwgfD0gUEVYU1IocGNpZS0+aW5kZXgp Owo+ICsJcmVnbWFwX3dyaXRlKHBjaWUtPnNjZmcsIFNDRkdfUEVYU0ZUUlNUQ1IsIHZhbCk7Cj4g Kwo+ICsJcmVnbWFwX3JlYWQocGNpZS0+c2NmZywgU0NGR19QRVhTRlRSU1RDUiwgJnZhbCk7Cj4g Kwl2YWwgJj0gflBFWFNSKHBjaWUtPmluZGV4KTsKPiArCXJlZ21hcF93cml0ZShwY2llLT5zY2Zn LCBTQ0ZHX1BFWFNGVFJTVENSLCB2YWwpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGxzMTAyMWFf cGNpZV9ob3N0X2luaXQoc3RydWN0IGR3X3BjaWVfcnAgKnBwKQo+ICt7Cj4gKwlzdHJ1Y3QgZHdf cGNpZSAqcGNpID0gdG9fZHdfcGNpZV9mcm9tX3BwKHBwKTsKPiArCXN0cnVjdCBsc19wY2llICpw Y2llID0gdG9fbHNfcGNpZShwY2kpOwo+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gcGNpZS0+cGNp LT5kZXY7Cj4gKwl1MzIgaW5kZXhbMl07Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXJldCA9IGxzX3Bj aWVfaG9zdF9pbml0KHBwKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlw Y2llLT5zY2ZnID0gc3lzY29uX3JlZ21hcF9sb29rdXBfYnlfcGhhbmRsZShkZXYtPm9mX25vZGUs ICJmc2wscGNpZS1zY2ZnIik7Cj4gKwlpZiAoSVNfRVJSKHBjaWUtPnNjZmcpKSB7Cj4gKwkJcmV0 ID0gUFRSX0VSUihwY2llLT5zY2ZnKTsKPiArCQlkZXZfZXJyKGRldiwgIk5vIHN5c2NmZyBwaGFu ZGxlIHNwZWNpZmllZFxuIik7Cj4gKwkJcGNpZS0+c2NmZyA9IE5VTEw7Cj4gKwkJcmV0dXJuIHJl dDsKPiArCX0KPiArCj4gKwlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFkX3UzMl9hcnJheShkZXYtPm9m X25vZGUsICJmc2wscGNpZS1zY2ZnIiwgaW5kZXgsIDIpOwo+ICsJaWYgKHJldCkgewo+ICsJCXBj aWUtPnNjZmcgPSBOVUxMOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJcGNpZS0+aW5k ZXggPSBpbmRleFsxXTsKPiArCgpUaGUgYWJvdmUgc3lzY29uIHBhcnNpbmcgY291bGQgYmUgZG9u ZSBjb25kaXRpb25hbGx5IGR1cmluZyBwcm9iZSBpdHNlbGYuIFRoZXJlCmlzIG5vIG5lZWQgdG8g ZG8gaXQgZHVyaW5nIGhvc3RfaW5pdCgpIHRpbWUuCgotIE1hbmkKCj4gKwlyZXR1cm4gcmV0Owo+ ICt9Cj4gKwo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGR3X3BjaWVfaG9zdF9vcHMgbHNfcGNpZV9o b3N0X29wcyA9IHsKPiAgCS5ob3N0X2luaXQgPSBsc19wY2llX2hvc3RfaW5pdCwKPiAgCS5wbWVf dHVybl9vZmYgPSBsc19wY2llX3NlbmRfdHVybm9mZl9tc2csCj4gIH07Cj4gIAo+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IGR3X3BjaWVfaG9zdF9vcHMgbHMxMDIxYV9wY2llX2hvc3Rfb3BzID0gewo+ ICsJLmhvc3RfaW5pdCA9IGxzMTAyMWFfcGNpZV9ob3N0X2luaXQsCj4gKwkucG1lX3R1cm5fb2Zm ID0gbHMxMDIxYV9wY2llX3NlbmRfdHVybm9mZl9tc2csCj4gK307Cj4gKwo+ICBzdGF0aWMgY29u c3Qgc3RydWN0IGxzX3BjaWVfZHJ2ZGF0YSBsczEwMjFhX2RydmRhdGEgPSB7Cj4gLQkucG1fc3Vw cG9ydCA9IGZhbHNlLAo+ICsJLnBtX3N1cHBvcnQgPSB0cnVlLAo+ICsJLm9wcyA9ICZsczEwMjFh X3BjaWVfaG9zdF9vcHMsCj4gKwkuZXhpdF9mcm9tX2wyID0gbHMxMDIxYV9wY2llX2V4aXRfZnJv bV9sMiwKPiAgfTsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbHNfcGNpZV9kcnZkYXRhIGxh eWVyc2NhcGVfZHJ2ZGF0YSA9IHsKPiAtLSAKPiAyLjM0LjEKPiAKCi0tIArgrq7grqPgrr/grrXg rqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==