* [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static
@ 2023-10-16 20:04 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-10-16 20:04 UTC (permalink / raw)
To: Helge Deller
Cc: Arnd Bergmann, Thomas Zimmermann, Linus Walleij, Lee Jones,
linux-fbdev, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This is a global function that is only referenced as an initcall. This causes
a warning:
drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes]
Make it static instead.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/sa1100fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
index 63e12a7c1100e..e14eb634cb944 100644
--- a/drivers/video/fbdev/sa1100fb.c
+++ b/drivers/video/fbdev/sa1100fb.c
@@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = {
},
};
-int __init sa1100fb_init(void)
+static int __init sa1100fb_init(void)
{
if (fb_get_options("sa1100fb", NULL))
return -ENODEV;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static
@ 2023-10-16 20:04 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-10-16 20:04 UTC (permalink / raw)
To: Helge Deller
Cc: linux-fbdev, Arnd Bergmann, Lee Jones, linux-kernel, dri-devel,
Thomas Zimmermann
From: Arnd Bergmann <arnd@arndb.de>
This is a global function that is only referenced as an initcall. This causes
a warning:
drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes]
Make it static instead.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/sa1100fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
index 63e12a7c1100e..e14eb634cb944 100644
--- a/drivers/video/fbdev/sa1100fb.c
+++ b/drivers/video/fbdev/sa1100fb.c
@@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = {
},
};
-int __init sa1100fb_init(void)
+static int __init sa1100fb_init(void)
{
if (fb_get_options("sa1100fb", NULL))
return -ENODEV;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static
2023-10-16 20:04 ` Arnd Bergmann
@ 2023-10-16 21:06 ` Helge Deller
-1 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2023-10-16 21:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Arnd Bergmann, Thomas Zimmermann, Linus Walleij, Lee Jones,
linux-fbdev, dri-devel, linux-kernel
On 10/16/23 22:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is a global function that is only referenced as an initcall. This causes
> a warning:
>
> drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes]
>
> Make it static instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/sa1100fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
> index 63e12a7c1100e..e14eb634cb944 100644
> --- a/drivers/video/fbdev/sa1100fb.c
> +++ b/drivers/video/fbdev/sa1100fb.c
> @@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = {
> },
> };
>
> -int __init sa1100fb_init(void)
> +static int __init sa1100fb_init(void)
> {
> if (fb_get_options("sa1100fb", NULL))
> return -ENODEV;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static
@ 2023-10-16 21:06 ` Helge Deller
0 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2023-10-16 21:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-fbdev, Arnd Bergmann, Lee Jones, linux-kernel, dri-devel,
Thomas Zimmermann
On 10/16/23 22:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is a global function that is only referenced as an initcall. This causes
> a warning:
>
> drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes]
>
> Make it static instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/sa1100fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
> index 63e12a7c1100e..e14eb634cb944 100644
> --- a/drivers/video/fbdev/sa1100fb.c
> +++ b/drivers/video/fbdev/sa1100fb.c
> @@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = {
> },
> };
>
> -int __init sa1100fb_init(void)
> +static int __init sa1100fb_init(void)
> {
> if (fb_get_options("sa1100fb", NULL))
> return -ENODEV;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-16 21:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 20:04 [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static Arnd Bergmann
2023-10-16 20:04 ` Arnd Bergmann
2023-10-16 21:06 ` Helge Deller
2023-10-16 21:06 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.