From: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: rts5208: Replace the occurrences of (1<<x) by BIT(x)
Date: Mon, 16 Oct 2023 13:11:54 -0700 [thread overview]
Message-ID: <20231016201154.GA14625@ubuntu> (raw)
Adhere to linux coding style. Reported by checkpatch.pl:
CHECK: Prefer using the BIT macro
Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
---
drivers/staging/rts5208/rtsx_card.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_card.h b/drivers/staging/rts5208/rtsx_card.h
index 39727371cd7a..9d2504fddb13 100644
--- a/drivers/staging/rts5208/rtsx_card.h
+++ b/drivers/staging/rts5208/rtsx_card.h
@@ -338,7 +338,7 @@
#define DMA_DIR_FROM_CARD 0x02
#define DMA_EN 0x01
#define DMA_128 (0 << 4)
-#define DMA_256 (1 << 4)
+#define DMA_256 BIT(4)
#define DMA_512 (2 << 4)
#define DMA_1024 (3 << 4)
#define DMA_PACK_SIZE_MASK 0x30
@@ -542,7 +542,7 @@
#define BLINK_EN 0x08
#define LED_GPIO0 (0 << 4)
-#define LED_GPIO1 (1 << 4)
+#define LED_GPIO1 BIT(4)
#define LED_GPIO2 (2 << 4)
#define SDIO_BUS_CTRL 0x01
--
2.25.1
next reply other threads:[~2023-10-16 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 20:11 Nandha Kumar Singaram [this message]
2023-10-17 4:02 ` [PATCH] staging: rts5208: Replace the occurrences of (1<<x) by BIT(x) Dan Carpenter
2023-10-17 4:06 ` Dan Carpenter
2023-10-17 14:02 ` Nandha Kumar Singaram
2023-10-17 14:14 ` Nandha Kumar Singaram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016201154.GA14625@ubuntu \
--to=nandhakumar.singaram@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.