From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1784DCDB465 for ; Mon, 16 Oct 2023 23:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B5FB8D00D8; Mon, 16 Oct 2023 19:32:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 363298D00B8; Mon, 16 Oct 2023 19:32:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6B28D00D8; Mon, 16 Oct 2023 19:32:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 045318D00B8 for ; Mon, 16 Oct 2023 19:32:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D847E80CAD for ; Mon, 16 Oct 2023 23:32:42 +0000 (UTC) X-FDA: 81352926564.27.99F16AC Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf30.hostedemail.com (Postfix) with ESMTP id 3755A80008 for ; Mon, 16 Oct 2023 23:32:41 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=VOuXSLBD; spf=pass (imf30.hostedemail.com: domain of madvenka@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=madvenka@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697499161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v+MGl8VNxHhEu7SiDqqi9YdWqsYhSKIOB6h48Erpxmk=; b=KxE6+6EIaVEDWF/6ZYLVfH2hPLXSZ/kX7wTe8yxjmopD0uyOZBrk0USsRjcn0MJtq1O+E6 OH8U52TYiCXCYO1MozdvRmVzcvVvFrZJsk3tYKGwo3XhlxWzesgc2hVsWeeRAPiK6Pc2jE ps69JVsQsQ53laglFBG865U+2f1lvcQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=VOuXSLBD; spf=pass (imf30.hostedemail.com: domain of madvenka@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=madvenka@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697499161; a=rsa-sha256; cv=none; b=UUdWarv1kZZle9eBexw01uCi6LNHssRSW1q6U7YCmyszWPf5V/WU8q17BWW0trbcYe88cU m0xoS0/GcSHUYndVY4Tf0u2kdKeLi8Wyc75NBh+1GG4fqGrmdk0rlE2BlQHgKmFKcZtZLn d8faj40FgCw0iaD3G80Cy/E9mdM/tsA= Received: from localhost.localdomain (unknown [47.186.13.91]) by linux.microsoft.com (Postfix) with ESMTPSA id 2208E20B74C0; Mon, 16 Oct 2023 16:32:40 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2208E20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1697499160; bh=v+MGl8VNxHhEu7SiDqqi9YdWqsYhSKIOB6h48Erpxmk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=VOuXSLBDU9ez2Q4QlOyswMODjVcj8ALhspoyjwkyBIl/9lMFj2JkYJM0OvKd0rIL9 ktPzuHKgOrdTXz13SBV5UJF3JkaZZmm74iIFnpllif0gVmKRyybv6yEkWg/QKr4yJT t2IM2syhiHvyKaci7F5uDHic+s791o2RObM6XnP4= From: madvenka@linux.microsoft.com To: gregkh@linuxfoundation.org, pbonzini@redhat.com, rppt@kernel.org, jgowans@amazon.com, graf@amazon.de, arnd@arndb.de, keescook@chromium.org, stanislav.kinsburskii@gmail.com, anthony.yznaga@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, madvenka@linux.microsoft.com, jamorris@linux.microsoft.com Subject: [RFC PATCH v1 09/10] mm/prmem: Implement DAX support for Persistent Ramdisks. Date: Mon, 16 Oct 2023 18:32:14 -0500 Message-Id: <20231016233215.13090-10-madvenka@linux.microsoft.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231016233215.13090-1-madvenka@linux.microsoft.com> References: <1b1bc25eb87355b91fcde1de7c2f93f38abb2bf9> <20231016233215.13090-1-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3755A80008 X-Rspam-User: X-Stat-Signature: pcrq89t7h99g57zzggxaabyb1355nogi X-Rspamd-Server: rspam01 X-HE-Tag: 1697499161-415106 X-HE-Meta: U2FsdGVkX1+WVqSjK5N8Wz84Nzjb6X3mgWbOJ0b6gFvepkcmAc4pVR7RIurEI7vvn9PJDrgWIIbzDh3dBJbTOBBADwRqXwpM4zGouOTqHKMXACOYo+qK7Ucp9931h2VtCzucF9S3X0f+c8jIAsq53wQyXZ2foEgIKiaM+ZTZ7df0uDHaV0ipGlcvtgjO4gvMYqTy/dSejgx6vlBPu1+F/2ZgmW3p3rrytzAiv4NA5c6Q+AATOD/XAPRpAq0BkuOOmgciyoP7SgJvJjOeAzyJRoWRrLtpdsgKEhhDrgLpFWKaXZerV+ZzB+HWCsYXMAHGqZ+Te8oofgbqXfHzxzV/V6FOVGRcWjtBgnas1GvIwG8pjxFxNpf4BIrAFyhxrzLZaCa122xAaoknCnRD13dzo0koUKnlE06b09SVTDINJ+3YEsUxqFl7PA1WIeRkaokWvTGxfwiAN7k1uJn5Z37ttW3IPbAUos8HljMBxyuBkA9oNNOkjUqgQBvtbziJ0V2hhjjvCKa9MdKMJU8Tvag9zWmJmZVvUef6TnQd/79xvm7by/WZogXZ2vuIDFzwX7aDWHth/36EyqPNsI7widg47TN95TfZt2qRnhGrgRJPq1b0l5V6O4MmHlC6rQNWt4I6iNNhOLHt9+RA3ykaiP08W9AIevEqXtP+LY3oM/7ylu5qfwMXUcR9kWohdEc8jRqyd+C7GkWKID0rwG07g9OtetY4X9gv95Zfgg9CfAIb8r5bBX+Ymw/e9c+b9jXHPDhhdDMBqJ7rsvezwhYoL74MLjtGK/quVBxLTizuGrbbPf66DlRc5U2oeTccY+2oL9FqCH3rPBzLmYkX2t6s8O9R4dPPP0+KTZ93Jt8ChI0JrKHvXShw8eExqzSmmK55mlWpTRcc2LzyLCz67TbhkxpNeWeEwWZig6tA/jcXGil/gxmXWmt8ZEaz+29snSCJwhS72shyCWOD+4iXNUe5oWF 7exN/jxr QFrTYuz2M/nID+hlzcEpjqOecag7/rlVUkolSv3ODefMzdjccZ4BtKsA3UwBiRtb88bED1Nky3j3QvbGsiq3fselvwbjbDNHn5E5psai206xdNJpYj6ZYJjK1XnqlxT7jHH4yhgccjW/wr1qMQa4p2jHKMAeEfm8Qe9t0exX9NmN59YLjGwHHqnfkOzw6CV3AKVpU5+C52Q4IdU6lv7HbTDx24I+4Nrjd2KJ/E+yc6J+TIzrtbFp6FvcwOMH4Pyza7V53lbHtbnddITrqsIVNOfB0k8o20/eUBZL0kxC/sHvLaons/w6e6F0wwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Madhavan T. Venkataraman" One problem with using a ramdisk is that the page cache will contain redundant copies of ramdisk data. To avoid this, implement DAX support for persistent ramdisks. To avail this, the filesystem that is installed on the ramdisk must support DAX. Like ext4. Mount the filesystem with the dax option. E.g., sudo mount -t ext4 -o dax /dev/pram0 /path/to/mountpoint Signed-off-by: Madhavan T. Venkataraman --- drivers/block/brd.c | 106 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 3a05e56ca16f..d4a42d3bd212 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -25,6 +25,9 @@ #include #include #include +#include +#include +#include #include @@ -42,6 +45,7 @@ struct brd_device { enum brd_type brd_type; struct gendisk *brd_disk; struct list_head brd_list; + struct dax_device *brd_dax; /* * Backing store of pages. This is the contents of the block device. @@ -58,6 +62,8 @@ static void brd_free_page(struct brd_device *brd, struct page *page); static void brd_xa_init(struct brd_device *brd); static void brd_init_name(struct brd_device *brd, char *name); static void brd_set_capacity(struct brd_device *brd); +static int brd_dax_init(struct brd_device *brd); +static void brd_dax_cleanup(struct brd_device *brd); /* * Look up and return a brd's page for a given sector. @@ -408,6 +414,9 @@ static int brd_alloc(int i) strscpy(disk->disk_name, buf, DISK_NAME_LEN); brd_set_capacity(brd); + if (brd_dax_init(brd)) + goto out_clean_dax; + /* * This is so fdisk will align partitions on 4k, because of * direct_access API needing 4k alignment, returning a PFN @@ -421,6 +430,8 @@ static int brd_alloc(int i) blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue); blk_queue_flag_set(QUEUE_FLAG_SYNCHRONOUS, disk->queue); blk_queue_flag_set(QUEUE_FLAG_NOWAIT, disk->queue); + if (brd->brd_dax) + blk_queue_flag_set(QUEUE_FLAG_DAX, disk->queue); err = add_disk(disk); if (err) goto out_cleanup_disk; @@ -429,6 +440,8 @@ static int brd_alloc(int i) out_cleanup_disk: put_disk(disk); +out_clean_dax: + brd_dax_cleanup(brd); out_free_dev: list_del(&brd->brd_list); brd_free_device(brd); @@ -447,6 +460,7 @@ static void brd_cleanup(void) debugfs_remove_recursive(brd_debugfs_dir); list_for_each_entry_safe(brd, next, &brd_devices, brd_list) { + brd_dax_cleanup(brd); del_gendisk(brd->brd_disk); put_disk(brd->brd_disk); brd_free_pages(brd); @@ -659,3 +673,95 @@ static void brd_set_capacity(struct brd_device *brd) disksize = prd_data[brd->brd_number].size; set_capacity(brd->brd_disk, disksize * 2); } + +static bool prd_dax_enabled = IS_ENABLED(CONFIG_FS_DAX); + +static long brd_dax_direct_access(struct dax_device *dax_dev, + pgoff_t pgoff, long nr_pages, + enum dax_access_mode mode, + void **kaddr, pfn_t *pfn); +static int brd_dax_zero_page_range(struct dax_device *dax_dev, + pgoff_t pgoff, size_t nr_pages); + +static const struct dax_operations brd_dax_ops = { + .direct_access = brd_dax_direct_access, + .zero_page_range = brd_dax_zero_page_range, +}; + +static int brd_dax_init(struct brd_device *brd) +{ + if (!prd_dax_enabled || brd->brd_type == BRD_NORMAL) + return 0; + + brd->brd_dax = alloc_dax(brd, &brd_dax_ops); + if (IS_ERR(brd->brd_dax)) { + pr_warn("%s: DAX failed\n", __func__); + brd->brd_dax = NULL; + return -ENOMEM; + } + + if (dax_add_host(brd->brd_dax, brd->brd_disk)) { + pr_warn("%s: DAX add failed\n", __func__); + return -ENOMEM; + } + return 0; +} + +static void brd_dax_cleanup(struct brd_device *brd) +{ + if (!prd_dax_enabled || brd->brd_type == BRD_NORMAL) + return; + + if (brd->brd_dax) { + dax_remove_host(brd->brd_disk); + kill_dax(brd->brd_dax); + put_dax(brd->brd_dax); + } +} +static int brd_dax_zero_page_range(struct dax_device *dax_dev, + pgoff_t pgoff, size_t nr_pages) +{ + long rc; + void *kaddr; + + rc = dax_direct_access(dax_dev, pgoff, nr_pages, DAX_ACCESS, + &kaddr, NULL); + if (rc < 0) + return rc; + memset(kaddr, 0, nr_pages << PAGE_SHIFT); + return 0; +} + +static long __brd_direct_access(struct brd_device *brd, pgoff_t pgoff, + long nr_pages, void **kaddr, pfn_t *pfn) +{ + struct page *page; + sector_t sector = (sector_t) pgoff << PAGE_SECTORS_SHIFT; + int ret; + + if (!brd) + return -ENODEV; + + ret = brd_insert_page(brd, sector, GFP_NOWAIT); + if (ret) + return ret; + + page = brd_lookup_page(brd, sector); + if (!page) + return -ENOSPC; + + *kaddr = page_address(page); + if (pfn) + *pfn = page_to_pfn_t(page); + + return 1; +} + +static long brd_dax_direct_access(struct dax_device *dax_dev, + pgoff_t pgoff, long nr_pages, enum dax_access_mode mode, + void **kaddr, pfn_t *pfn) +{ + struct brd_device *brd = dax_get_private(dax_dev); + + return __brd_direct_access(brd, pgoff, nr_pages, kaddr, pfn); +} -- 2.25.1