From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: add missing _require_scratch calls
Date: Tue, 17 Oct 2023 06:25:07 +0200 [thread overview]
Message-ID: <20231017042507.GA6346@lst.de> (raw)
In-Reply-To: <20231016184124.GB11391@frogsfrogsfrogs>
On Mon, Oct 16, 2023 at 11:41:24AM -0700, Darrick J. Wong wrote:
> > +_require_scratch
> > _require_scratch_delalloc
> > _require_scratch_reflink
>
> Oops. That _require_scratch_delalloc could've gone beneath the
> _require_scratch_reflink to take advantage of the _require_scratch call
> in _require_scratch_reflink.
>
> That said ... maybe _require_scratch_* calls should require the caller
> to have _require_scratch'd beforehand? And perhaps all
> _require_scratch_* functions should complain if
> ${RESULT_DIR}/require_scratch doesn't already exist.
Either having a _require_scratch in all _require_scratch_* helpers or
none sounds sensible to me, having it in some and nother others is
rather confusing. Any preferences?
next prev parent reply other threads:[~2023-10-17 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:11 [PATCH 1/2] xfs/556: call _require_dm_target later Christoph Hellwig
2023-10-16 13:11 ` [PATCH 2/2] xfs: add missing _require_scratch calls Christoph Hellwig
2023-10-16 18:41 ` Darrick J. Wong
2023-10-17 4:25 ` Christoph Hellwig [this message]
2023-10-17 5:37 ` Darrick J. Wong
2023-10-16 18:37 ` [PATCH 1/2] xfs/556: call _require_dm_target later Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017042507.GA6346@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.