From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] pmcraid: add missing scsi_device_put() in pmcraid_eh_target_reset_handler()
Date: Tue, 17 Oct 2023 09:31:14 +0200 [thread overview]
Message-ID: <20231017073113.GA12422@lst.de> (raw)
In-Reply-To: <20231017072145.120795-1-hare@suse.de>
On Tue, Oct 17, 2023 at 09:21:45AM +0200, Hannes Reinecke wrote:
> (Re-sending as a separate patch:)
> When breaking out of a shost_for_each_device() loop one need to do
> an explicit scsi_device_put(). And while at it convert to use
> shost_priv() instead of a direct reference to ->hostdata.
This is still doing two entirely different things. Please send just
the trivial scsi_device_put patch as a fix, and the cleanup on top.
next prev parent reply other threads:[~2023-10-17 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 7:21 [PATCH] pmcraid: add missing scsi_device_put() in pmcraid_eh_target_reset_handler() Hannes Reinecke
2023-10-17 7:31 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-23 7:29 Hannes Reinecke
2023-10-24 6:24 ` Christoph Hellwig
2023-10-25 2:24 ` Martin K. Petersen
2023-10-30 15:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017073113.GA12422@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.