From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, anjali.singhai@intel.com,
namrata.limaye@intel.com, deb.chatterjee@intel.com,
john.andy.fingerhut@intel.com, dan.daly@intel.com,
Vipin.Jain@amd.com, tom@sipanda.io, mleitner@redhat.com,
Mahesh.Shirshyad@amd.com, tomasz.osinski@intel.com,
jiri@resnulli.us, xiyou.wangcong@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, vladbu@nvidia.com,
horms@kernel.org, khalidm@nvidia.com, toke@redhat.com,
mattyk@nvidia.com
Subject: Re: [PATCH v7 net-next 00/18] Introducing P4TC
Date: Tue, 17 Oct 2023 08:58:17 -0700 [thread overview]
Message-ID: <20231017085817.71d4f83b@kernel.org> (raw)
In-Reply-To: <CAM0EoM=f9qGmTR5jW1vayu0JHy0MQjrOeREX6acjnS7MFQP7Ww@mail.gmail.com>
On Tue, 17 Oct 2023 11:56:15 -0400 Jamal Hadi Salim wrote:
> > Um. Maybe.. Sparse generates more false positives than good warnings
> > lately :( We'd have to add some extra info like "Note that sparse
> > is known to generate false-positive warnings, if you think that the
> > warning generated with C=1 is bogus, ignore it and note that fact
> > in the commit message".
> >
>
> > I don't like documenting things which aren't clear-cut :(
>
> Upto you - couldnt sum up from above if you want a patch or not. I
> think it makes sense to document C=1 somewhere since it helps your
> overhead.
> But the comment Similar in spirit to the checkpatch comment if - "But
> do not be mindlessly robotic in doing so..."
Weak preference for keeping it as is.
The wins on my end don't justify the extra rule for the drive-by
developers.
next prev parent reply other threads:[~2023-10-17 15:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 9:35 [PATCH v7 net-next 00/18] Introducing P4TC Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 01/18] net: sched: act_api: Introduce dynamic actions list Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 02/18] net/sched: act_api: increase action kind string length Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 03/18] net/sched: act_api: Update tc_action_ops to account for dynamic actions Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 04/18] net/sched: act_api: add struct p4tc_action_ops as a parameter to lookup callback Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 05/18] net: sched: act_api: Add support for preallocated dynamic action instances Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 06/18] net: introduce rcu_replace_pointer_rtnl Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 07/18] rtnl: add helper to check if group has listeners Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 08/18] p4tc: add P4 data types Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 09/18] p4tc: add template pipeline create, get, update, delete Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 10/18] p4tc: add template header field create, get, delete, flush and dump Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 11/18] p4tc: add action template create, update, delete, get, " Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 12/18] p4tc: add template table " Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 13/18] p4tc: add runtime table entry create, update, get, delete, " Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 14/18] p4tc: add set of P4TC table kfuncs Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 15/18] p4tc: add P4 classifier Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 16/18] p4tc: Add P4 extern interface Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 17/18] p4tc: Add global counter extern Jamal Hadi Salim
2023-10-16 9:35 ` [PATCH v7 net-next 18/18] MAINTAINERS: add p4tc entry Jamal Hadi Salim
2023-10-16 20:15 ` [PATCH v7 net-next 00/18] Introducing P4TC Jakub Kicinski
2023-10-16 20:38 ` Jamal Hadi Salim
2023-10-16 20:59 ` Jamal Hadi Salim
2023-10-16 21:44 ` Jamal Hadi Salim
2023-10-16 22:35 ` Jakub Kicinski
2023-10-17 15:27 ` Jamal Hadi Salim
2023-10-17 15:40 ` Jakub Kicinski
2023-10-17 15:56 ` Jamal Hadi Salim
2023-10-17 15:58 ` Jakub Kicinski [this message]
2023-10-17 15:00 ` Daniel Borkmann
2023-10-17 15:38 ` Jamal Hadi Salim
2023-10-17 15:54 ` Daniel Borkmann
2023-10-17 15:57 ` Jamal Hadi Salim
2023-10-17 16:06 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017085817.71d4f83b@kernel.org \
--to=kuba@kernel.org \
--cc=Mahesh.Shirshyad@amd.com \
--cc=Vipin.Jain@amd.com \
--cc=anjali.singhai@intel.com \
--cc=dan.daly@intel.com \
--cc=davem@davemloft.net \
--cc=deb.chatterjee@intel.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.andy.fingerhut@intel.com \
--cc=khalidm@nvidia.com \
--cc=mattyk@nvidia.com \
--cc=mleitner@redhat.com \
--cc=namrata.limaye@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
--cc=tom@sipanda.io \
--cc=tomasz.osinski@intel.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.