From: Simon Horman <horms@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@gmail.com>,
linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section
Date: Tue, 17 Oct 2023 11:59:47 +0200 [thread overview]
Message-ID: <20231017095947.GX1751252@kernel.org> (raw)
In-Reply-To: <60cb0b0c6266881e225160f80a83884607617921.1697460418.git.geert+renesas@glider.be>
On Mon, Oct 16, 2023 at 02:49:04PM +0200, Geert Uytterhoeven wrote:
> When CONFIG_IPV6=n, and building with W=1:
>
> In file included from include/trace/define_trace.h:102,
> from include/trace/events/neigh.h:255,
> from net/core/net-traces.c:51:
> include/trace/events/neigh.h: In function ‘trace_event_raw_event_neigh_create’:
> include/trace/events/neigh.h:42:34: error: variable ‘pin6’ set but not used [-Werror=unused-but-set-variable]
> 42 | struct in6_addr *pin6;
> | ^~~~
> include/trace/trace_events.h:402:11: note: in definition of macro ‘DECLARE_EVENT_CLASS’
> 402 | { assign; } \
> | ^~~~~~
> include/trace/trace_events.h:44:30: note: in expansion of macro ‘PARAMS’
> 44 | PARAMS(assign), \
> | ^~~~~~
> include/trace/events/neigh.h:23:1: note: in expansion of macro ‘TRACE_EVENT’
> 23 | TRACE_EVENT(neigh_create,
> | ^~~~~~~~~~~
> include/trace/events/neigh.h:41:9: note: in expansion of macro ‘TP_fast_assign’
> 41 | TP_fast_assign(
> | ^~~~~~~~~~~~~~
> In file included from include/trace/define_trace.h:103,
> from include/trace/events/neigh.h:255,
> from net/core/net-traces.c:51:
> include/trace/events/neigh.h: In function ‘perf_trace_neigh_create’:
> include/trace/events/neigh.h:42:34: error: variable ‘pin6’ set but not used [-Werror=unused-but-set-variable]
> 42 | struct in6_addr *pin6;
> | ^~~~
> include/trace/perf.h:51:11: note: in definition of macro ‘DECLARE_EVENT_CLASS’
> 51 | { assign; } \
> | ^~~~~~
> include/trace/trace_events.h:44:30: note: in expansion of macro ‘PARAMS’
> 44 | PARAMS(assign), \
> | ^~~~~~
> include/trace/events/neigh.h:23:1: note: in expansion of macro ‘TRACE_EVENT’
> 23 | TRACE_EVENT(neigh_create,
> | ^~~~~~~~~~~
> include/trace/events/neigh.h:41:9: note: in expansion of macro ‘TP_fast_assign’
> 41 | TP_fast_assign(
> | ^~~~~~~~~~~~~~
>
> Indeed, the variable pin6 is declared and initialized unconditionally,
> while it is only used and needlessly re-initialized when support for
> IPv6 is enabled.
>
> Fix this by dropping the unused variable initialization, and moving the
> variable declaration inside the existing section protected by a check
> for CONFIG_IPV6.
>
> Fixes: fc651001d2c5ca4f ("neighbor: Add tracepoint to __neigh_create")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
next prev parent reply other threads:[~2023-10-17 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 12:49 [PATCH] neighbor: tracing: Move pin6 inside CONFIG_IPV6=y section Geert Uytterhoeven
2023-10-17 9:59 ` Simon Horman [this message]
2023-10-17 14:54 ` David Ahern
2023-10-18 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017095947.GX1751252@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.