All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v3 38/73] pinctrl: remove pinctrl_gpio_free()
Date: Tue, 17 Oct 2023 14:03:56 +0200	[thread overview]
Message-ID: <20231017120431.68847-39-brgl@bgdev.pl> (raw)
In-Reply-To: <20231017120431.68847-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

There are no more users of pinctrl_gpio_free() so remove it.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/pinctrl/core.c           | 41 +++++++++++++-------------------
 include/linux/pinctrl/consumer.h |  5 ----
 2 files changed, 17 insertions(+), 29 deletions(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 46e5fe90718b..5a1414bfeacc 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -819,29 +819,6 @@ int pinctrl_gpio_request_new(struct gpio_chip *gc, unsigned int offset)
 }
 EXPORT_SYMBOL_GPL(pinctrl_gpio_request_new);
 
-/* This function is deprecated and will be removed. Don't use. */
-void pinctrl_gpio_free(unsigned gpio)
-{
-	struct pinctrl_dev *pctldev;
-	struct pinctrl_gpio_range *range;
-	int ret;
-	int pin;
-
-	ret = pinctrl_get_device_gpio_range(gpio, &pctldev, &range);
-	if (ret) {
-		return;
-	}
-	mutex_lock(&pctldev->mutex);
-
-	/* Convert to the pin controllers number space */
-	pin = gpio_to_pin(range, gpio);
-
-	pinmux_free_gpio(pctldev, pin, range);
-
-	mutex_unlock(&pctldev->mutex);
-}
-EXPORT_SYMBOL_GPL(pinctrl_gpio_free);
-
 /**
  * pinctrl_gpio_free_new() - free control on a single pin, currently used as GPIO
  * @gc: GPIO chip structure from the GPIO subsystem
@@ -853,7 +830,23 @@ EXPORT_SYMBOL_GPL(pinctrl_gpio_free);
  */
 void pinctrl_gpio_free_new(struct gpio_chip *gc, unsigned int offset)
 {
-	return pinctrl_gpio_free(gc->base + offset);
+	struct pinctrl_gpio_range *range;
+	struct pinctrl_dev *pctldev;
+	int ret, pin;
+
+	ret = pinctrl_get_device_gpio_range(gc->base + offset, &pctldev,
+					    &range);
+	if (ret)
+		return;
+
+	mutex_lock(&pctldev->mutex);
+
+	/* Convert to the pin controllers number space */
+	pin = gpio_to_pin(range, gc->base + offset);
+
+	pinmux_free_gpio(pctldev, pin, range);
+
+	mutex_unlock(&pctldev->mutex);
 }
 EXPORT_SYMBOL_GPL(pinctrl_gpio_free_new);
 
diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h
index 83a414a347cf..90b2f0b78c4b 100644
--- a/include/linux/pinctrl/consumer.h
+++ b/include/linux/pinctrl/consumer.h
@@ -28,7 +28,6 @@ struct pinctrl_state;
 /* External interface to pin control */
 bool pinctrl_gpio_can_use_line_new(struct gpio_chip *gc, unsigned int offset);
 int pinctrl_gpio_request_new(struct gpio_chip *gc, unsigned int offset);
-void pinctrl_gpio_free(unsigned gpio);
 void pinctrl_gpio_free_new(struct gpio_chip *gc, unsigned int offset);
 int pinctrl_gpio_direction_input(unsigned gpio);
 int pinctrl_gpio_direction_input_new(struct gpio_chip *gc,
@@ -83,10 +82,6 @@ pinctrl_gpio_request_new(struct gpio_chip *gc, unsigned int offset)
 	return 0;
 }
 
-static inline void pinctrl_gpio_free(unsigned gpio)
-{
-}
-
 static inline void
 pinctrl_gpio_free_new(struct gpio_chip *gc, unsigned int offset)
 {
-- 
2.39.2


  parent reply	other threads:[~2023-10-17 12:20 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 12:03 [PATCH v3 00/73] pinctrl: don't use GPIOLIB global numberspace in helpers Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 01/73] pinctrl: remove unneeded extern specifiers from consumer.h Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 02/73] pinctrl: provide new GPIO-to-pinctrl glue helpers Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 03/73] gpiolib: generic: use new pinctrl GPIO helpers Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 04/73] gpio: cdev: use pinctrl_gpio_can_use_line_new() Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 05/73] gpio: rcar: use new pinctrl GPIO helpers Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 06/73] gpio: tegra: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 07/73] gpio: em: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 08/73] gpio: aspeed: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 09/73] gpio: mvebu: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 10/73] gpio: pxa: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 11/73] gpio: rockchip: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 12/73] gpio: vf610: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 13/73] pinctrl: nuvoton: npcm7xx: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 14/73] pinctrl: nuvoton: npcm8xx: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 15/73] pinctrl: renesas: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 16/73] pinctrl: bcm: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 17/73] pinctrl: stm32: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 18/73] pinctrl: spear: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 19/73] pinctrl: starfive: jh7100: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 20/73] pinctrl: starfive: jh7110: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 21/73] pinctrl: ocelot: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 22/73] pinctrl: rk805: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 23/73] pinctrl: cirrus: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 24/73] pinctrl: mediatek: moore: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 25/73] pinctrl: mediatek: common: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 26/73] pinctrl: mediatek: paris: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 27/73] pinctrl: axp209: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 28/73] pinctrl: vt8500: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 29/73] pinctrl: cy8c95x0: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 30/73] pinctrl: as3722: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 31/73] pinctrl: ingenic: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 32/73] pinctrl: intel: cherryview: " Bartosz Golaszewski
2023-10-17 12:26   ` Andy Shevchenko
2023-10-17 12:03 ` [PATCH v3 33/73] pinctrl: intel: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 34/73] pinctrl: intel: lynxpoint: " Bartosz Golaszewski
2023-10-17 12:26   ` Andy Shevchenko
2023-10-17 12:03 ` [PATCH v3 35/73] pinctrl: st: " Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 36/73] pinctrl: remove pinctrl_gpio_can_use_line() Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 37/73] pinctrl: remove pinctrl_gpio_request() Bartosz Golaszewski
2023-10-17 12:03 ` Bartosz Golaszewski [this message]
2023-10-17 12:03 ` [PATCH v3 39/73] pinctrl: remove pinctrl_gpio_direction_input() Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 40/73] pinctrl: remove pinctrl_gpio_direction_output() Bartosz Golaszewski
2023-10-17 12:03 ` [PATCH v3 41/73] pinctrl: remove pinctrl_gpio_set_config() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 42/73] treewide: rename pinctrl_gpio_can_use_line_new() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 43/73] treewide: rename pinctrl_gpio_request_new() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 44/73] treewide: rename pinctrl_gpio_free_new() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 45/73] treewide: rename pinctrl_gpio_direction_input_new() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 46/73] treewide: rename pinctrl_gpio_direction_output_new() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 47/73] treewide: rename pinctrl_gpio_set_config_new() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 48/73] pinctrl: change the signature of pinctrl_gpio_direction() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 49/73] pinctrl: change the signature of pinctrl_get_device_gpio_range() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 50/73] pinctrl: change the signature of pinctrl_match_gpio_range() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 51/73] pinctrl: change the signature of gpio_to_pin() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 52/73] pinctrl: change the signature of pinctrl_ready_for_gpio_range() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 53/73] pinctrl: intel: lynxpoint: drop the wrappers around pinctrl_gpio_direction_input() Bartosz Golaszewski
2023-10-17 12:28   ` Andy Shevchenko
2023-10-17 12:33     ` Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 54/73] pinctrl: intel: " Bartosz Golaszewski
2023-10-17 12:41   ` Andy Shevchenko
2023-10-17 12:44     ` Bartosz Golaszewski
2023-10-17 12:46       ` Andy Shevchenko
2023-10-17 12:55         ` Bartosz Golaszewski
2023-10-17 13:16           ` Andy Shevchenko
2023-10-17 14:51             ` Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 55/73] pinctrl: intel: cherryview: " Bartosz Golaszewski
2023-10-17 12:31   ` Andy Shevchenko
2023-10-17 12:04 ` [PATCH v3 56/73] pinctrl: st: drop the wrapper " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 57/73] pinctrl: ingenic: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 58/73] pinctrl: as3722: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 59/73] pinctrl: cy8c95x0: " Bartosz Golaszewski
2023-10-17 12:45   ` Andy Shevchenko
2023-10-17 12:04 ` [PATCH v3 60/73] pinctrl: vt8500: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 61/73] pinctrl: axp209: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 62/73] pinctrl: rk805: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 63/73] pinctrl: mediatek: moore: drop the wrappers " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 64/73] pinctrl: mediatek: common: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 65/73] pinctrl: cirrus: drop the wrapper " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 66/73] pinctrl: ocelot: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 67/73] pinctrl: starfive: jh7100: drop wrappers around pinctrl_gpio_request/free() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 68/73] pinctrl: starfive: jh7110: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 69/73] pinctrl: stm32: drop wrappers around pinctrl_gpio_free/input() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 70/73] pinctrl: nuvoton: npcm7xx: drop wrappers around pinctrl_gpio_request/free() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 71/73] pinctrl: nuvoton: npcm8xx: " Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 72/73] pinctrl: em: drop the wrapper around pinctrl_gpio_request() Bartosz Golaszewski
2023-10-17 12:04 ` [PATCH v3 73/73] pinctrl: tegra: " Bartosz Golaszewski
2023-10-23  8:14 ` [PATCH v3 00/73] pinctrl: don't use GPIOLIB global numberspace in helpers Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231017120431.68847-39-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.