From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com,
tomi.valkeinen@ideasonboard.com, jacopo.mondi@ideasonboard.com,
bingbu.cao@intel.com, hongju.wang@intel.com
Subject: Re: [PATCH 3/6] media: v4l: subdev: Rename sub-device state information access functions
Date: Tue, 17 Oct 2023 16:22:07 +0800 [thread overview]
Message-ID: <202310171645.8Tac7Ez4-lkp@intel.com> (raw)
In-Reply-To: <20231013104424.404768-4-sakari.ailus@linux.intel.com>
Hi Sakari,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20231016]
[also build test WARNING on linus/master v6.6-rc6]
[cannot apply to media-tree/master rockchip/for-next sailus-media-tree/streams v6.6-rc6 v6.6-rc5 v6.6-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-subdev-Also-return-pads-array-information-on-stream-functions/20231017-120800
base: next-20231016
patch link: https://lore.kernel.org/r/20231013104424.404768-4-sakari.ailus%40linux.intel.com
patch subject: [PATCH 3/6] media: v4l: subdev: Rename sub-device state information access functions
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171645.8Tac7Ez4-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171645.8Tac7Ez4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310171645.8Tac7Ez4-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c: In function 'mxc_isi_crossbar_gasket_enable':
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:61:15: error: implicit declaration of function 'v4l2_subdev_state_get_stream_format'; did you mean 'v4l2_subdev_state_get_opposite_stream_format'? [-Werror=implicit-function-declaration]
61 | fmt = v4l2_subdev_state_get_stream_format(state, port, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| v4l2_subdev_state_get_opposite_stream_format
>> drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:61:13: warning: assignment to 'const struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
61 | fmt = v4l2_subdev_state_get_stream_format(state, port, 0);
| ^
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c: In function 'mxc_isi_crossbar_set_fmt':
>> drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:284:18: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
284 | sink_fmt = v4l2_subdev_state_get_stream_format(state, fmt->pad,
| ^
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:299:28: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
299 | source_fmt = v4l2_subdev_state_get_stream_format(state, route->source_pad,
| ^
cc1: some warnings being treated as errors
vim +61 drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
cf21f328fcafac Laurent Pinchart 2019-01-21 26
cf21f328fcafac Laurent Pinchart 2019-01-21 27 static int mxc_isi_crossbar_gasket_enable(struct mxc_isi_crossbar *xbar,
cf21f328fcafac Laurent Pinchart 2019-01-21 28 struct v4l2_subdev_state *state,
cf21f328fcafac Laurent Pinchart 2019-01-21 29 struct v4l2_subdev *remote_sd,
cf21f328fcafac Laurent Pinchart 2019-01-21 30 u32 remote_pad, unsigned int port)
cf21f328fcafac Laurent Pinchart 2019-01-21 31 {
cf21f328fcafac Laurent Pinchart 2019-01-21 32 struct mxc_isi_dev *isi = xbar->isi;
f48498ad0a4106 Guoniu.zhou 2023-06-29 33 const struct mxc_gasket_ops *gasket_ops = isi->pdata->gasket_ops;
cf21f328fcafac Laurent Pinchart 2019-01-21 34 const struct v4l2_mbus_framefmt *fmt;
cf21f328fcafac Laurent Pinchart 2019-01-21 35 struct v4l2_mbus_frame_desc fd;
cf21f328fcafac Laurent Pinchart 2019-01-21 36 int ret;
cf21f328fcafac Laurent Pinchart 2019-01-21 37
f48498ad0a4106 Guoniu.zhou 2023-06-29 38 if (!gasket_ops)
cf21f328fcafac Laurent Pinchart 2019-01-21 39 return 0;
cf21f328fcafac Laurent Pinchart 2019-01-21 40
cf21f328fcafac Laurent Pinchart 2019-01-21 41 /*
cf21f328fcafac Laurent Pinchart 2019-01-21 42 * Configure and enable the gasket with the frame size and CSI-2 data
cf21f328fcafac Laurent Pinchart 2019-01-21 43 * type. For YUV422 8-bit, enable dual component mode unconditionally,
cf21f328fcafac Laurent Pinchart 2019-01-21 44 * to match the configuration of the CSIS.
cf21f328fcafac Laurent Pinchart 2019-01-21 45 */
cf21f328fcafac Laurent Pinchart 2019-01-21 46
cf21f328fcafac Laurent Pinchart 2019-01-21 47 ret = v4l2_subdev_call(remote_sd, pad, get_frame_desc, remote_pad, &fd);
cf21f328fcafac Laurent Pinchart 2019-01-21 48 if (ret) {
cf21f328fcafac Laurent Pinchart 2019-01-21 49 dev_err(isi->dev,
cf21f328fcafac Laurent Pinchart 2019-01-21 50 "failed to get frame descriptor from '%s':%u: %d\n",
cf21f328fcafac Laurent Pinchart 2019-01-21 51 remote_sd->name, remote_pad, ret);
cf21f328fcafac Laurent Pinchart 2019-01-21 52 return ret;
cf21f328fcafac Laurent Pinchart 2019-01-21 53 }
cf21f328fcafac Laurent Pinchart 2019-01-21 54
cf21f328fcafac Laurent Pinchart 2019-01-21 55 if (fd.num_entries != 1) {
cf21f328fcafac Laurent Pinchart 2019-01-21 56 dev_err(isi->dev, "invalid frame descriptor for '%s':%u\n",
cf21f328fcafac Laurent Pinchart 2019-01-21 57 remote_sd->name, remote_pad);
cf21f328fcafac Laurent Pinchart 2019-01-21 58 return -EINVAL;
cf21f328fcafac Laurent Pinchart 2019-01-21 59 }
cf21f328fcafac Laurent Pinchart 2019-01-21 60
cf21f328fcafac Laurent Pinchart 2019-01-21 @61 fmt = v4l2_subdev_state_get_stream_format(state, port, 0);
cf21f328fcafac Laurent Pinchart 2019-01-21 62 if (!fmt)
cf21f328fcafac Laurent Pinchart 2019-01-21 63 return -EINVAL;
cf21f328fcafac Laurent Pinchart 2019-01-21 64
f48498ad0a4106 Guoniu.zhou 2023-06-29 65 gasket_ops->enable(isi, &fd, fmt, port);
cf21f328fcafac Laurent Pinchart 2019-01-21 66 return 0;
cf21f328fcafac Laurent Pinchart 2019-01-21 67 }
cf21f328fcafac Laurent Pinchart 2019-01-21 68
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-10-17 8:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 10:44 [PATCH 0/6] Unify sub-device state access functions Sakari Ailus
2023-10-13 10:44 ` [PATCH 1/6] media: v4l: subdev: Store the number of pads in sub-device state Sakari Ailus
2023-10-13 10:57 ` Laurent Pinchart
2023-10-13 11:06 ` Sakari Ailus
2023-10-13 11:15 ` Laurent Pinchart
2023-10-13 11:17 ` Sakari Ailus
2023-10-23 8:34 ` Tomi Valkeinen
2023-10-23 11:46 ` Laurent Pinchart
2023-10-13 10:44 ` [PATCH 2/6] media: v4l: subdev: Also return pads array information on stream functions Sakari Ailus
2023-10-13 11:07 ` Laurent Pinchart
2023-10-13 11:13 ` Sakari Ailus
2023-10-16 8:24 ` Laurent Pinchart
2023-10-16 8:59 ` Sakari Ailus
2023-10-16 10:21 ` Sakari Ailus
2023-10-23 11:42 ` Laurent Pinchart
2023-10-13 10:44 ` [PATCH 3/6] media: v4l: subdev: Rename sub-device state information access functions Sakari Ailus
2023-10-13 11:04 ` Laurent Pinchart
2023-10-13 11:09 ` Sakari Ailus
2023-10-13 11:23 ` Laurent Pinchart
2023-10-13 11:33 ` Sakari Ailus
2023-10-16 8:26 ` Laurent Pinchart
2023-10-16 8:58 ` Sakari Ailus
2023-10-17 6:00 ` kernel test robot
2023-10-17 8:22 ` kernel test robot [this message]
2023-10-13 10:44 ` [PATCH 4/6] media: v4l: subdev: v4l2_subdev_get_format always returns format now Sakari Ailus
2023-10-13 11:06 ` Laurent Pinchart
2023-10-13 10:44 ` [PATCH 5/6] media: v4l: subdev: Switch to stream-aware state functions Sakari Ailus
2023-10-17 9:17 ` kernel test robot
2023-10-13 10:44 ` [PATCH 6/6] media: v4l: subdev: Remove stream-unaware sub-device state access Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310171645.8Tac7Ez4-lkp@intel.com \
--to=lkp@intel.com \
--cc=bingbu.cao@intel.com \
--cc=hongju.wang@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.