Re: [PATCH nf-next,RFC] netfilter: nf_tables: shrink memory consumption of set elements

[kernel test robot <lkp@intel.com>]

Hi Pablo,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on netfilter-nf/main]
[also build test WARNING on next-20231017]
[cannot apply to linus/master v6.6-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_tables-shrink-memory-consumption-of-set-elements/20231017-123501
base:   git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main
patch link:    https://lore.kernel.org/r/20231013160924.119273-1-pablo%40netfilter.org
patch subject: [PATCH nf-next,RFC] netfilter: nf_tables: shrink memory consumption of set elements
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171720.CRpftrIM-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171720.CRpftrIM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310171720.CRpftrIM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/netfilter/nft_set_pipapo.c:1740: warning: Function parameter or member 'elem_priv' not described in 'nft_pipapo_activate'
>> net/netfilter/nft_set_pipapo.c:1740: warning: Excess function parameter 'elem' description in 'nft_pipapo_activate'
>> net/netfilter/nft_set_pipapo.c:1946: warning: Function parameter or member 'elem_priv' not described in 'nft_pipapo_remove'
>> net/netfilter/nft_set_pipapo.c:1946: warning: Excess function parameter 'elem' description in 'nft_pipapo_remove'


vim +1740 net/netfilter/nft_set_pipapo.c

212ed75dc5fb9d Pablo Neira Ayuso 2023-06-07  1726  
3c4287f62044a9 Stefano Brivio    2020-01-22  1727  /**
3c4287f62044a9 Stefano Brivio    2020-01-22  1728   * nft_pipapo_activate() - Mark element reference as active given key, commit
3c4287f62044a9 Stefano Brivio    2020-01-22  1729   * @net:	Network namespace
3c4287f62044a9 Stefano Brivio    2020-01-22  1730   * @set:	nftables API set representation
3c4287f62044a9 Stefano Brivio    2020-01-22  1731   * @elem:	nftables API element representation containing key data
3c4287f62044a9 Stefano Brivio    2020-01-22  1732   *
3c4287f62044a9 Stefano Brivio    2020-01-22  1733   * On insertion, elements are added to a copy of the matching data currently
212ed75dc5fb9d Pablo Neira Ayuso 2023-06-07  1734   * in use for lookups, and not directly inserted into current lookup data. Both
3c4287f62044a9 Stefano Brivio    2020-01-22  1735   * nft_pipapo_insert() and nft_pipapo_activate() are called once for each
3c4287f62044a9 Stefano Brivio    2020-01-22  1736   * element, hence we can't purpose either one as a real commit operation.
3c4287f62044a9 Stefano Brivio    2020-01-22  1737   */
3c4287f62044a9 Stefano Brivio    2020-01-22  1738  static void nft_pipapo_activate(const struct net *net,
dfe8f3c1db12ef Pablo Neira Ayuso 2023-10-13  1739  				const struct nft_set *set, void *elem_priv)
3c4287f62044a9 Stefano Brivio    2020-01-22 @1740  {
dfe8f3c1db12ef Pablo Neira Ayuso 2023-10-13  1741  	struct nft_pipapo_elem *e = elem_priv;
3c4287f62044a9 Stefano Brivio    2020-01-22  1742  
3c4287f62044a9 Stefano Brivio    2020-01-22  1743  	nft_set_elem_change_active(net, set, &e->ext);
3c4287f62044a9 Stefano Brivio    2020-01-22  1744  }
3c4287f62044a9 Stefano Brivio    2020-01-22  1745  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki