From: Rob Herring <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: gregory.clement@bootlin.com, andi.shyti@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property
Date: Tue, 17 Oct 2023 14:34:40 -0500 [thread overview]
Message-ID: <20231017193440.GA2553498-robh@kernel.org> (raw)
In-Reply-To: <20231016023504.3976746-2-chris.packham@alliedtelesis.co.nz>
On Mon, Oct 16, 2023 at 03:35:03PM +1300, Chris Packham wrote:
> Add reset-gpios and reset-delay-us properties to the marvell,mv64xxx-i2c
> binding. These can be used to describe hardware where a common reset
> GPIO is connected to all downstream devices on and I2C bus. This reset
> will be released before the downstream devices on the bus are probed.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v2:
> - Update commit message
> - Add reset-delay-us property
>
> .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> index 461d1c9ee3f7..7223797b0572 100644
> --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -70,6 +70,12 @@ properties:
> resets:
> maxItems: 1
>
> + reset-gpios:
> + maxItems: 1
It would be worth saying this is common for all downstream devices on
the I2C bus here.
> +
> + reset-delay-us:
> + description: Delay in us to wait after reset gpio de-assertion.
> +
> dmas:
> items:
> - description: RX DMA Channel
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-10-17 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 2:35 [PATCH v2 0/2] i2c: mv64xxx: reset-gpios Chris Packham
2023-10-16 2:35 ` [PATCH v2 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property Chris Packham
2023-10-16 5:25 ` Krzysztof Kozlowski
2023-10-17 19:34 ` Rob Herring [this message]
2023-10-16 2:35 ` [PATCH v2 2/2] i2c: mv64xxx: add an optional " Chris Packham
2023-10-17 20:32 ` Peter Rosin
2023-10-17 20:50 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017193440.GA2553498-robh@kernel.org \
--to=robh@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.