All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Charles <be286@163.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]         usb: gadget: f_uac1: add adaptive sync support for capture
Date: Tue, 17 Oct 2023 15:17:18 +0200	[thread overview]
Message-ID: <2023101743-repaint-krypton-ba0c@gregkh> (raw)
In-Reply-To: <20231017083918.1149647-1-be286@163.com>

On Tue, Oct 17, 2023 at 04:39:18PM +0800, Charles wrote:
>         UAC1 has it's own freerunning clock and can update Host about
>         real clock frequency through feedback endpoint so Host
>         can align number of samples sent to the UAC1 to
>         prevent overruns/underruns.
> 
>         Change UAC1 driver to make it configurable through
>         additional 'c_sync' configfs file.
> 
>         Default remains 'asynchronous' with possibility to
>         switch it to 'adaptive'.
> 
>         Signed-off-by: Charles <be286@163.com>

Why the odd indentation?

And why not use your full name?

Please fix up and send a v2.

thanks,

greg k-h

      reply	other threads:[~2023-10-17 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17  8:39 [PATCH] usb: gadget: f_uac1: add adaptive sync support for capture Charles
2023-10-17 13:17 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023101743-repaint-krypton-ba0c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=be286@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.