All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <kbusch@kernel.org>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: start keep-alive after admin queue setup
Date: Wed, 18 Oct 2023 07:45:38 +0200	[thread overview]
Message-ID: <20231018054538.GA17150@lst.de> (raw)
In-Reply-To: <20231017134535.137780-1-hare@suse.de>

On Tue, Oct 17, 2023 at 03:45:35PM +0200, Hannes Reinecke wrote:
> Setting up I/O queues might take quite some time on larger and/or
> busy setups, so KATO might expire before all I/O queues could be
> set up.
> Fix this by starting keep-alive right after the admin queue is
> operational.

Having all these manual unpaired nvme_stop_keep_alive calls look
rather unmaintainable.  What keeps us from doing it in
nvme_uninit_ctrl?



  reply	other threads:[~2023-10-18  5:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 13:45 [PATCH] nvme: start keep-alive after admin queue setup Hannes Reinecke
2023-10-18  5:45 ` Christoph Hellwig [this message]
2023-10-18  7:31   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018054538.GA17150@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.