All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Michael Walle <michael@walle.cc>,
	Pratyush Yadav <pratyush@kernel.org>,
	"open list:SPI NOR SUBSYSTEM" <linux-mtd@lists.infradead.org>
Subject: Re: [GIT PULL] mtd: spi-nor: changes for v6.7-rc1
Date: Wed, 18 Oct 2023 10:13:36 +0200	[thread overview]
Message-ID: <20231018101336.1432f64c@xps-13> (raw)
In-Reply-To: <60bc9593-445d-47c9-ac47-0b2e2b11756e@linaro.org>

Hi Tudor,

> For SPI NOR we cleaned the flash info entries in order to have
> them slimmer and self explanatory. In order to make the entries
> as slim as possible, we introduced sane default values so that
> the actual flash entries don't need to specify them. We now use
> a flexible macro to specify the flash ID instead of the previous
> INFOx() macros that had hardcoded ID lengths.
> 
> Instead of:
> -       { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 0)
> -               OTP_INFO(256, 3, 0x1000, 0x1000) },
> 
> We now use:
> +               .id = SNOR_ID(0xef, 0x80, 0x20),
> +               .name = "w25q512nwm",
> +               .otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
> 
> We also removed some flash entries: the very old Catalyst
> SPI EEPROMs that were introduced once with the SPI-NOR subsystem,
> and a Fujitsu MRAM. Both should use the at25 EEPROM driver.
> The latter even has device tree bindings for the at25 driver.
> 
> We made sure that the conversion didn't introduce any unwanted
> changes by comparing the .rodata segment before and after the
> conversion. The patches landed in linux-next immediately after
> v6.6-rc2, we haven't seen any regressions yet.
> 
> Apart of the autumn cleaning we introduced a new flash entry,
> at25ff321a, and added block protection support for mt25qu512a.

Thanks a lot for adapting the PR text according to Linus' remarks. I'll
try to do the same :-)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2023-10-18  8:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18  7:26 [GIT PULL] mtd: spi-nor: changes for v6.7-rc1 Tudor Ambarus
2023-10-18  8:13 ` Miquel Raynal [this message]
2023-11-04 11:05 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018101336.1432f64c@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.