From: Simon Horman <horms@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew@lunn.ch, netdev@vger.kernel.org,
mengyuanlou@net-swift.com
Subject: Re: [PATCH] net: wangxun: remove redundant kernel log
Date: Wed, 18 Oct 2023 13:23:17 +0200 [thread overview]
Message-ID: <20231018112317.GJ1940501@kernel.org> (raw)
In-Reply-To: <20231017100635.154967-1-jiawenwu@trustnetic.com>
On Tue, Oct 17, 2023 at 06:06:35PM +0800, Jiawen Wu wrote:
> Since PBA info can be read from lspci, delete txgbe_read_pba_string()
> and the prints. In addition, delete the redundant MAC address printing.
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 5 -
> drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c | 108 ------------------
> drivers/net/ethernet/wangxun/txgbe/txgbe_hw.h | 1 -
> .../net/ethernet/wangxun/txgbe/txgbe_main.c | 8 --
> .../net/ethernet/wangxun/txgbe/txgbe_type.h | 6 -
> 5 files changed, 128 deletions(-)
Thanks, this is a nice cleanup.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-10-18 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 10:06 [PATCH] net: wangxun: remove redundant kernel log Jiawen Wu
2023-10-18 11:23 ` Simon Horman [this message]
2023-10-18 13:53 ` Andrew Lunn
2023-10-19 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018112317.GJ1940501@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.