From: Simon Horman <horms@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net: fec: Fix device_get_match_data usage
Date: Wed, 18 Oct 2023 13:33:30 +0200 [thread overview]
Message-ID: <20231018113330.GN1940501@kernel.org> (raw)
In-Reply-To: <20231017063419.925266-2-alexander.stein@ew.tq-group.com>
On Tue, Oct 17, 2023 at 08:34:18AM +0200, Alexander Stein wrote:
> device_get_match_data() expects that of_device_id->data points to actual
> fec_devinfo data, not a platform_device_id entry.
> Fix this by adjusting OF device data pointers to their corresponding
> structs.
> enum imx_fec_type is now unused and can be removed.
>
> Fixes: b0377116decd ("net: ethernet: Use device_get_match_data()")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-10-18 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 6:34 [PATCH v2 0/2] net: fec: Fix device_get_match_data usage Alexander Stein
2023-10-17 6:34 ` [PATCH v2 1/2] " Alexander Stein
2023-10-18 11:33 ` Simon Horman [this message]
2023-10-17 6:34 ` [PATCH v2 2/2] net: fec: Remove non-Coldfire platform IDs Alexander Stein
2023-10-18 11:33 ` Simon Horman
2023-10-17 14:37 ` [PATCH v2 0/2] net: fec: Fix device_get_match_data usage Rob Herring
2023-10-19 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018113330.GN1940501@kernel.org \
--to=horms@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.