From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A19CDB47E for ; Wed, 18 Oct 2023 14:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345052AbjJRONO (ORCPT ); Wed, 18 Oct 2023 10:13:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235038AbjJROMo (ORCPT ); Wed, 18 Oct 2023 10:12:44 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B71719E; Wed, 18 Oct 2023 07:12:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 252B6C433CC; Wed, 18 Oct 2023 14:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697638362; bh=tv4RiEg8NKvQaw8+zHTzja6tth6QsMbdBzAGTEpI3rQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j/IO1PkDRHODQ3+VlYoBbVVZdahOuBIxqSmlgpE1eK0zQAdqAxalXLydvhmwrLWQR KZYCvZpWdnmTRDIBVuIEcujHjPWZGvXhNC1nIDe68i/K0pNi08AQtK5WLQwRtQCle7 kFu+hav1PnsXeeN66PT3ZKJCKYHvmITkfOqRdhnnFhl35P6CNc6VKf1eUxdoZVa8js 1PWPDj1n9wnfaCpAsxWubEFcQp69zdi5xvTSsqVgkqxKc8nEG9g3CDWAoLDJCO6WTs MRT+l84nx1huD7Hl0TGWMu1yeCs/LHv9CuXHTJDohTVzAZgWigXCYBYv/YSEA1Mdsc w5lGm1JEl5VcQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ben Wolsieffer , Marc Zyngier , Sasha Levin , tglx@linutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.5 20/31] irqchip/stm32-exti: add missing DT IRQ flag translation Date: Wed, 18 Oct 2023 10:11:37 -0400 Message-Id: <20231018141151.1334501-20-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231018141151.1334501-1-sashal@kernel.org> References: <20231018141151.1334501-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.5.7 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ben Wolsieffer [ Upstream commit 8554cba1d6dbd3c74e0549e28ddbaccbb1d6b30a ] The STM32F4/7 EXTI driver was missing the xlate callback, so IRQ trigger flags specified in the device tree were being ignored. This was preventing the RTC alarm interrupt from working, because it must be set to trigger on the rising edge to function correctly. Signed-off-by: Ben Wolsieffer Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20231003162003.1649967-1-ben.wolsieffer@hefring.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-stm32-exti.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index b5fa76ce5046a..cb4b195bc849a 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -459,6 +459,7 @@ static const struct irq_domain_ops irq_exti_domain_ops = { .map = irq_map_generic_chip, .alloc = stm32_exti_alloc, .free = stm32_exti_free, + .xlate = irq_domain_xlate_twocell, }; static void stm32_irq_ack(struct irq_data *d) -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA4E2CDB47E for ; Wed, 18 Oct 2023 14:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w/OB3QwTRkZj6WTjRODdFHf51QLRpN7yjob35pY9qHY=; b=Jqx1ZnlUOEB40v v6V7OJGbzfG3Y1b0rNJNcGXLqDS3bneGdmuD0AC7KRnMHoyWS96bg8Y1OZgvfJS4iKhPJarxbTfJU yW1cqoubyJXtYKp2S9N/Nn7KDrDA1ph6v4AgSBbBxAegh1PWYCchLYZEm1klMF4w3Af4I6MpAMuzn IbIZPCM+xCFqYLyB01fcAJXUgUAkf//fB61z8/PG2Ogb0VOZWgO9xUi1MKNm87F29PnEIcg30yqIR JqzAED/E6FExSCY0/dphYF2+DgUGWI8t7asdFN2C/J6xQMIrqk5QQ9NP5HrWZ7Mv3KUhDP9RdxoJW mMpg0DZafbISXhdgQ5fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt7I2-00ErVw-1O; Wed, 18 Oct 2023 14:12:50 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt7Hv-00ErRm-2k for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 14:12:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 79CF0B82374; Wed, 18 Oct 2023 14:12:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 252B6C433CC; Wed, 18 Oct 2023 14:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697638362; bh=tv4RiEg8NKvQaw8+zHTzja6tth6QsMbdBzAGTEpI3rQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j/IO1PkDRHODQ3+VlYoBbVVZdahOuBIxqSmlgpE1eK0zQAdqAxalXLydvhmwrLWQR KZYCvZpWdnmTRDIBVuIEcujHjPWZGvXhNC1nIDe68i/K0pNi08AQtK5WLQwRtQCle7 kFu+hav1PnsXeeN66PT3ZKJCKYHvmITkfOqRdhnnFhl35P6CNc6VKf1eUxdoZVa8js 1PWPDj1n9wnfaCpAsxWubEFcQp69zdi5xvTSsqVgkqxKc8nEG9g3CDWAoLDJCO6WTs MRT+l84nx1huD7Hl0TGWMu1yeCs/LHv9CuXHTJDohTVzAZgWigXCYBYv/YSEA1Mdsc w5lGm1JEl5VcQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ben Wolsieffer , Marc Zyngier , Sasha Levin , tglx@linutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.5 20/31] irqchip/stm32-exti: add missing DT IRQ flag translation Date: Wed, 18 Oct 2023 10:11:37 -0400 Message-Id: <20231018141151.1334501-20-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231018141151.1334501-1-sashal@kernel.org> References: <20231018141151.1334501-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.5.7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_071244_042912_0F7FC04F X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ben Wolsieffer [ Upstream commit 8554cba1d6dbd3c74e0549e28ddbaccbb1d6b30a ] The STM32F4/7 EXTI driver was missing the xlate callback, so IRQ trigger flags specified in the device tree were being ignored. This was preventing the RTC alarm interrupt from working, because it must be set to trigger on the rising edge to function correctly. Signed-off-by: Ben Wolsieffer Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20231003162003.1649967-1-ben.wolsieffer@hefring.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-stm32-exti.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index b5fa76ce5046a..cb4b195bc849a 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -459,6 +459,7 @@ static const struct irq_domain_ops irq_exti_domain_ops = { .map = irq_map_generic_chip, .alloc = stm32_exti_alloc, .free = stm32_exti_free, + .xlate = irq_domain_xlate_twocell, }; static void stm32_irq_ack(struct irq_data *d) -- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel