Re: [PATCH RFC 2/5] mm: percpu: fix variable type of cpu

[kernel test robot <lkp@intel.com>]

Hi Rongwei,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on driver-core/driver-core-next driver-core/driver-core-linus tip/x86/mm linus/master v6.6-rc6]
[cannot apply to akpm-mm/mm-everything next-20231018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Rongwei-Wang/mm-percpu-fix-variable-type-of-cpu/20231017-102250
base:   driver-core/driver-core-testing
patch link:    https://lore.kernel.org/r/20231012024842.99703-3-rongwei.wang%40linux.alibaba.com
patch subject: [PATCH RFC 2/5] mm: percpu: fix variable type of cpu
config: loongarch-randconfig-001-20231018 (https://download.01.org/0day-ci/archive/20231018/202310181554.HybMih8u-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231018/202310181554.HybMih8u-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310181554.HybMih8u-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/loongarch/kernel/numa.c: In function 'setup_per_cpu_areas':
>> arch/loongarch/kernel/numa.c:93:64: error: passing argument 5 of 'pcpu_embed_first_chunk' from incompatible pointer type [-Werror=incompatible-pointer-types]
      93 |                                             pcpu_cpu_distance, pcpu_cpu_to_node);
         |                                                                ^~~~~~~~~~~~~~~~
         |                                                                |
         |                                                                int (*)(int)
   In file included from include/linux/prandom.h:13,
                    from include/linux/random.h:153,
                    from include/linux/nodemask.h:97,
                    from include/linux/mmzone.h:18,
                    from include/linux/gfp.h:7,
                    from include/linux/mm.h:7,
                    from arch/loongarch/kernel/numa.c:10:
   include/linux/percpu.h:116:58: note: expected 'int (*)(unsigned int)' but argument is of type 'int (*)(int)'
     116 |                                 pcpu_fc_cpu_to_node_fn_t cpu_to_nd_fn);
         |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
>> arch/loongarch/kernel/numa.c:99:67: error: passing argument 2 of 'pcpu_page_first_chunk' from incompatible pointer type [-Werror=incompatible-pointer-types]
      99 |                 rc = pcpu_page_first_chunk(PERCPU_MODULE_RESERVE, pcpu_cpu_to_node);
         |                                                                   ^~~~~~~~~~~~~~~~
         |                                                                   |
         |                                                                   int (*)(int)
   include/linux/percpu.h:121:58: note: expected 'int (*)(unsigned int)' but argument is of type 'int (*)(int)'
     121 |                                 pcpu_fc_cpu_to_node_fn_t cpu_to_nd_fn);
         |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/pcpu_embed_first_chunk +93 arch/loongarch/kernel/numa.c

d4b6f1562a3c32 Huacai Chen 2022-05-31   72  
d4b6f1562a3c32 Huacai Chen 2022-05-31   73  void __init setup_per_cpu_areas(void)
d4b6f1562a3c32 Huacai Chen 2022-05-31   74  {
d4b6f1562a3c32 Huacai Chen 2022-05-31   75  	unsigned long delta;
d4b6f1562a3c32 Huacai Chen 2022-05-31   76  	unsigned int cpu;
d4b6f1562a3c32 Huacai Chen 2022-05-31   77  	int rc = -EINVAL;
d4b6f1562a3c32 Huacai Chen 2022-05-31   78  
d4b6f1562a3c32 Huacai Chen 2022-05-31   79  	if (pcpu_chosen_fc == PCPU_FC_AUTO) {
d4b6f1562a3c32 Huacai Chen 2022-05-31   80  		if (nr_node_ids >= 8)
d4b6f1562a3c32 Huacai Chen 2022-05-31   81  			pcpu_chosen_fc = PCPU_FC_PAGE;
d4b6f1562a3c32 Huacai Chen 2022-05-31   82  		else
d4b6f1562a3c32 Huacai Chen 2022-05-31   83  			pcpu_chosen_fc = PCPU_FC_EMBED;
d4b6f1562a3c32 Huacai Chen 2022-05-31   84  	}
d4b6f1562a3c32 Huacai Chen 2022-05-31   85  
d4b6f1562a3c32 Huacai Chen 2022-05-31   86  	/*
d4b6f1562a3c32 Huacai Chen 2022-05-31   87  	 * Always reserve area for module percpu variables.  That's
d4b6f1562a3c32 Huacai Chen 2022-05-31   88  	 * what the legacy allocator did.
d4b6f1562a3c32 Huacai Chen 2022-05-31   89  	 */
d4b6f1562a3c32 Huacai Chen 2022-05-31   90  	if (pcpu_chosen_fc != PCPU_FC_PAGE) {
d4b6f1562a3c32 Huacai Chen 2022-05-31   91  		rc = pcpu_embed_first_chunk(PERCPU_MODULE_RESERVE,
d4b6f1562a3c32 Huacai Chen 2022-05-31   92  					    PERCPU_DYNAMIC_RESERVE, PMD_SIZE,
d4b6f1562a3c32 Huacai Chen 2022-05-31  @93  					    pcpu_cpu_distance, pcpu_cpu_to_node);
d4b6f1562a3c32 Huacai Chen 2022-05-31   94  		if (rc < 0)
d4b6f1562a3c32 Huacai Chen 2022-05-31   95  			pr_warn("%s allocator failed (%d), falling back to page size\n",
d4b6f1562a3c32 Huacai Chen 2022-05-31   96  				pcpu_fc_names[pcpu_chosen_fc], rc);
d4b6f1562a3c32 Huacai Chen 2022-05-31   97  	}
d4b6f1562a3c32 Huacai Chen 2022-05-31   98  	if (rc < 0)
d4b6f1562a3c32 Huacai Chen 2022-05-31  @99  		rc = pcpu_page_first_chunk(PERCPU_MODULE_RESERVE, pcpu_cpu_to_node);
d4b6f1562a3c32 Huacai Chen 2022-05-31  100  	if (rc < 0)
d4b6f1562a3c32 Huacai Chen 2022-05-31  101  		panic("cannot initialize percpu area (err=%d)", rc);
d4b6f1562a3c32 Huacai Chen 2022-05-31  102  
d4b6f1562a3c32 Huacai Chen 2022-05-31  103  	delta = (unsigned long)pcpu_base_addr - (unsigned long)__per_cpu_start;
d4b6f1562a3c32 Huacai Chen 2022-05-31  104  	for_each_possible_cpu(cpu)
d4b6f1562a3c32 Huacai Chen 2022-05-31  105  		__per_cpu_offset[cpu] = delta + pcpu_unit_offsets[cpu];
d4b6f1562a3c32 Huacai Chen 2022-05-31  106  }
d4b6f1562a3c32 Huacai Chen 2022-05-31  107  #endif
d4b6f1562a3c32 Huacai Chen 2022-05-31  108  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki