All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: <horms@kernel.org>, <linux-kernel@vger.kernel.org>,
	<pabeni@redhat.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<egallen@redhat.com>, <hgani@marvell.com>, <mschmidt@redhat.com>,
	<netdev@vger.kernel.org>, <sedara@marvell.com>,
	<vburru@marvell.com>, <vimleshk@marvell.com>
Subject: Re: [net-next PATCH v3] octeon_ep: pack hardware structure
Date: Wed, 18 Oct 2023 17:06:05 -0700	[thread overview]
Message-ID: <20231018170605.392efc0d@kernel.org> (raw)
In-Reply-To: <20231016092051.2306831-1-srasheed@marvell.com>

On Mon, 16 Oct 2023 02:20:51 -0700 Shinas Rasheed wrote:
> Clean up structure defines related to hardware data to be
> attributed 'packed' in the code, as padding is not allowed
> by hardware.

Looks like the patch was marked as Changes Requested in pw.
I'm guessing it's because we generally discourage __packed.
It's better to add size asserts, e.g.:

static_assert(sizeof(struct octep_oq_desc_hw) == 16);

__packed also implies lack of alignment, which may force compiler 
to generate worse code.

  parent reply	other threads:[~2023-10-19  0:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16  9:20 [net-next PATCH v3] octeon_ep: pack hardware structure Shinas Rasheed
2023-10-17  9:38 ` Simon Horman
2023-10-19  0:06 ` Jakub Kicinski [this message]
2023-10-19 18:46   ` [EXT] " Shinas Rasheed
2023-10-19 19:51     ` Jakub Kicinski
2023-10-20  6:48       ` Shinas Rasheed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231018170605.392efc0d@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=egallen@redhat.com \
    --cc=hgani@marvell.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sedara@marvell.com \
    --cc=srasheed@marvell.com \
    --cc=vburru@marvell.com \
    --cc=vimleshk@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.