From: Florian Eckert <fe@dev.tdt.de>
To: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org,
kabel@kernel.org, u.kleine-koenig@pengutronix.de,
ansuelsmth@gmail.com, m.brock@vanmierlo.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: [PATCH v4 0/3] ledtrig-tty: add additional tty state evaluation
Date: Thu, 19 Oct 2023 13:28:06 +0200 [thread overview]
Message-ID: <20231019112809.881730-1-fe@dev.tdt.de> (raw)
Changes in v4:
- Merging patch 3/4 into patch number 4/4 from previous series, because
it fixes a problem that does not exist upstream. This was a note from
the build robot regarding my change that I added with previous series.
This change was never upstream and therefore this is not relevant.
- Update the commit message of patch 1/3 of this series, that this commit
also changes the 'ndashes' to simple dashes. There were no changes, so
I add the 'Reviewed-by' that the commit received before.
- With this patchset version I have reworked my implementation for the
evaluation of the additional line state, so that this changes becomes
smaller. As basis I have used the staged commits from Christian Marangi
that makes this changes to the netdev trigger. This has already been
applied to 'for-leds-next-next' by Lee Jones. I adapted this to the
tty trigger.
Convert device attr to macro:
https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/commit/drivers/leds/trigger?h=for-leds-next-next&id=509412749002f4bac4c29f2012fff90c08d8afca
Unify sysfs and state handling:
https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/commit/drivers/leds/trigger?h=for-leds-next-next&id=0fd93ac8582627bee9a3c824489f302dff722881
Changes in v3:
- Add missing 'kernel test robot' information to the commit message.
- Additional information added to the commit message
Changes in v2:
- rename new function from tty_get_mget() to tty_get_tiocm() as
requested by 'Jiri Slaby'.
- As suggested by 'Jiri Slaby', fixed tabs in function documentation
throughout the file '/drivers/tty/tty_io.c' in a separate commit.
- Move the variable definition to the top in function
'ledtrig_tty_work()'.
This was reported by the 'kernel test robot' after my change in v1.
- Also set the 'max_brightness' to 'blink_brightness' if no
'blink_brightness' was set. This fixes a problem at startup when the
brightness is still set to 0 and only 'line_*' is evaluated. I looked
in the netdev trigger and that's exactly how it's done there.
v1:
This is a follow-up patchset, based on the mailing list discussion from
March 2023 based on the old patchset v8 [1]. I have changed, the LED
trigger handling via the sysfs interfaces as suggested by Uwe Kleine-König.
[1] https://lore.kernel.org/linux-leds/20230306094113.273988-1-fe@dev.tdt.de/
Florian Eckert (3):
tty: whitespaces in descriptions corrected by replacing tabs with
spaces
tty: add new helper function tty_get_tiocm
leds: ledtrig-tty: add new line mode evaluation
.../ABI/testing/sysfs-class-led-trigger-tty | 54 +++++
drivers/leds/trigger/ledtrig-tty.c | 192 +++++++++++++++++-
drivers/tty/tty_io.c | 130 ++++++------
include/linux/tty.h | 1 +
4 files changed, 309 insertions(+), 68 deletions(-)
--
2.30.2
next reply other threads:[~2023-10-19 11:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 11:28 Florian Eckert [this message]
2023-10-19 11:28 ` [PATCH v4 1/3] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-21 16:08 ` Greg KH
2023-10-21 16:28 ` Greg KH
2023-10-22 10:24 ` Florian Eckert
2023-10-22 11:19 ` Greg KH
2023-10-19 11:28 ` [PATCH v4 2/3] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-21 16:15 ` Greg KH
2023-10-22 10:24 ` Florian Eckert
2023-10-19 11:28 ` [PATCH v4 3/3] leds: ledtrig-tty: add new line mode evaluation Florian Eckert
2023-10-21 16:07 ` Greg KH
2023-10-22 10:24 ` Florian Eckert
2023-10-22 11:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019112809.881730-1-fe@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=ansuelsmth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.brock@vanmierlo.com \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.