From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E609CDB465 for ; Thu, 19 Oct 2023 13:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VBtQBfSgu0UC79THYONGCmocHjJueWjjc6b8STT4CwY=; b=pBCOkvGgBozOr5 T1QoesmtvPx3Q+jPO7dCSMVHaCZvLjKce1uskhyL9G03vt3mzY2e3muu/Fdb1VYDpUtP1Rt5U0GmU uo6k7nqLXvhfTA6q8UL6TQWGHOuePZTpagDdbza6oFEAaeCZOEP/MXCP6t5O6RdGbKW16L4d9u/rA pBAnmR/wDHeKdx4H9xOtHSEvj64cavZSBU5UvHqu+/dKxwD4tSBCuS9VwNYETXhCnmMdL5A2TEiTJ HLK6n6qI16FbjqMoySqZM5d/PE50A+VMrXTqLhKum+BfKBNU2j5u9bBGVbjSYGHdvAWL/kIYv4mxv UDghxd7FGFUEhDLn/gZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtTH2-00HY3M-0h; Thu, 19 Oct 2023 13:41:16 +0000 Received: from mail-oa1-f41.google.com ([209.85.160.41]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtTGz-00HY2I-1T for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 13:41:14 +0000 Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1e0ee4e777bso5043839fac.3 for ; Thu, 19 Oct 2023 06:41:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697722871; x=1698327671; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P9AD1JfVARQKPIgD2WtIcrrwf03qLXP4ogD7h2MXnzs=; b=W/PcCK+2Iya4FS0M81qZB6E7537uwJ6fW6GtITiC7V7mBiHdq694gNCJuFLp1ysdpE YrCAbiSIMTNmYxb2kWp7osxuusvrdlHOGVfRHlsQ2lNrstn0GxLI+zci9IqCTdNiV5X6 Oawd5NsJNXZawOFobyrZuQoKOb++Dyc6tgRBAcF84WdT4l3Zf/qKfqmajfuTYFFtUdsV Kss48zUdF9qJYZ47WoOBxGzyn8sah4hVDUwq8nLjcdeM5esH4PhilQLpB5xnGwfpsyON G2G5J0QAvf4Y8BhjSCEY0KOWYXF47Qtj43eTLuLAjU0YA2WujDPi+MyigWJp+cTwyGwO bofA== X-Gm-Message-State: AOJu0Yx5cqMeh2vEXumTrtqoOIxcqNo43Sq2+n7A0qYgD5buCzJK/xW6 NLnwYUeB8bXlkKzPSTpUyA== X-Google-Smtp-Source: AGHT+IHlen4DCcYIWDQZw3HdnzAxhSVqjwrtisVygcXkq64I/+aqT6xTPgJimmb9+EXUw242RCvsgQ== X-Received: by 2002:a05:6870:b406:b0:1e9:b496:ce2d with SMTP id x6-20020a056870b40600b001e9b496ce2dmr2895598oap.12.1697722870951; Thu, 19 Oct 2023 06:41:10 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id ef8-20020a0568701a8800b001e9b02b00e9sm1158356oab.22.2023.10.19.06.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 06:41:10 -0700 (PDT) Received: (nullmailer pid 192889 invoked by uid 1000); Thu, 19 Oct 2023 13:41:09 -0000 Date: Thu, 19 Oct 2023 08:41:09 -0500 From: Rob Herring To: Conor Dooley Cc: "Russell King (Oracle)" , Linus Walleij , Christian Marangi , Andrew Lunn , Florian Fainelli , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Conor Dooley , Sebastian Hesselbarth , Eric Dumazet , Vladimir Oltean , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-kernel@vger.kernel.org, Gregory Clement Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Message-ID: <20231019134109.GA63240-robh@kernel.org> References: <20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org> <20231018-marvell-88e6152-wan-led-v4-1-3ee0c67383be@linaro.org> <169762516670.391804.7528295251386913602.robh@kernel.org> <20231019-pulse-autopilot-166bb6c96090@spud> <20231019-friday-fabulous-4882c4048b8c@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231019-friday-fabulous-4882c4048b8c@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_064113_490719_2012E90B X-CRM114-Status: GOOD ( 37.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMTksIDIwMjMgYXQgMDE6NDY6MzZQTSArMDEwMCwgQ29ub3IgRG9vbGV5IHdy b3RlOgo+IE9uIFRodSwgT2N0IDE5LCAyMDIzIGF0IDAxOjI3OjA5UE0gKzAxMDAsIFJ1c3NlbGwg S2luZyAoT3JhY2xlKSB3cm90ZToKPiA+IE9uIFRodSwgT2N0IDE5LCAyMDIzIGF0IDEyOjU4OjQ2 UE0gKzAxMDAsIENvbm9yIERvb2xleSB3cm90ZToKPiA+ID4gT24gVGh1LCBPY3QgMTksIDIwMjMg YXQgMTE6NTg6NDlBTSArMDEwMCwgUnVzc2VsbCBLaW5nIChPcmFjbGUpIHdyb3RlOgo+ID4gPiA+ IE9uIFdlZCwgT2N0IDE4LCAyMDIzIGF0IDAxOjExOjQ1UE0gKzAyMDAsIExpbnVzIFdhbGxlaWog d3JvdGU6Cj4gPiA+ID4gPiBPbiBXZWQsIE9jdCAxOCwgMjAyMyBhdCAxMjozMuKAr1BNIFJvYiBI ZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+ID4gPiBPbiBXZWQsIDE4IE9j dCAyMDIzIDExOjAzOjQwICswMjAwLCBMaW51cyBXYWxsZWlqIHdyb3RlOgo+ID4gPiA+ID4gCj4g PiA+ID4gPiA+ID4gQmluZGluZ3MgdXNpbmcgZHNhLnlhbWwjLyRkZWZzL2V0aGVybmV0LXBvcnRz IHNwZWNpZnkgdGhhdAo+ID4gPiA+ID4gPiA+IGEgRFNBIHN3aXRjaCBub2RlIG5lZWQgdG8gaGF2 ZSBhIHBvcnRzIG9yIGV0aGVybmV0LXBvcnRzCj4gPiA+ID4gPiA+ID4gc3Vibm9kZSwgYW5kIHRo YXQgaXMgYWN0dWFsbHkgcmVxdWlyZWQsIHNvIGFkZCByZXF1aXJlbWVudHMKPiA+ID4gPiA+ID4g PiB1c2luZyBvbmVPZi4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IFN1Z2dlc3RlZC1ieTog Um9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4KPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxpbmFyby5vcmc+Cj4gPiA+ID4gPiA+ID4g LS0tCj4gPiA+ID4gPiA+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQv ZHNhL2RzYS55YW1sIHwgNiArKysrKysKPiA+ID4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDYg aW5zZXJ0aW9ucygrKQo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IE15IGJv dCBmb3VuZCBlcnJvcnMgcnVubmluZyAnbWFrZSBEVF9DSEVDS0VSX0ZMQUdTPS1tIGR0X2JpbmRp bmdfY2hlY2snCj4gPiA+ID4gPiA+IG9uIHlvdXIgcGF0Y2ggKERUX0NIRUNLRVJfRkxBR1MgaXMg bmV3IGluIHY1LjEzKToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4geWFtbGxpbnQgd2FybmluZ3Mv ZXJyb3JzOgo+ID4gPiA+ID4gPiAuL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9u ZXQvZHNhL2RzYS55YW1sOjYwOjc6IFt3YXJuaW5nXSB3cm9uZyBpbmRlbnRhdGlvbjogZXhwZWN0 ZWQgOCBidXQgZm91bmQgNiAoaW5kZW50YXRpb24pCj4gPiA+ID4gPiA+IC4vRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9kc2EvZHNhLnlhbWw6NjI6NzogW3dhcm5pbmddIHdy b25nIGluZGVudGF0aW9uOiBleHBlY3RlZCA4IGJ1dCBmb3VuZCA2IChpbmRlbnRhdGlvbikKPiA+ ID4gPiA+IAo+ID4gPiA+ID4gUmVhbGx5Pwo+ID4gPiA+ID4gCj4gPiA+ID4gPiArICBvbmVPZjoK PiA+ID4gPiA+ICsgICAgLSByZXF1aXJlZDoKPiA+ID4gPiA+ICsgICAgICAtIHBvcnRzCj4gPiA+ ID4gPiArICAgIC0gcmVxdWlyZWQ6Cj4gPiA+ID4gPiArICAgICAgLSBldGhlcm5ldC1wb3J0cwo+ ID4gPiA+ID4gCj4gPiA+ID4gPiBUd28gc3BhY2VzIGFmdGVyIHRoZSBvbmVPZiwgMiBzcGFjZXMg YWZ0ZXIgYSByZXF1aXJlZCBhcyB1c3VhbC4KPiA+ID4gPiA+IEkgZG9uJ3QgZ2V0IGl0LgoKRWl0 aGVyIHdheSBpcyB2YWxpZC4gSXQncyBqdXN0IDIgZGlmZmVyZW50IGNvbW1vbiBzdHlsZXMgYW5k IEkgcGlja2VkIAp0aGUgb3RoZXIgd2F5LiBUaGUgcmVhc29uIGlzIHRvIGxvb2sgZGlmZmVyZW50 IGZvciBhIHNlcXVlbmNlIHZzLiAKbWFwcGluZzoKCi0gcmVxdWlyZWQ6CiAgLSBldGhlcm5ldC1w b3J0cwoKLSByZXF1aXJlZDoKICAgIGV0aGVybmV0LXBvcnRzCgpJdCdzIGVhc3kgdG8gbWlzcyB0 aGUgbWlzc2luZyAnLScuCgoKPiA+ID4gPiBHaXZlbiB0aGUgb3RoZXIgcHl0aG9uIGVycm9ycyBz cGF0IG91dCBpbiBSb2IncyByZXBvcnQsIEkgd291bGQgc3VnZ2VzdAo+ID4gPiA+IHRoYXQgdGhl ICJib3QiIGlzIHJ1bm5pbmcgYSBkZXZlbG9wbWVudCB2ZXJzaW9uIHRoYXQgaGFzbid0IGJlZW4g ZnVsbHkKPiA+ID4gPiB0ZXN0ZWQsIHNvIGFueXRoaW5nIGl0IHNwaXRzIG91dCBpcyBzdXNwZWN0 LiBNYXliZSBSb2IgY2FuIGNvbW1lbnQgb24KPiA+ID4gPiB0aGUgdmFsaWRpdHkgb2YgdGhlIHdh cm5pbmdzIGluIHRoZSByZXBvcnQuCj4gPiA+IAo+ID4gPiBJbiB0aGlzIGNhc2UsIEkgdGhpbmsg aXQgaXMgY29ycmVjdC4KPiA+ID4gMiBzcGFjZXMgZm9yIHRoZSBvbmVPZiwgMiBzcGFjZXMgdGhl IHN0YXJ0IG9mIHRoZSByZXF1aXJlZCBmb3IgdGhlCj4gPiA+IG5lc3RlZCBsaXN0LCBzbzoKPiA+ ID4gb25lT2Y6Cj4gPiA+ICAgLSByZXF1aXJlZDoKPiA+IAo+ID4gVGhpcyBpcyBhIHRvdGFsIG9m IHR3byBzcGFjZXMgaW5kZW50YXRpb24uCj4gPiAKPiA+ID4gICAgICAgLSBwb3J0cwo+ID4gCj4g PiBUaGlzIGlzIGEgdG90YWwgb2Ygc2l4IHNwYWNlcyBpbmRlbnRhdGlvbi4KPiA+IAo+ID4gWW91 IG1lbnRpb24gMiBzcGFjZXMgZm9yIHRoZSBvbmVPZiwgd2hpY2ggZXhwbGFpbnMgd2h5IHRoZSAi LSByZXF1aXJlZCIKPiA+IG5lZWRzIHRvIGJlIGluZGVudGVkIGJ5IHR3byBzcGFjZXMuIFlvdSBh bHNvIHNheSAyIHNwYWNlcyBmb3IgdGhlCj4gPiByZXF1aXJlZCBuZXN0ZWQgbGlzdCwgYnV0IHdo YXQgYWJvdXQgdGhlIG90aGVyIHR3byBzcGFjZXM/Cj4gCj4gSSBhIHdvcmQgdGhhdCBtaWdodCd2 ZSBtYWRlIGl0IG1vcmUgY2xlYXIuCj4gSXQgaXMgMiBzcGFjZXMgZm9yIHRoZSBvbmVPZiBhbmQg MiBzcGFjZXMgX2Zyb21fIHRoZSBzdGFydCBvZiB0aGUKPiByZXF1aXJlZCBmb3IgdGhlIG5lc3Rl ZCBsaXN0LgoKWWVzLCAnb25lT2YnIGhlcmUgaXMgbm90IGEganNvbi1zY2hlbWEga2V5d29yZCwg YnV0IGEga2V5IHVuZGVyICRkZWZzIApiZWNhdXNlIGl0IGlzIGluZGVudGVkLiAKCickZGVmcycg ZW50cmllcyBtdXN0IGJlIGEgc2NoZW1hL2RpY3QvbWFwcGluZyAoanNvbi1zY2hlbWEvcHl0aG9u L3lhbWwgCnRlcm1zKS4gCgo+IAo+IEluIHRoZW9yeSB5b3UgbWlnaHQgaGF2ZSBhIGNvbnRyaXZl ZCBleGFtcGxlIHRoYXQgbG9va3MgbGlrZToKPiAKPiBvbmVPZjoKPiAgIC0gcmVxdWlyZWQ6Cj4g ICAgICAgLSBwb3J0cwo+ICAgICBwcm9wZXJ0aWVzOgo+ICAgICAgIGV0aGVybmV0LXBvcnRzOiBm YWxzZQo+IAo+ICAgLSByZXF1aXJlZDoKPiAgICAgICAtIGV0aGVybmV0LXBvcnRzCj4gICAgIHBy b3BlcnRpZXM6Cj4gICAgICAgcG9ydHM6IGZhbHNlCj4gCj4gTWF5YmUgd2l0aCB0aGF0IGV4YW1w bGUgeW91IGNhbiBzZWUgdGhhdCBlYWNoIG9wdGlvbiBvZiB0aGUgb25lT2YKPiBjb250YWlucyBh IGByZXF1aXJlZGAgYW5kIGEgYHByb3BlcnRpZXNgIGNvbXBvbmVudCBhdCA0IHNwYWNlcyBvZgo+ IGluZGVudCwgYW5kIHRoZW4gaW4gdHVybiB0aGUgcmVxdWlyZWQgcHJvcGVydGllcywgYmVpbmcg c3ViLWNvbXBvbmVudHMKPiBvZiBgcmVxdWlyZWRgIGdyb3cgMiBtb3JlIHNwYWNlcyBmb3IgNi4K PiAKPiA+IEkgZ3Vlc3MgaWYgeW91J3JlIGEgWUFNTCBleHBlcnQsIHRoaXMgYWxsIG1ha2VzIHNl bnNlLCBidXQgdG8gdGhvc2Ugb2YKPiA+IHVzIHdobyBhcmVuJ3QsIHRoZXNlIHF1aXJreSAiZmVh dHVyZXMiIG9mIGl0IGp1c3Qgc2VlbSB0b3RhbGx5Cj4gPiBpbGxvZ2ljYWwuCgpJbmRlbnRhdGlv biBiZWluZyBzaWduaWZpY2FudCBpcyBub3QgcXVpcmt5LiBMYW5ndWFnZXMgY2hvb3NlIGVpdGhl ciAKaW5kZW50YXRpb24gb3IgYnJhY2tldHMgb2Ygc29tZSBmb3JtLiBZQU1MIHVzZXMgb25lIGFu ZCBKU09OIHVzZXMgdGhlIApvdGhlci4KCj4gSWYgSSB3ZXJlIGEgeWFtbCBleHBlcnQsIEkgd291 bGQgcHJvYmFibHkgYmUgYWJsZSB0byB1c2UgdGhlIGNvcnJlY3QKPiB0ZXJtaW5vbG9neSB0byBl eHBsYWluIHRoaXMgYmV0dGVyLCBidXQgaG9wZWZ1bGx5IHRoZSBleGFtcGxlIGlzIHVzZWZ1bC4K Ckl0IGhhcyBsaXR0bGUgdG8gZG8gd2l0aCBZQU1MIG90aGVyIHRoYW4gaW5kZW50YXRpb24gaXMg KnZlcnkqIApzaWduaWZpY2FudCBpbiBZQU1MLiBJdCdzIGFjdHVhbGx5IHZhbGlkIFlBTUwuIEl0 J3MgcHJvYmFibHkgdmFsaWQgCmpzb24tc2NoZW1hLCBidXQgcXVlc3Rpb25hYmxlIHVzZSBpbiB0 ZXJtcyBvZiBob3cgJGRlZnMgaXMgdHlwaWNhbGx5IAp1c2VkLgoKQW55d2F5cywgSSdtIHdvcmtp bmcgb24gYSBmaXggZm9yIHRoZSBtZXRhLXNjaGVtYS4KClJvYgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47163DDA6; Thu, 19 Oct 2023 13:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1F8E124; Thu, 19 Oct 2023 06:41:11 -0700 (PDT) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1ead2e6fab7so308143fac.0; Thu, 19 Oct 2023 06:41:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697722871; x=1698327671; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P9AD1JfVARQKPIgD2WtIcrrwf03qLXP4ogD7h2MXnzs=; b=UkJEI/pXD4KPH2ytekF3NTYXeBay0H1w+qOxvUldpMFFYYLq1OfPF/BQe86+fHxpU5 tZqipzGa6T7stLlDGV6/BLOVY/EU77KuNangC9/TsgamsBMhYbwH4xzWKZ51qqruSENh yiRRvBYWRkthGXo3RCTeIEOVnhU7Y1hw9VG6ETDQQ7m4syLnYJ0hN21Z0X8f4nfIIyqB pEeXb3xoSCK5n0JjSPwjukSG6neLks3or2TSd0ynqUcUcw8Cmcz3/m2iIMrqczvKgbpW M9kKTfPOp5Ou03CVABHrCW6LnqejgzY+9yxI5hDrdYcwkYfbATjFpNUnySZoesJgQyBd C83w== X-Gm-Message-State: AOJu0YyZPQRsUDQJpBd3RrPj40dVIT5aqSU/riP6Aaama2SOH9m4MLj7 WHH8uhA0tt9w6yHqiSkpQw== X-Google-Smtp-Source: AGHT+IHlen4DCcYIWDQZw3HdnzAxhSVqjwrtisVygcXkq64I/+aqT6xTPgJimmb9+EXUw242RCvsgQ== X-Received: by 2002:a05:6870:b406:b0:1e9:b496:ce2d with SMTP id x6-20020a056870b40600b001e9b496ce2dmr2895598oap.12.1697722870951; Thu, 19 Oct 2023 06:41:10 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id ef8-20020a0568701a8800b001e9b02b00e9sm1158356oab.22.2023.10.19.06.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 06:41:10 -0700 (PDT) Received: (nullmailer pid 192889 invoked by uid 1000); Thu, 19 Oct 2023 13:41:09 -0000 Date: Thu, 19 Oct 2023 08:41:09 -0500 From: Rob Herring To: Conor Dooley Cc: "Russell King (Oracle)" , Linus Walleij , Christian Marangi , Andrew Lunn , Florian Fainelli , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Conor Dooley , Sebastian Hesselbarth , Eric Dumazet , Vladimir Oltean , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-kernel@vger.kernel.org, Gregory Clement Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Message-ID: <20231019134109.GA63240-robh@kernel.org> References: <20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org> <20231018-marvell-88e6152-wan-led-v4-1-3ee0c67383be@linaro.org> <169762516670.391804.7528295251386913602.robh@kernel.org> <20231019-pulse-autopilot-166bb6c96090@spud> <20231019-friday-fabulous-4882c4048b8c@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231019-friday-fabulous-4882c4048b8c@spud> On Thu, Oct 19, 2023 at 01:46:36PM +0100, Conor Dooley wrote: > On Thu, Oct 19, 2023 at 01:27:09PM +0100, Russell King (Oracle) wrote: > > On Thu, Oct 19, 2023 at 12:58:46PM +0100, Conor Dooley wrote: > > > On Thu, Oct 19, 2023 at 11:58:49AM +0100, Russell King (Oracle) wrote: > > > > On Wed, Oct 18, 2023 at 01:11:45PM +0200, Linus Walleij wrote: > > > > > On Wed, Oct 18, 2023 at 12:32 PM Rob Herring wrote: > > > > > > On Wed, 18 Oct 2023 11:03:40 +0200, Linus Walleij wrote: > > > > > > > > > > > > Bindings using dsa.yaml#/$defs/ethernet-ports specify that > > > > > > > a DSA switch node need to have a ports or ethernet-ports > > > > > > > subnode, and that is actually required, so add requirements > > > > > > > using oneOf. > > > > > > > > > > > > > > Suggested-by: Rob Herring > > > > > > > Signed-off-by: Linus Walleij > > > > > > > --- > > > > > > > Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++ > > > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > > > > > > > yamllint warnings/errors: > > > > > > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:7: [warning] wrong indentation: expected 8 but found 6 (indentation) > > > > > > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:7: [warning] wrong indentation: expected 8 but found 6 (indentation) > > > > > > > > > > Really? > > > > > > > > > > + oneOf: > > > > > + - required: > > > > > + - ports > > > > > + - required: > > > > > + - ethernet-ports > > > > > > > > > > Two spaces after the oneOf, 2 spaces after a required as usual. > > > > > I don't get it. Either way is valid. It's just 2 different common styles and I picked the other way. The reason is to look different for a sequence vs. mapping: - required: - ethernet-ports - required: ethernet-ports It's easy to miss the missing '-'. > > > > Given the other python errors spat out in Rob's report, I would suggest > > > > that the "bot" is running a development version that hasn't been fully > > > > tested, so anything it spits out is suspect. Maybe Rob can comment on > > > > the validity of the warnings in the report. > > > > > > In this case, I think it is correct. > > > 2 spaces for the oneOf, 2 spaces the start of the required for the > > > nested list, so: > > > oneOf: > > > - required: > > > > This is a total of two spaces indentation. > > > > > - ports > > > > This is a total of six spaces indentation. > > > > You mention 2 spaces for the oneOf, which explains why the "- required" > > needs to be indented by two spaces. You also say 2 spaces for the > > required nested list, but what about the other two spaces? > > I a word that might've made it more clear. > It is 2 spaces for the oneOf and 2 spaces _from_ the start of the > required for the nested list. Yes, 'oneOf' here is not a json-schema keyword, but a key under $defs because it is indented. '$defs' entries must be a schema/dict/mapping (json-schema/python/yaml terms). > > In theory you might have a contrived example that looks like: > > oneOf: > - required: > - ports > properties: > ethernet-ports: false > > - required: > - ethernet-ports > properties: > ports: false > > Maybe with that example you can see that each option of the oneOf > contains a `required` and a `properties` component at 4 spaces of > indent, and then in turn the required properties, being sub-components > of `required` grow 2 more spaces for 6. > > > I guess if you're a YAML expert, this all makes sense, but to those of > > us who aren't, these quirky "features" of it just seem totally > > illogical. Indentation being significant is not quirky. Languages choose either indentation or brackets of some form. YAML uses one and JSON uses the other. > If I were a yaml expert, I would probably be able to use the correct > terminology to explain this better, but hopefully the example is useful. It has little to do with YAML other than indentation is *very* significant in YAML. It's actually valid YAML. It's probably valid json-schema, but questionable use in terms of how $defs is typically used. Anyways, I'm working on a fix for the meta-schema. Rob