From: Lukas Wunner <lukas@wunner.de>
To: Ricky WU <ricky_wu@realtek.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down
Date: Thu, 19 Oct 2023 16:35:04 +0200 [thread overview]
Message-ID: <20231019143504.GA25140@wunner.de> (raw)
In-Reply-To: <02ee7e47166a463d8d4e491b61cdd33f@realtek.com>
On Thu, Oct 19, 2023 at 01:49:50AM +0000, Ricky WU wrote:
> [ 0.267813] pci 0000:00:1c.0: [8086:a33c] type 01 class 0x060400
Cannon Lake PCH Root Port
> [ 0.275241] pci 0000:01:00.0: [10ec:5261] type 00 class 0xff0000
> [ 0.275315] pci 0000:01:00.0: reg 0x10: [mem 0xa3b00000-0xa3b00fff]
> [ 0.275782] pci 0000:01:00.0: supports D1 D2
> [ 0.275784] pci 0000:01:00.0: PME# supported from D1 D2 D3hot D3cold
> [ 0.276490] pci 0000:00:1c.0: PCI bridge to [bus 01]
Device below Root Port is initially a Realtek RTS5261 card reader.
> [ 0.395968] pcieport 0000:00:1c.0: PME: Signaling with IRQ 122
> [ 0.396009] pcieport 0000:00:1c.0: pciehp: Slot #8 AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug+ Surprise+ Interlock- NoCompl+ IbPresDis- LLActRep+
Root Port is hotplug-capable.
> [ 43.180701] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Down
> [ 43.180709] pcieport 0000:00:1c.0: pciehp: Slot(8): Card not present
> [ 44.403768] pcieport 0000:00:1c.0: pciehp: Slot(8): Card present
> [ 44.403772] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Up
> [ 44.540631] pci 0000:01:00.0: [15b7:5007] type 00 class 0x010802
Card reader is unplugged and replaced by SanDisk SN530 NVMe SSD.
> [ 51.682628] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Down
> [ 51.716800] nvme0n1: detected capacity change from 495050752 to 0
> [ 51.793382] pcieport 0000:00:1c.0: pciehp: Slot(8): Card present
> [ 51.793392] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Up
> [ 51.928633] pci 0000:01:00.0: [10ec:5261] type 00 class 0xff0000
NVMe SSD replaced by the card reader again.
> [ 54.872928] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Down
> [ 56.146581] pcieport 0000:00:1c.0: pciehp: Slot(8): Card present
> [ 56.146584] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Up
> [ 56.284632] pci 0000:01:00.0: [15b7:5007] type 00 class 0x010802
Card reader replaced by NVMe SSD, second time.
> [ 60.635845] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Down
> [ 60.676842] nvme0n1: detected capacity change from 495050752 to 0
> [ 60.748953] pcieport 0000:00:1c.0: pciehp: Slot(8): Card present
> [ 60.748958] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Up
> [ 60.884619] pci 0000:01:00.0: [10ec:5261] type 00 class 0xff0000
NVMe SSD replaced by the card reader, second time.
> [ 63.898861] pcieport 0000:00:1c.0: pciehp: Slot(8): Link Down
> [ 63.912118] BUG: unable to handle page fault for address: ffffb24d403e5010
Card reader replaced with NVMe SSD, third time.
So it took three tries to reproduce the page fault.
Thanks for the log, the issue is a little less murky now.
But it's still unclear what the root cause is and thus
what the proper solution is. I think this needs more
in-depth debugging, see my previous e-mail.
Hope that helps! Thanks,
Lukas
next prev parent reply other threads:[~2023-10-19 14:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 4:01 [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down Kai-Heng Feng
2023-10-16 9:32 ` Lukas Wunner
2023-10-17 4:35 ` Kai-Heng Feng
2023-10-17 5:44 ` Ricky WU
2023-10-17 7:10 ` Lukas Wunner
2023-10-17 7:13 ` Lukas Wunner
2023-10-17 10:25 ` Ricky WU
2023-10-18 9:44 ` Lukas Wunner
2023-10-19 1:49 ` Ricky WU
2023-10-19 14:35 ` Lukas Wunner [this message]
2023-11-08 10:29 ` Kai-Heng Feng
2023-11-10 2:26 ` Ricky WU
2023-11-10 2:41 ` Ricky WU
2023-11-16 5:22 ` Kai-Heng Feng
2023-11-29 2:11 ` Ricky WU
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 12:07 kernel test robot
2023-10-19 1:06 ` kernel test robot
2023-10-22 10:34 kernel test robot
2023-10-23 2:16 ` Liu, Yujie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019143504.GA25140@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=gpiccoli@igalia.com \
--cc=kai.heng.feng@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.