From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Karolina Stolarek <karolina.stolarek@intel.com>
Cc: Soumya Negi <soumya.negi97@gmail.com>,
Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Julia Lawall <julia.lawall@inria.fr>,
outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*()
Date: Thu, 19 Oct 2023 17:31:55 +0200 [thread overview]
Message-ID: <2023101939-portable-spoof-5fa0@gregkh> (raw)
In-Reply-To: <cbe2092b-e36b-899a-cccd-1e166534b5e0@intel.com>
On Thu, Oct 19, 2023 at 12:45:30PM +0200, Karolina Stolarek wrote:
> On 19.10.2023 09:20, Soumya Negi wrote:
> > vme.c uses printk() to log messages. To improve and standardize message
> > formatting, use logging mechanisms pr_err()/pr_warn() and
> > dev_err()/dev_warn() instead. Retain the printk log levels of the
> > messages during replacement.
> >
> > Issue found by checkpatch.pl
> >
> > Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> > ---
> > Changes in v2:
> > * Change the pr_*() calls used to replace printk's in v1 to dev_*()
> > wherever possible, as it adds more context to the message.
> > (as per feedback from julia.lawall@inria.fr &
> > gregkh@linuxfoundation.org)
>
> You don't have to include the change log here, as it's already in the cover
> letter. This space is usually used when a patch is not sent as a part of the
> series.
Either or both is fine, this is not a real issue at all, thanks
greg k-h
next prev parent reply other threads:[~2023-10-19 15:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 7:20 [PATCH v2 0/2] staging: vme_user: Replace printk's & clean up log messages Soumya Negi
2023-10-19 7:20 ` [PATCH v2 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*() Soumya Negi
2023-10-19 10:45 ` Karolina Stolarek
2023-10-19 15:31 ` Greg Kroah-Hartman [this message]
2023-10-20 2:06 ` Soumya Negi
2023-10-19 15:42 ` Andi Shyti
2023-10-19 7:20 ` [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name Soumya Negi
2023-10-19 15:41 ` Andi Shyti
2023-10-19 19:14 ` Soumya Negi
2023-10-19 21:32 ` Andi Shyti
2023-10-19 22:13 ` Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101939-portable-spoof-5fa0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=julia.lawall@inria.fr \
--cc=karolina.stolarek@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
--cc=soumya.negi97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.