All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: cma: report correct node id
Date: Fri, 20 Oct 2023 06:47:31 +0200	[thread overview]
Message-ID: <20231020044731.GD11984@lst.de> (raw)
In-Reply-To: <c3bd1f56-d241-49ba-9f5a-7f2c134e4434@huawei.com>

On Thu, Oct 19, 2023 at 03:02:10PM +0800, Kefeng Wang wrote:
>>> Use early_pfn_to_nid() to get correct node id from base instead of
>>> the default NUMA_NO_NODE in cma_declare_contiguous_nid().
>>
>> Why?
>
> before:
> cma: Reserved 32 MiB at 0x00000000fe000000 on node -1
> after:
> cma: Reserved 32 MiB at 0x00000000fe000000 on node 0
>
> I think the real nid 0 is better than -1, but yes, it is not
> a big deal.

So please document that in your commit log.



  reply	other threads:[~2023-10-20  4:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19  1:32 [PATCH] mm: cma: report correct node id Kefeng Wang
2023-10-19  5:02 ` Christoph Hellwig
2023-10-19  7:02   ` Kefeng Wang
2023-10-20  4:47     ` Christoph Hellwig [this message]
2023-10-20  6:14       ` Kefeng Wang
2023-10-25 16:37 ` Nathan Chancellor
2023-10-25 16:37   ` Nathan Chancellor
2023-10-25 16:42   ` Andrew Morton
2023-10-25 16:42     ` Andrew Morton
2023-10-30  4:22   ` Kefeng Wang
2023-10-30  4:22     ` Kefeng Wang
2023-10-30  9:34   ` Kefeng Wang
2023-10-30  9:34     ` Kefeng Wang
2023-11-01 17:29     ` Nathan Chancellor
2023-11-01 17:29       ` Nathan Chancellor
2023-11-02  2:55       ` Kefeng Wang
2023-11-02  2:55         ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231020044731.GD11984@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.