From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DBF6CDB474 for ; Fri, 20 Oct 2023 10:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376715AbjJTKN0 convert rfc822-to-8bit (ORCPT ); Fri, 20 Oct 2023 06:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376885AbjJTKNL (ORCPT ); Fri, 20 Oct 2023 06:13:11 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 75D91D5B for ; Fri, 20 Oct 2023 03:12:30 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21B742F4; Fri, 20 Oct 2023 03:13:11 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 79EFE3F5A1; Fri, 20 Oct 2023 03:12:28 -0700 (PDT) Date: Fri, 20 Oct 2023 11:12:26 +0100 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Herbert Xu , "David S. Miller" , Corentin Labbe , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Jonathan Corbet , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 02/42] crypto: sun8i-ce - Convert to platform remove callback returning void Message-ID: <20231020111226.1c5eb00c@donnerap.manchester.arm.com> In-Reply-To: <20231020075521.2121571-46-u.kleine-koenig@pengutronix.de> References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> <20231020075521.2121571-46-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, 20 Oct 2023 09:55:24 +0200 Uwe Kleine-König wrote: Hi, > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Andre Przywara Cheers, Andre > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > index d4ccd5254280..1741758e03eb 100644 > --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > @@ -1071,7 +1071,7 @@ static int sun8i_ce_probe(struct platform_device *pdev) > return err; > } > > -static int sun8i_ce_remove(struct platform_device *pdev) > +static void sun8i_ce_remove(struct platform_device *pdev) > { > struct sun8i_ce_dev *ce = platform_get_drvdata(pdev); > > @@ -1088,7 +1088,6 @@ static int sun8i_ce_remove(struct platform_device *pdev) > sun8i_ce_free_chanlist(ce, MAXFLOW - 1); > > sun8i_ce_pm_exit(ce); > - return 0; > } > > static const struct of_device_id sun8i_ce_crypto_of_match_table[] = { > @@ -1110,7 +1109,7 @@ MODULE_DEVICE_TABLE(of, sun8i_ce_crypto_of_match_table); > > static struct platform_driver sun8i_ce_driver = { > .probe = sun8i_ce_probe, > - .remove = sun8i_ce_remove, > + .remove_new = sun8i_ce_remove, > .driver = { > .name = "sun8i-ce", > .pm = &sun8i_ce_pm_ops, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D7D6C001DF for ; Fri, 20 Oct 2023 10:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=haa1gDiNIzae7oQyULIifRKib3GDGiV6IbIGIUDKKqc=; b=TO0ncyPsTlMLqU cSP3KThFjcoX+lnzDXZ0Yp3LtK8+Tu+u+KeCmrFzfh7c6jtY2shScDoq+7Q56HNEepJ6FRj68kv/4 PnRFx442nVzj5wnOYATUip/uk21EowW+yYdVpmvq/9SLyT+6layPDwiwgCN7Vb+8casLTv/tUOxk+ EKUL5qAjRRLptoveXffxeDBO5nTs1vGf2rZPMLDDrOo6iJhS73dnw9sa9wn33U1Ue9UjZvpfVjhf8 QUSYZ92Hgtd1cz2N+/R+gQaLT/y9Gq5iZQjfZlH1SsbftvJ2snkAw1wP9UkGce56fPuulBYRTKt9u VFgzEmy323X2hGpNHtug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtmUd-001krx-0i; Fri, 20 Oct 2023 10:12:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtmUa-001kr9-36 for linux-arm-kernel@lists.infradead.org; Fri, 20 Oct 2023 10:12:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21B742F4; Fri, 20 Oct 2023 03:13:11 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 79EFE3F5A1; Fri, 20 Oct 2023 03:12:28 -0700 (PDT) Date: Fri, 20 Oct 2023 11:12:26 +0100 From: Andre Przywara To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Herbert Xu , "David S. Miller" , Corentin Labbe , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Jonathan Corbet , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 02/42] crypto: sun8i-ce - Convert to platform remove callback returning void Message-ID: <20231020111226.1c5eb00c@donnerap.manchester.arm.com> In-Reply-To: <20231020075521.2121571-46-u.kleine-koenig@pengutronix.de> References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> <20231020075521.2121571-46-u.kleine-koenig@pengutronix.de> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_031233_123634_16427248 X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMCBPY3QgMjAyMyAwOTo1NToyNCArMDIwMApVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKCkhpLAoKPiBUaGUgLnJlbW92ZSgp IGNhbGxiYWNrIGZvciBhIHBsYXRmb3JtIGRyaXZlciByZXR1cm5zIGFuIGludCB3aGljaCBtYWtl cwo+IG1hbnkgZHJpdmVyIGF1dGhvcnMgd3JvbmdseSBhc3N1bWUgaXQncyBwb3NzaWJsZSB0byBk byBlcnJvciBoYW5kbGluZyBieQo+IHJldHVybmluZyBhbiBlcnJvciBjb2RlLiBIb3dldmVyIHRo ZSB2YWx1ZSByZXR1cm5lZCBpcyBpZ25vcmVkIChhcGFydAo+IGZyb20gZW1pdHRpbmcgYSB3YXJu aW5nKSBhbmQgdGhpcyB0eXBpY2FsbHkgcmVzdWx0cyBpbiByZXNvdXJjZSBsZWFrcy4KPiAKPiBU byBpbXByb3ZlIGhlcmUgdGhlcmUgaXMgYSBxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJh Y2sgcmV0dXJuCj4gdm9pZC4gSW4gdGhlIGZpcnN0IHN0ZXAgb2YgdGhpcyBxdWVzdCBhbGwgZHJp dmVycyBhcmUgY29udmVydGVkIHRvCj4gLnJlbW92ZV9uZXcoKSwgd2hpY2ggYWxyZWFkeSByZXR1 cm5zIHZvaWQuIEV2ZW50dWFsbHkgYWZ0ZXIgYWxsIGRyaXZlcnMKPiBhcmUgY29udmVydGVkLCAu cmVtb3ZlX25ldygpIHdpbGwgYmUgcmVuYW1lZCB0byAucmVtb3ZlKCkuCj4gCj4gVHJpdmlhbGx5 IGNvbnZlcnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJl bW92ZQo+IGNhbGxiYWNrIHRvIHRoZSB2b2lkIHJldHVybmluZyB2YXJpYW50Lgo+IAo+IFNpZ25l ZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXgu ZGU+CgpSZXZpZXdlZC1ieTogQW5kcmUgUHJ6eXdhcmEgPGFuZHJlLnByenl3YXJhQGFybS5jb20+ CgpDaGVlcnMsCkFuZHJlCgo+IC0tLQo+ICBkcml2ZXJzL2NyeXB0by9hbGx3aW5uZXIvc3VuOGkt Y2Uvc3VuOGktY2UtY29yZS5jIHwgNSArKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2NyeXB0by9h bGx3aW5uZXIvc3VuOGktY2Uvc3VuOGktY2UtY29yZS5jIGIvZHJpdmVycy9jcnlwdG8vYWxsd2lu bmVyL3N1bjhpLWNlL3N1bjhpLWNlLWNvcmUuYwo+IGluZGV4IGQ0Y2NkNTI1NDI4MC4uMTc0MTc1 OGUwM2ViIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvY3J5cHRvL2FsbHdpbm5lci9zdW44aS1jZS9z dW44aS1jZS1jb3JlLmMKPiArKysgYi9kcml2ZXJzL2NyeXB0by9hbGx3aW5uZXIvc3VuOGktY2Uv c3VuOGktY2UtY29yZS5jCj4gQEAgLTEwNzEsNyArMTA3MSw3IEBAIHN0YXRpYyBpbnQgc3VuOGlf Y2VfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCXJldHVybiBlcnI7Cj4g IH0KPiAgCj4gLXN0YXRpYyBpbnQgc3VuOGlfY2VfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCj4gK3N0YXRpYyB2b2lkIHN1bjhpX2NlX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ICB7Cj4gIAlzdHJ1Y3Qgc3VuOGlfY2VfZGV2ICpjZSA9IHBsYXRmb3Jt X2dldF9kcnZkYXRhKHBkZXYpOwo+ICAKPiBAQCAtMTA4OCw3ICsxMDg4LDYgQEAgc3RhdGljIGlu dCBzdW44aV9jZV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCXN1bjhp X2NlX2ZyZWVfY2hhbmxpc3QoY2UsIE1BWEZMT1cgLSAxKTsKPiAgCj4gIAlzdW44aV9jZV9wbV9l eGl0KGNlKTsKPiAtCXJldHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9m X2RldmljZV9pZCBzdW44aV9jZV9jcnlwdG9fb2ZfbWF0Y2hfdGFibGVbXSA9IHsKPiBAQCAtMTEx MCw3ICsxMTA5LDcgQEAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgc3VuOGlfY2VfY3J5cHRvX29m X21hdGNoX3RhYmxlKTsKPiAgCj4gIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHN1bjhp X2NlX2RyaXZlciA9IHsKPiAgCS5wcm9iZQkJID0gc3VuOGlfY2VfcHJvYmUsCj4gLQkucmVtb3Zl CQkgPSBzdW44aV9jZV9yZW1vdmUsCj4gKwkucmVtb3ZlX25ldwkgPSBzdW44aV9jZV9yZW1vdmUs Cj4gIAkuZHJpdmVyCQkgPSB7Cj4gIAkJLm5hbWUJCT0gInN1bjhpLWNlIiwKPiAgCQkucG0JCT0g JnN1bjhpX2NlX3BtX29wcywKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==