From: kernel test robot <lkp@intel.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH bpf-next v2 1/9] cgroup: Make operations on the cgroup root_list RCU safe
Date: Fri, 20 Oct 2023 14:35:09 +0800 [thread overview]
Message-ID: <202310201402.OTBQV3GJ-lkp@intel.com> (raw)
In-Reply-To: <20231017124546.24608-2-laoar.shao@gmail.com>
Hi Yafang,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Yafang-Shao/cgroup-Make-operations-on-the-cgroup-root_list-RCU-safe/20231017-204729
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20231017124546.24608-2-laoar.shao%40gmail.com
patch subject: [RFC PATCH bpf-next v2 1/9] cgroup: Make operations on the cgroup root_list RCU safe
config: um-defconfig (https://download.01.org/0day-ci/archive/20231020/202310201402.OTBQV3GJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231020/202310201402.OTBQV3GJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310201402.OTBQV3GJ-lkp@intel.com/
All errors (new ones prefixed by >>):
/usr/bin/ld: kernel/cgroup/cgroup.o: in function `__cset_cgroup_from_root':
>> kernel/cgroup/cgroup.c:1389: undefined reference to `lockdep_is_held'
>> collect2: error: ld returned 1 exit status
vim +1389 kernel/cgroup/cgroup.c
1362
1363 /*
1364 * Returned cgroup is without refcount but it's valid as long as cset pins it.
1365 */
1366 static inline struct cgroup *__cset_cgroup_from_root(struct css_set *cset,
1367 struct cgroup_root *root)
1368 {
1369 struct cgroup *res_cgroup = NULL;
1370
1371 if (cset == &init_css_set) {
1372 res_cgroup = &root->cgrp;
1373 } else if (root == &cgrp_dfl_root) {
1374 res_cgroup = cset->dfl_cgrp;
1375 } else {
1376 struct cgrp_cset_link *link;
1377 lockdep_assert_held(&css_set_lock);
1378
1379 list_for_each_entry(link, &cset->cgrp_links, cgrp_link) {
1380 struct cgroup *c = link->cgrp;
1381
1382 if (c->root == root) {
1383 res_cgroup = c;
1384 break;
1385 }
1386 }
1387 }
1388
> 1389 WARN_ON_ONCE(!res_cgroup && lockdep_is_held(&cgroup_mutex));
1390 return res_cgroup;
1391 }
1392
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-10-20 6:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 12:45 [RFC PATCH bpf-next v2 0/9] bpf, cgroup: Add BPF support for cgroup1 hierarchy Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 1/9] cgroup: Make operations on the cgroup root_list RCU safe Yafang Shao
2023-10-17 13:20 ` Michal Koutný
2023-10-18 2:51 ` Yafang Shao
2023-10-18 9:35 ` Tejun Heo
2023-10-19 6:38 ` Yafang Shao
2023-10-19 19:08 ` Tejun Heo
2023-10-19 19:43 ` Waiman Long
2023-10-20 9:36 ` Yafang Shao
2023-10-20 17:51 ` Tejun Heo
2023-10-22 9:32 ` Yafang Shao
2023-10-20 6:35 ` kernel test robot [this message]
2023-10-20 9:37 ` Yafang Shao
2023-10-25 8:06 ` kernel test robot
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 2/9] cgroup: Eliminate the need for cgroup_mutex in proc_cgroup_show() Yafang Shao
2023-10-17 14:04 ` Michal Koutný
2023-10-18 3:12 ` Yafang Shao
2023-10-18 9:38 ` Tejun Heo
2023-10-19 6:39 ` Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 3/9] cgroup: Add a new helper for cgroup1 hierarchy Yafang Shao
2023-10-17 15:55 ` kernel test robot
2023-10-18 3:34 ` Yafang Shao
2023-10-18 9:44 ` Tejun Heo
2023-10-19 6:41 ` Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 4/9] bpf: Add a new kfunc " Yafang Shao
2023-10-17 16:39 ` kernel test robot
2023-10-18 3:34 ` Yafang Shao
2023-10-18 9:40 ` Tejun Heo
2023-10-19 6:40 ` Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 5/9] selftests/bpf: Fix issues in setup_classid_environment() Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 6/9] selftests/bpf: Add parallel support for classid Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 7/9] selftests/bpf: Add a new cgroup helper get_classid_cgroup_id() Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 8/9] selftests/bpf: Add a new cgroup helper get_cgroup_hierarchy_id() Yafang Shao
2023-10-17 12:45 ` [RFC PATCH bpf-next v2 9/9] selftests/bpf: Add selftests for cgroup1 hierarchy Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310201402.OTBQV3GJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=laoar.shao@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.