All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kiran K <kiran.k@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: ravishankar.srivatsa@intel.com, Kiran K <kiran.k@intel.com>
Subject: [PATCH v1 2/5] bap: Fix update of sink location value
Date: Fri, 20 Oct 2023 19:55:51 +0530	[thread overview]
Message-ID: <20231020142554.486629-2-kiran.k@intel.com> (raw)
In-Reply-To: <20231020142554.486629-1-kiran.k@intel.com>

pac->sink_loc needs to be updated only if there is a change.
---
 src/shared/bap.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 925501c48d98..2fd21b81b72d 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -2491,13 +2491,11 @@ static void pacs_sink_location_changed(struct bt_pacs *pacs)
 
 static void pacs_add_sink_location(struct bt_pacs *pacs, uint32_t location)
 {
-	location |= pacs->sink_loc_value;
-
 	/* Check if location value needs updating */
 	if (location == pacs->sink_loc_value)
 		return;
 
-	pacs->sink_loc_value = location;
+	pacs->sink_loc_value |= location;
 
 	pacs_sink_location_changed(pacs);
 }
-- 
2.34.1


  reply	other threads:[~2023-10-20 14:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 14:25 [PATCH v1 1/5] media: Populate location to qos structure Kiran K
2023-10-20 14:25 ` Kiran K [this message]
2023-10-20 14:25 ` [PATCH v1 3/5] bap: Do not set default location for sink and source Kiran K
2023-10-20 14:25 ` [PATCH v1 4/5] bap: Fix reading source codec capabilities Kiran K
2023-10-20 14:25 ` [PATCH v1 5/5] media: Parse conext and supported context Kiran K
2023-10-20 15:50 ` [PATCH v1 1/5] media: Populate location to qos structure Pauli Virtanen
2023-10-20 16:32 ` [v1,1/5] " bluez.test.bot
2023-10-20 20:50 ` [PATCH v1 1/5] " patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231020142554.486629-2-kiran.k@intel.com \
    --to=kiran.k@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=ravishankar.srivatsa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.