From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: qemu-s390x@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Juan Quintela <quintela@redhat.com>
Subject: [PATCH v2 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()
Date: Fri, 20 Oct 2023 17:05:51 +0200 [thread overview]
Message-ID: <20231020150554.664422-1-thuth@redhat.com> (raw)
We must not call register_savevm_live() during instance_init()
since instances can be created at any time, e.g. during introspection
of a device. We must register the savevm handler during realize()
instead. Fix it now in the s390x devices.
v2:
- Fixed bug in the third patch ("sas" -> "dev")
- Add an early return in case of error in the third patch
- Added Acked-by/Reviewed by from David and Eric (thanks!)
Thomas Huth (3):
hw/s390x/s390-skeys: Don't call register_savevm_live() during
instance_init()
hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled"
property
hw/s390x/s390-stattrib: Don't call register_savevm_live() during
instance_init()
hw/s390x/s390-skeys.c | 35 ++++++-------------------
hw/s390x/s390-stattrib.c | 55 +++++++++++++++-------------------------
2 files changed, 29 insertions(+), 61 deletions(-)
--
2.41.0
next reply other threads:[~2023-10-20 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 15:05 Thomas Huth [this message]
2023-10-20 15:05 ` [PATCH v2 1/3] hw/s390x/s390-skeys: Don't call register_savevm_live() during instance_init() Thomas Huth
2023-10-20 15:05 ` [PATCH v2 2/3] hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property Thomas Huth
2023-10-20 15:05 ` [PATCH v2 3/3] hw/s390x/s390-stattrib: Don't call register_savevm_live() during instance_init() Thomas Huth
2023-10-23 11:32 ` [PATCH v2 0/3] hw/s390x: " Juan Quintela
2023-10-23 11:35 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020150554.664422-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.