From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, acsjakub@amazon.de
Subject: Re: [PATCH 0/5] avoid divide-by-zero due to max_nr_accesses overflow
Date: Fri, 20 Oct 2023 18:02:42 +0000 [thread overview]
Message-ID: <20231020180242.64276-1-sj@kernel.org> (raw)
In-Reply-To: <20231020103036.027282d16aaf56498230cc12@linux-foundation.org>
On Fri, 20 Oct 2023 10:30:36 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 20 Oct 2023 17:19:01 +0000 SeongJae Park <sj@kernel.org> wrote:
>
> > On Thu, 19 Oct 2023 19:49:19 +0000 SeongJae Park <sj@kernel.org> wrote:
> >
> > > The maximum nr_accesses of given DAMON context can be calculated by
> > > dividing the aggregation interval by the sampling interval. Some logics
> > > in DAMON uses the maximum nr_accesses as a divisor. Hence, the value
> > > shouldn't be zero. Such case is avoided since DAMON avoids setting the
> > > agregation interval as samller than the sampling interval. However,
> > > since nr_accesses is unsigned int while the intervals are unsigned long,
> > > the maximum nr_accesses could be zero while casting.
> >
> > Actually, the issue was reported by Jakub, and I didn't add 'Reported-by:' tags
> > for him. I sure Andrew could add that on his own, but I want to minimize
> > Andrew's load, so will send v2 of this patchset. Andrew, please let me know if
> > that doesn't help but only increasing your load.
>
> Editing the changelogs is far quicker than updating a patch series ;)
>
> btw, it's now conventional to add a link to the reporter's report. The
> new "Closes:" tag, immediately after the Reported-by:. But it's not a
> big deal.
Surely it is. And in this case, the report was made privately, so no available
link. I should have mentioned this early, sorry. Anyway, thank you for your
help, Andrew :)
Thanks,
SJ
next prev parent reply other threads:[~2023-10-20 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 19:49 [PATCH 0/5] avoid divide-by-zero due to max_nr_accesses overflow SeongJae Park
2023-10-19 19:49 ` [PATCH 1/5] mm/damon: implement a function for max nr_accesses safe calculation SeongJae Park
2023-10-19 19:49 ` [PATCH 2/5] mm/damon/core: avoid divide-by-zero during monitoring results update SeongJae Park
2023-10-19 19:49 ` [PATCH 3/5] mm/damon/ops-common: avoid divide-by-zero during region hotness calculation SeongJae Park
2023-10-19 19:49 ` [PATCH 4/5] mm/damon/lru_sort: avoid divide-by-zero in hot threshold calculation SeongJae Park
2023-10-19 19:49 ` [PATCH 5/5] mm/damon/core: avoid divide-by-zero from pseudo-moving window length calculation SeongJae Park
2023-10-20 17:19 ` [PATCH 0/5] avoid divide-by-zero due to max_nr_accesses overflow SeongJae Park
2023-10-20 17:30 ` Andrew Morton
2023-10-20 18:02 ` SeongJae Park [this message]
2023-10-20 17:31 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020180242.64276-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=acsjakub@amazon.de \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.