Re: [PATCH v3 1/5] staging: vme_user: Replace printk() with dev_*()

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Oct 20, 2023 at 09:50:40AM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 20 Oct 2023, Soumya Negi wrote:
> 
> > On Fri, Oct 20, 2023 at 01:09:26PM +0800, kernel test robot wrote:
> > > Hi Soumya,
> > >
> > > kernel test robot noticed the following build warnings:
> > >
> > > [auto build test WARNING on staging/staging-testing]
> > >
> > > url:    https://github.com/intel-lab-lkp/linux/commits/Soumya-Negi/staging-vme_user-Replace-printk-with-dev_/20231020-095619
> > > base:   staging/staging-testing
> > > patch link:    https://lore.kernel.org/r/a36a0b839f9c21efe1f2df6f9272ae882fd04fb8.1697763267.git.soumya.negi97%40gmail.com
> > > patch subject: [PATCH v3 1/5] staging: vme_user: Replace printk() with dev_*()
> > > reproduce: (https://download.01.org/0day-ci/archive/20231020/202310201236.d4IEfmLQ-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202310201236.d4IEfmLQ-lkp@intel.com/
> > >
> > > # many are suggestions rather than must-fix
> > >
> > > WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'vme_slave_get', this function's name, in a string
> > > #118: FILE: drivers/staging/vme_user/vme.c:425:
> > > +		dev_err(bridge->parent, "vme_slave_get not supported\n");
> > >
> > > WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'vme_master_set', this function's name, in a string
> > > #191: FILE: drivers/staging/vme_user/vme.c:577:
> > > +		dev_warn(bridge->parent, "vme_master_set not supported\n");
> > >
> > > WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'vme_lm_set', this function's name, in a string
> > > #583: FILE: drivers/staging/vme_user/vme.c:1577:
> > > +		dev_err(bridge->parent, "vme_lm_set not supported\n");
> > >
> > > WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'vme_lm_get', this function's name, in a string
> > > #600: FILE: drivers/staging/vme_user/vme.c:1613:
> > > +		dev_err(bridge->parent, "vme_lm_get not supported\n");
> > >
> > > WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'vme_lm_attach', this function's name, in a string
> > > #617: FILE: drivers/staging/vme_user/vme.c:1650:
> > > +		dev_err(bridge->parent, "vme_lm_attach not supported\n");
> > >
> > > WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'vme_lm_detach', this function's name, in a string
> > > #634: FILE: drivers/staging/vme_user/vme.c:1683:
> > > +		dev_err(bridge->parent, "vme_lm_detach not supported\n");
> > >
> > > WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'vme_slot_num', this function's name, in a string
> > > #662: FILE: drivers/staging/vme_user/vme.c:1751:
> > > +		dev_warn(bridge->parent, "vme_slot_num not supported\n");
> > >
> > > --
> > > 0-DAY CI Kernel Test Service
> > > https://github.com/intel/lkp-tests/wiki
> >
> > Hi,
> >
> > There are changes being made in stages. This patch is replacing printk() to
> > dev_err() while keeping the message string unchanged. The function names
> > embedded are removed from the message strings by using __func__ in the next
> > patch of this patchset:
> >
> >    "[PATCH v3 2/5] staging: vme_user: Use __func__ instead of function name"
> >
> > And the warnings go away.
> >
> > Should the tags suggested by this bot be added to [PATCH v3 2/5] in this
> > case?
> 
> I think you can just ignore the bot completely in this case, because you
> already made the changes.

Agreed, this is safe to ignore, thanks.

greg k-h