From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C094612D for ; Sat, 21 Oct 2023 00:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NkuBYpPh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697848368; x=1729384368; h=date:from:to:cc:subject:message-id:mime-version; bh=oafBJ8TdcWdnXY1KxwNoU2WADIyR4knTlKl61GkdiM4=; b=NkuBYpPhpJihWhRqAYNnfwuAps3wNCuyfzzGvqF+0p919bVLpG7G/1Aq svtd7UbLtfgeMZGnHT6IApa0cvlSBpBLW32MzxlkJYwo9CnoYS/Do3XTt cwcuaRqIaf1Gkkin+wzLclFNNEa3JdOQiS0i83Hbq18/imZ4RtjDBYHpS dUPvT3Y3uIn+C77t82k7tVqooKacfsXzQMV80SUI/VoltVQhrTSfbnP39 Ls2zEqCojeLtz1TetWu1INjFIBdXr4bq45nnxprB20TZAgCD0AmJVxTZR kq2UWGspv5bDZQBtpBfYpqmUgTZZJ3vTVx7cZtGUhLrsF1e0yfHsv/Iac Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="365935400" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="365935400" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 17:32:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="931155845" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="931155845" Received: from lkp-server01.sh.intel.com (HELO 8917679a5d3e) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 20 Oct 2023 17:32:37 -0700 Received: from kbuild by 8917679a5d3e with local (Exim 4.96) (envelope-from ) id 1qtzut-0004AG-1h; Sat, 21 Oct 2023 00:32:35 +0000 Date: Sat, 21 Oct 2023 08:32:32 +0800 From: kernel test robot To: Max Filippov Cc: oe-kbuild-all@lists.linux.dev Subject: [jcmvbkbc-xtensa:xtensa-6.6-rc6-esp32 35/43] checkpatch: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 Message-ID: <202310210847.TcKu8ocW-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://github.com/jcmvbkbc/linux-xtensa xtensa-6.6-rc6-esp32 head: 7b60fbaf629519456a4de1b76bf9edfb331ffb50 commit: 2003dcbbb2cbe970e845e24fe570ff1d0b5eff49 [35/43] xtensa: add TRAX support reproduce: (https://download.01.org/0day-ci/archive/20231021/202310210847.TcKu8ocW-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310210847.TcKu8ocW-lkp@intel.com/ # many are suggestions rather than must-fix WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #47: FILE: arch/xtensa/include/asm/trax.h:1: +#ifndef _XTENSA_TRAX_H WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #94: FILE: arch/xtensa/kernel/trax.c:1: +#include ERROR:SPACING: spaces required around that '>' (ctx:OxW) #205: FILE: arch/xtensa/kernel/trax.c:112: + for (i = 100; i --> 0; ) { ^ WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #360: FILE: arch/xtensa/kernel/trax.c:267: +#if 0 WARNING:BRACES: braces {} are not necessary for single statement blocks #551: FILE: arch/xtensa/kernel/trax.c:458: + if (j % 8 && n - i > 8 - j % 8) { + b |= ctx->packet_buffer[j / 8 + 1] << (8 - j % 8); + } WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #602: FILE: arch/xtensa/kernel/trax.c:509: + return false; + } else { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #602: FILE: arch/xtensa/kernel/trax.c:509: + } else { + if (ctx->msg_packet < trax_decode[ctx->msg.type].max_packets && WARNING:TABSTOP: Statements should start on a tabstop #603: FILE: arch/xtensa/kernel/trax.c:510: + if (ctx->msg_packet < trax_decode[ctx->msg.type].max_packets && WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (12, 20) #603: FILE: arch/xtensa/kernel/trax.c:510: + if (ctx->msg_packet < trax_decode[ctx->msg.type].max_packets && [...] + ++ctx->msg_packet; WARNING:TABSTOP: Statements should start on a tabstop #606: FILE: arch/xtensa/kernel/trax.c:513: + return true; WARNING:TABSTOP: Statements should start on a tabstop #607: FILE: arch/xtensa/kernel/trax.c:514: + } else { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (12, 20) #607: FILE: arch/xtensa/kernel/trax.c:514: + } else { + ctx->msg.type = TRAX_MSG_TYPE_UNDEF; WARNING:TABSTOP: Statements should start on a tabstop #610: FILE: arch/xtensa/kernel/trax.c:517: + return false; WARNING:TABSTOP: Statements should start on a tabstop #611: FILE: arch/xtensa/kernel/trax.c:518: + } WARNING:BRACES: braces {} are not necessary for single statement blocks #912: FILE: arch/xtensa/kernel/trax.c:819: + if (pde) { + proc_set_size(pde, trax_state.memsz * 4); + } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki