From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Vincent Fazio <vfazio@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/dependencies: bump minimal tar version to 1.35
Date: Sat, 21 Oct 2023 22:36:18 +0200 [thread overview]
Message-ID: <20231021203618.GE2607@scaer> (raw)
In-Reply-To: <20231021202525.GD2607@scaer>
Vincent, Arnout, All,
On 2023-10-21 22:25 +0200, Yann E. MORIN spake thusly:
> On 2023-10-18 19:43 +0200, Arnout Vandecappelle via buildroot spake thusly:
> > On 18/10/2023 16:11, Vincent Fazio wrote:
> > >GNU tar 1.35 includes a breaking change [0] that changes the tar header
> > >created for each regular file even for "stable" formats like pax (which
> > >we use in support/download/helpers::mk_tar_gz).
[--SNIP--]
> > >diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> > >index e5cd83d859..d33eb2d811 100644
> > >--- a/package/pkg-download.mk
> > >+++ b/package/pkg-download.mk
> > >@@ -20,8 +20,8 @@ export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES))
> > > # Version of the format of the archives we generate in the corresponding
> > > # download backend:
> > >-BR_FMT_VERSION_git = -br1
> > >-BR_FMT_VERSION_svn = -br3
> > >+BR_FMT_VERSION_git = -br2
> > >+BR_FMT_VERSION_svn = -br4
> > Vendored cargo and go packages will have the same issue, no? Those will
> > need to be updated as well...
> Good catch, indeed. I'll try and resurect my patch to add a -br suffix
> to those...
I think it was basically just that:
b/package/pkg-download.mk | 1 1 0 0 +
b/package/pkg-utils.mk | 2 1 1 0 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index e5cd83d859..5ad3f2baaf 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -22,6 +22,7 @@ export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES))
# download backend:
BR_FMT_VERSION_git = -br1
BR_FMT_VERSION_svn = -br3
+BR_FMT_VERSION_cargo = -cargo1
DL_WRAPPER = support/download/dl-wrapper
diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
index 7c670ee615..95a8452db8 100644
--- a/package/pkg-utils.mk
+++ b/package/pkg-utils.mk
@@ -48,7 +48,7 @@ pkgname = $(lastword $(subst /, ,$(pkgdir)))
# Helper to build the extension for a package archive, based on various
# conditions.
# $(1): upper-case package name
-pkg_source_ext = $(BR_FMT_VERSION_$($(1)_SITE_METHOD)).tar.gz
+pkg_source_ext = $(BR_FMT_VERSION_$($(1)_SITE_METHOD))$(BR_FMT_VERSION_$($(1)_DOWNLOAD_POST_PROCESS)).tar.gz
# Define extractors for different archive suffixes
INFLATE.bz2 = $(BZCAT)
Toally untested.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-10-21 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 14:11 [Buildroot] [PATCH 1/1] support/dependencies: bump minimal tar version to 1.35 Vincent Fazio
2023-10-18 17:43 ` Arnout Vandecappelle via buildroot
2023-10-21 20:25 ` Yann E. MORIN
2023-10-21 20:36 ` Yann E. MORIN [this message]
2023-10-23 7:45 ` Arnout Vandecappelle via buildroot
2023-11-08 21:01 ` Arnout Vandecappelle via buildroot
2023-11-09 15:18 ` Vincent Fazio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231021203618.GE2607@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=vfazio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.