All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH printk v1] printk: ringbuffer: Do not skip non-finalized with prb_next_seq()
Date: Sun, 22 Oct 2023 09:14:41 +0800	[thread overview]
Message-ID: <202310220840.5Roikkvq-lkp@intel.com> (raw)
In-Reply-To: <20231019132545.1190490-1-john.ogness@linutronix.de>

Hi John,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on a26f18f291f6c2eac6dac9faa12cc68fd1da5865]

url:    https://github.com/intel-lab-lkp/linux/commits/John-Ogness/printk-ringbuffer-Do-not-skip-non-finalized-with-prb_next_seq/20231019-213147
base:   a26f18f291f6c2eac6dac9faa12cc68fd1da5865
patch link:    https://lore.kernel.org/r/20231019132545.1190490-1-john.ogness%40linutronix.de
patch subject: [RFC PATCH printk v1] printk: ringbuffer: Do not skip non-finalized with prb_next_seq()
config: sh-allnoconfig (https://download.01.org/0day-ci/archive/20231022/202310220840.5Roikkvq-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231022/202310220840.5Roikkvq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310220840.5Roikkvq-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/printk/printk_ringbuffer.c: In function '__ulseq_to_u64seq':
>> kernel/printk/printk_ringbuffer.c:1456:42: error: 'prb' undeclared (first use in this function)
    1456 |         u64 rb_first_seq = prb_first_seq(prb);
         |                                          ^~~
   kernel/printk/printk_ringbuffer.c:1456:42: note: each undeclared identifier is reported only once for each function it appears in


vim +/prb +1456 kernel/printk/printk_ringbuffer.c

  1452	
  1453	#define __u64seq_to_ulseq(u64seq) ((u32)u64seq)
  1454	static inline u64 __ulseq_to_u64seq(u32 ulseq)
  1455	{
> 1456		u64 rb_first_seq = prb_first_seq(prb);
  1457		u64 seq;
  1458	
  1459		/*
  1460		 * The provided sequence is only the lower 32 bits of the ringbuffer
  1461		 * sequence. It needs to be expanded to 64bit. Get the first sequence
  1462		 * number from the ringbuffer and fold it.
  1463		 */
  1464		seq = rb_first_seq - ((u32)rb_first_seq - ulseq);
  1465	
  1466		return seq;
  1467	}
  1468	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2023-10-22  1:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 13:25 [RFC PATCH printk v1] printk: ringbuffer: Do not skip non-finalized with prb_next_seq() John Ogness
2023-10-19 13:39 ` John Ogness
2023-10-22  1:14 ` kernel test robot [this message]
2023-10-25 15:16 ` Petr Mladek
2023-10-26  8:07   ` Petr Mladek
2023-11-02 13:48   ` John Ogness
2023-11-03 12:31     ` Petr Mladek
2023-11-03 13:31       ` John Ogness
2023-11-03 15:58         ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310220840.5Roikkvq-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=john.ogness@linutronix.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.