From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>, Zhangjin Wu <falcon@tinylab.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] selftests/nolibc: anchor paths in $(srcdir) if possible
Date: Sun, 22 Oct 2023 11:22:39 +0200 [thread overview]
Message-ID: <20231022092239.GD2669@1wt.eu> (raw)
In-Reply-To: <20231010-nolibc-out-of-tree-v1-3-b6a263859596@weissschuh.net>
On Tue, Oct 10, 2023 at 02:33:58PM +0200, Thomas Weißschuh wrote:
> It is easier to recognize paths from their well-known location in the
> source tree than having to resolve the relative path in ones head.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> tools/testing/selftests/nolibc/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
> index 258293639572..598d53c5cb7b 100644
> --- a/tools/testing/selftests/nolibc/Makefile
> +++ b/tools/testing/selftests/nolibc/Makefile
> @@ -167,7 +167,7 @@ sysroot: sysroot/$(ARCH)/include
> sysroot/$(ARCH)/include:
> $(Q)rm -rf sysroot/$(ARCH) sysroot/sysroot
> $(QUIET_MKDIR)mkdir -p sysroot
> - $(Q)$(MAKE) -C ../../../include/nolibc ARCH=$(ARCH) OUTPUT=$(CURDIR)/sysroot/ headers_standalone
> + $(Q)$(MAKE) -C $(srctree)/tools/include/nolibc ARCH=$(ARCH) OUTPUT=$(CURDIR)/sysroot/ headers_standalone
> $(Q)mv sysroot/sysroot sysroot/$(ARCH)
>
> ifneq ($(NOLIBC_SYSROOT),0)
> @@ -177,7 +177,7 @@ nolibc-test: nolibc-test.c sysroot/$(ARCH)/include
> else
> nolibc-test: nolibc-test.c
> $(QUIET_CC)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ \
> - -nostdlib -static -include ../../../include/nolibc/nolibc.h $< -lgcc
> + -nostdlib -static -include $(srctree)/tools/include/nolibc/nolibc.h $< -lgcc
> endif
Agreed, this comes from the early days where we didn't have srctree,
that's better this way.
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2023-10-22 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 12:33 [PATCH 0/5] selftests/nolibc: various build improvements Thomas Weißschuh
2023-10-10 12:33 ` [PATCH 1/5] selftests/nolibc: use qemu-system-ppc64 also for ppc64le Thomas Weißschuh
2023-10-10 12:33 ` [PATCH 2/5] selftests/nolibc: use EFI -bios for LoongArch qemu Thomas Weißschuh
2023-10-22 9:20 ` Willy Tarreau
2023-10-24 16:06 ` Thomas Weißschuh
2023-10-24 16:13 ` Willy Tarreau
2023-10-10 12:33 ` [PATCH 3/5] selftests/nolibc: anchor paths in $(srcdir) if possible Thomas Weißschuh
2023-10-22 9:22 ` Willy Tarreau [this message]
2023-10-10 12:33 ` [PATCH 4/5] selftests/nolibc: support out-of-tree builds Thomas Weißschuh
2023-10-22 9:31 ` Willy Tarreau
2023-10-24 16:09 ` Thomas Weißschuh
2023-10-26 17:50 ` Zhangjin Wu
2023-10-10 12:34 ` [PATCH 5/5] selftests/nolibc: generate config automatically Thomas Weißschuh
2023-10-22 9:36 ` Willy Tarreau
2023-10-24 16:17 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022092239.GD2669@1wt.eu \
--to=w@1wt.eu \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.