Re: [RFC PATCH] tools/power turbostat: Do not print negative LPI residency

[kernel test robot <lkp@intel.com>]

Hi Chen,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on acpi/turbostat]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chen-Yu/tools-power-turbostat-Do-not-print-negative-LPI-residency/20231022-135448
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux.git turbostat
patch link:    https://lore.kernel.org/r/20231022055221.569634-1-yu.c.chen%40intel.com
patch subject: [RFC PATCH] tools/power turbostat: Do not print negative LPI residency
reproduce: (https://download.01.org/0day-ci/archive/20231022/202310221511.JAAHk5a1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310221511.JAAHk5a1-lkp@intel.com/

# many are suggestions rather than must-fix

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#38: FILE: tools/power/x86/turbostat/turbostat.c:2046:
+	if (new->cpu_lpi > old->cpu_lpi) {
[...]
+	} else {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#43: FILE: tools/power/x86/turbostat/turbostat.c:2051:
+	if (new->sys_lpi > old->sys_lpi) {
[...]
+	} else {
[...]

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki