From: Simon Horman <horms@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net v2] ravb: Fix races between ravb_tx_timeout_work() and net related ops
Date: Mon, 23 Oct 2023 12:16:54 +0100 [thread overview]
Message-ID: <20231023111654.GW2100445@kernel.org> (raw)
In-Reply-To: <20231019113308.1133944-1-yoshihiro.shimoda.uh@renesas.com>
On Thu, Oct 19, 2023 at 08:33:08PM +0900, Yoshihiro Shimoda wrote:
> Fix races between ravb_tx_timeout_work() and functions of net_device_ops
> and ethtool_ops by using rtnl_trylock() and rtnl_unlock(). Note that
> since ravb_close() is under the rtnl lock and calls cancel_work_sync(),
> ravb_tx_timeout_work() should calls rtnl_trylock(). Otherwise, a deadlock
> may happen in ravb_tx_timeout_work() like below:
>
> CPU0 CPU1
> ravb_tx_timeout()
> schedule_work()
> ...
> __dev_close_many()
> // Under rtnl lock
> ravb_close()
> cancel_work_sync()
> // Waiting
> ravb_tx_timeout_work()
> rtnl_lock()
> // This is possible to cause a deadlock
>
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-10-23 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 11:33 [PATCH net v2] ravb: Fix races between ravb_tx_timeout_work() and net related ops Yoshihiro Shimoda
2023-10-19 12:36 ` Sergey Shtylyov
2023-11-15 2:09 ` Yoshihiro Shimoda
2023-11-15 18:31 ` Sergey Shtylyov
2023-11-16 2:15 ` Yoshihiro Shimoda
2023-11-16 18:11 ` Sergey Shtylyov
2023-11-17 0:07 ` Yoshihiro Shimoda
2023-11-23 17:15 ` Sergey Shtylyov
2023-10-23 11:16 ` Simon Horman [this message]
2023-11-14 8:52 ` Yoshihiro Shimoda
2023-11-14 22:09 ` Jakub Kicinski
2023-11-14 23:48 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023111654.GW2100445@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.