Re: [PATCH 0/3] btrfs: fix a corruption after snapshoting a new subvolume

[Josef Bacik <josef@toxicpanda.com>]

On Thu, Oct 19, 2023 at 01:19:27PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Starting with kernel 6.5, we no longer commit the transaction used to
> create a subvolume when we finish creating the subvolume. This behaviour
> was introduced for performance reasons and done with commit 1b53e51a4a8f
> ("btrfs: don't commit transaction for every subvol create"). However this
> allows for a corruption if we snapshot a subvolume created in the current
> transaction, where basically we get a snapshot root that points to an
> extent buffer that was not written. This makes attempt to read the extent
> buffer later to fail, either with the infamous "parent transid verify
> failed ..." error or with checksum failures.
> 
> More details on the changelog of the first patch, and the remaining patches
> are just cleanups.
> 
> Filipe Manana (3):
>   btrfs: fix unwritten extent buffer after snapshoting a new subvolume
>   btrfs: use bool for return type of btrfs_block_can_be_shared()
>   btrfs: make the logic from btrfs_block_can_be_shared() easier to read
> 

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef