From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 8/8] package/opkg: add sha256sum support
Date: Mon, 23 Oct 2023 19:26:53 +0200 [thread overview]
Message-ID: <20231023172653.GA2607@scaer> (raw)
In-Reply-To: <20231023092501.481436-8-adam.duskett@amarulasolutions.com>
Adam, All,
On 2023-10-23 11:25 +0200, Adam Duskett spake thusly:
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
> package/opkg/Config.in | 5 +++++
> package/opkg/opkg.mk | 6 ++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/package/opkg/Config.in b/package/opkg/Config.in
> index adf39ca145..0104f48623 100644
> --- a/package/opkg/Config.in
> +++ b/package/opkg/Config.in
> @@ -36,6 +36,11 @@ config BR2_PACKAGE_OPKG_GPG_SIGN
> Enable opkg package signature checking support using
> gnupg/libgpgme.
>
> +config BR2_PACKAGE_OPKG_SHA256
> + bool "sha256sum check support"
> + help
> + Enable sha256sum check
There is no reason to make that conditional: the code size increase is
minor, sha1 adn md5 are broken so sha256 is the smallest hash still not
broken, and it has no depenency; so I made it unconditional.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> comment "compression support"
>
> config BR2_PACKAGE_OPKG_BZIP2
> diff --git a/package/opkg/opkg.mk b/package/opkg/opkg.mk
> index 730aa4cfe7..ce0b74f549 100644
> --- a/package/opkg/opkg.mk
> +++ b/package/opkg/opkg.mk
> @@ -38,6 +38,12 @@ else
> OPKG_CONF_OPTS += --disable-gpg
> endif
>
> +ifeq ($(BR2_PACKAGE_OPKG_SHA256),y)
> +OPKG_CONF_OPTS += --enable-sha256
> +else
> +OPKG_CONF_OPTS += --disable-sha256
> +endif
> +
> ifeq ($(BR2_PACKAGE_OPKG_BZIP2),y)
> OPKG_DEPENDENCIES += bzip2
> OPKG_CONF_OPTS += --enable-bzip2
> --
> 2.41.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-10-23 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 9:24 [Buildroot] [PATCH 1/8] package/opkg: bump version to 0.6.2 Adam Duskett
2023-10-23 9:24 ` [Buildroot] [PATCH 2/8] package/opkg-utils: " Adam Duskett
2023-10-23 17:21 ` Yann E. MORIN
2023-10-23 9:24 ` [Buildroot] [PATCH 3/8] package/opkg: add zstd support Adam Duskett
2023-10-23 17:25 ` Yann E. MORIN
2023-10-23 9:24 ` [Buildroot] [PATCH 4/8] package/opkg: add xz suspport Adam Duskett
2023-10-23 9:24 ` [Buildroot] [PATCH 5/8] package/opkg: Add lz4 support Adam Duskett
2023-10-23 9:24 ` [Buildroot] [PATCH 6/8] package/opkg: add bzip2 support Adam Duskett
2023-10-23 9:25 ` [Buildroot] [PATCH 7/8] package/opkg: add curl support Adam Duskett
2023-10-23 9:25 ` [Buildroot] [PATCH 8/8] package/opkg: add sha256sum support Adam Duskett
2023-10-23 17:26 ` Yann E. MORIN [this message]
2023-10-23 17:20 ` [Buildroot] [PATCH 1/8] package/opkg: bump version to 0.6.2 Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023172653.GA2607@scaer \
--to=yann.morin.1998@free.fr \
--cc=adam.duskett@amarulasolutions.com \
--cc=buildroot@buildroot.org \
--cc=thomas.de_schampheleire@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.