From: Denys Dmytriyenko <denis@denix.org>
To: Sai Sree Kartheek Adivi <s-adivi@ti.com>
Cc: meta-arago@lists.yoctoproject.org, praneeth@ti.com,
reatmon@ti.com, c-shilwant@ti.com, a-limaye@ti.com,
g-gupta@ti.com, khasim@ti.com, p-bhagat@ti.com
Subject: Re: [meta-arago][kirkstone][PATCH] matrix-gui: move script from /etc/init.d to data dir.
Date: Mon, 23 Oct 2023 14:09:47 -0400 [thread overview]
Message-ID: <20231023180947.GU2408@denix.org> (raw)
In-Reply-To: <20231022130905.3962948-1-s-adivi@ti.com>
On Sun, Oct 22, 2023 at 06:39:05PM +0530, Sai Sree Kartheek Adivi wrote:
> since sysvinit is deprecated, avoid installing scripts in sysvinit.
> Use data dir to install scripts which need to be called by the systemd services.
Well, sysvinit is not deprecated - it's still an option. With this change
nobody would be able to use Matrix with sysvinit-enabled distro anymore?
A better approach would be to have a dedicated and independent systemd unit
file that doesn't call the sysvinit counterpart. And then make the install
steps below conditional on INIT_MANAGER variable or corresponding flag in the
DISTRO_FEATURES lsit...
> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@ti.com>
> ---
> .../recipes-core/matrix/matrix-gui/matrix-gui-2.0.service | 2 +-
> meta-arago-demos/recipes-core/matrix/matrix-gui_2.0.bb | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta-arago-demos/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service b/meta-arago-demos/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
> index 40a8f0f9..84e9195b 100644
> --- a/meta-arago-demos/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
> +++ b/meta-arago-demos/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
> @@ -12,7 +12,7 @@ IgnoreSIGPIPE=no
> KillMode=process
> GuessMainPID=no
> RemainAfterExit=yes
> -ExecStart=/etc/init.d/matrix-gui-2.0 start
> +ExecStart=/usr/share/matrix-gui-2.0/matrix-gui-2.0 start
>
> [Install]
> WantedBy=multi-user.target
> diff --git a/meta-arago-demos/recipes-core/matrix/matrix-gui_2.0.bb b/meta-arago-demos/recipes-core/matrix/matrix-gui_2.0.bb
> index 9299a929..18ccc0c9 100644
> --- a/meta-arago-demos/recipes-core/matrix/matrix-gui_2.0.bb
> +++ b/meta-arago-demos/recipes-core/matrix/matrix-gui_2.0.bb
> @@ -50,8 +50,7 @@ do_install(){
> sed -i -e "s/__SWITCH_FOREGROUND_VT__/${SWITCH_FOREGROUND_VT}/" ${WORKDIR}/${MATRIX_INITSCRIPT}
>
> # Install the script
> - install -d ${D}${sysconfdir}/init.d
> - install -m 0755 ${WORKDIR}/${MATRIX_INITSCRIPT} ${D}${sysconfdir}/init.d/matrix-gui-2.0
> + install -m 0755 ${WORKDIR}/${MATRIX_INITSCRIPT} ${D}${MATRIX_BASE_DIR}/matrix-gui-2.0
>
> # Install the systemd unit file
> install -d ${D}${systemd_system_unitdir}
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-10-23 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 13:09 [meta-arago][kirkstone][PATCH] matrix-gui: move script from /etc/init.d to data dir Sai Sree Kartheek Adivi
2023-10-23 18:09 ` Denys Dmytriyenko [this message]
2023-10-23 19:36 ` Jon Cormier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023180947.GU2408@denix.org \
--to=denis@denix.org \
--cc=a-limaye@ti.com \
--cc=c-shilwant@ti.com \
--cc=g-gupta@ti.com \
--cc=khasim@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=p-bhagat@ti.com \
--cc=praneeth@ti.com \
--cc=reatmon@ti.com \
--cc=s-adivi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.