From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C1120317 for ; Mon, 23 Oct 2023 18:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VKZotqrz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9937C433C8; Mon, 23 Oct 2023 18:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698086926; bh=cvYxySdgl+SSffKthUQYcmnzcQEhBW8ys75F8wjA2xU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VKZotqrzZy1mTRr7FWkB0d2qDIiiQGAJ9bDjq+VTRDfn+3mivoqDZayOVR4oTcnrN EAYAlAlDg/m724zZLBIEUI4oV4lX77WZFtmmX2bgkv8j3NiArP49fyYjmGLhdxOGrW YCSm13ZhYrH92UNA8Ws1R6a56mCdSOE9GcnaeSW1BCERRL8e+ONx5oGw3IBLQfwS9e vIfG/yJSzcVitPHnM+h7avJB/PLEzShMotgN/aCtSj9cTxE0Hqr//UA4X4AuC9yUYd j5NMZmYoJ52CPpQXFzEuCATDZnW72dFUjYgjNYixYXWYZ8qBBppAsbiLIRhNPrpkvh aqVl+oe4EcOzw== Date: Mon, 23 Oct 2023 11:48:44 -0700 From: Josh Poimboeuf To: Pawan Gupta Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Andy Lutomirski , Jonathan Corbet , Sean Christopherson , Paolo Bonzini , tony.luck@intel.com, ak@linux.intel.com, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Alyssa Milburn , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com Subject: Re: [PATCH 4/6] x86/bugs: Use ALTERNATIVE() instead of mds_user_clear static key Message-ID: <20231023184844.e2loaxlldm4zbko2@treble> References: <20231020-delay-verw-v1-0-cff54096326d@linux.intel.com> <20231020-delay-verw-v1-4-cff54096326d@linux.intel.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231020-delay-verw-v1-4-cff54096326d@linux.intel.com> On Fri, Oct 20, 2023 at 01:45:15PM -0700, Pawan Gupta wrote: > @@ -484,11 +484,11 @@ static void __init md_clear_update_mitigation(void) > if (cpu_mitigations_off()) > return; > > - if (!static_key_enabled(&mds_user_clear)) > + if (!boot_cpu_has(X86_FEATURE_USER_CLEAR_CPU_BUF)) > goto out; > > /* > - * mds_user_clear is now enabled. Update MDS, TAA and MMIO Stale Data > + * X86_FEATURE_USER_CLEAR_CPU_BUF is now enabled. Update MDS, TAA and MMIO Stale Data > * mitigation, if necessary. > */ This comment line got long, the paragraph can be reformatted. -- Josh