All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:pr/642 100/30000] sound/soc/fsl/fsl_spdif.c:765:37: sparse: sparse: Using plain integer as NULL pointer
Date: Tue, 24 Oct 2023 08:38:25 +0800	[thread overview]
Message-ID: <202310240829.0Xb56XJU-lkp@intel.com> (raw)

tree:   https://github.com/Freescale/linux-fslc pr/642
head:   c8b7cf62c7fea8456dec789d550b8006d73b8f04
commit: 960f3f4848db6e2b0b83407e053dd0fed920e60a [100/30000] MLK-19154-3: ASoC: fsl_spdif: Add support for PLL switch at runtime.
config: i386-randconfig-062-20231021 (https://download.01.org/0day-ci/archive/20231024/202310240829.0Xb56XJU-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231024/202310240829.0Xb56XJU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310240829.0Xb56XJU-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> sound/soc/fsl/fsl_spdif.c:765:37: sparse: sparse: Using plain integer as NULL pointer
   sound/soc/fsl/fsl_spdif.c:765:48: sparse: sparse: Using plain integer as NULL pointer

vim +765 sound/soc/fsl/fsl_spdif.c

   758	
   759	static int fsl_spdif_set_dai_sysclk(struct snd_soc_dai *cpu_dai,
   760			int clk_id, unsigned int freq, int dir)
   761	{
   762		struct fsl_spdif_priv *data = snd_soc_dai_get_drvdata(cpu_dai);
   763		struct platform_device *pdev = data->pdev;
   764		struct device *dev = &pdev->dev;
 > 765		struct clk *clk, *p, *pll = 0, *npll = 0;
   766		u64 ratio = freq;
   767		int ret, i;
   768	
   769		if (dir != SND_SOC_CLOCK_OUT || freq == 0 || clk_id != STC_TXCLK_SPDIF_ROOT)
   770			return 0;
   771	
   772		if (data->pll8k_clk == NULL || data->pll11k_clk == NULL)
   773			return 0;
   774	
   775		clk = data->txclk[clk_id];
   776		if (IS_ERR_OR_NULL(clk)) {
   777			dev_err(dev, "no rxtx%d clock in devicetree\n", clk_id);
   778			return PTR_ERR(clk);
   779		}
   780	
   781		p = clk;
   782		while (p && data->pll8k_clk && data->pll11k_clk) {
   783			struct clk *pp = clk_get_parent(p);
   784	
   785			if (clk_is_match(pp, data->pll8k_clk) ||
   786			    clk_is_match(pp, data->pll11k_clk)) {
   787				pll = pp;
   788				break;
   789			}
   790			p = pp;
   791		}
   792	
   793		if (pll) {
   794			npll = (do_div(ratio, 8000) ? data->pll11k_clk : data->pll8k_clk);
   795			if (!clk_is_match(pll, npll)) {
   796				if (!data->streams) {
   797					ret = clk_set_parent(p, npll);
   798					if (ret < 0)
   799						dev_warn(cpu_dai->dev,
   800							"failed to set parent %s: %d\n",
   801							__clk_get_name(npll), ret);
   802				} else {
   803					dev_err(cpu_dai->dev,
   804						"PLL %s is in use by a running stream.\n",
   805						__clk_get_name(pll));
   806					return -EINVAL;
   807				}
   808			}
   809		}
   810	
   811		ret = clk_set_rate(clk, freq);
   812		if (ret < 0) {
   813			dev_err(cpu_dai->dev, "failed to set clock rate (%u): %d\n",
   814				freq, ret);
   815			return ret;
   816		}
   817	
   818		for (i = 0; i < SPDIF_TXRATE_MAX; i++) {
   819			ret = fsl_spdif_probe_txclk(data, i);
   820			if (ret)
   821				return ret;
   822		}
   823	
   824		return 0;
   825	}
   826	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2023-10-24  0:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24  0:38 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-11-12  7:27 [freescale-fslc:pr/642 100/30000] sound/soc/fsl/fsl_spdif.c:765:37: sparse: sparse: Using plain integer as NULL pointer kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310240829.0Xb56XJU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.