All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/doc: describe PATH format for DP MST
Date: Tue, 24 Oct 2023 10:36:04 +0300	[thread overview]
Message-ID: <20231024103604.6dd7f6d5@eldfell> (raw)
In-Reply-To: <20231023203629.198109-1-contact@emersion.fr>

[-- Attachment #1: Type: text/plain, Size: 2143 bytes --]

On Mon, 23 Oct 2023 20:36:39 +0000
Simon Ser <contact@emersion.fr> wrote:

> This is already uAPI, xserver parses it. It's useful to document
> since user-space might want to lookup the parent connector.
> 
> Additionally, people (me included) have misunderstood the PATH
> property for being stable across reboots, but since a KMS object
> ID is baked in there that's not the case. So PATH shouldn't be
> used as-is in config files and such.
> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Pekka Paalanen <pekka.paalanen@collabora.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/drm_connector.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index c3725086f413..392bec1355a3 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -1198,6 +1198,11 @@ static const u32 dp_colorspaces =
>   * 	drm_connector_set_path_property(), in the case of DP MST with the
>   * 	path property the MST manager created. Userspace cannot change this
>   * 	property.
> + *
> + * 	In the case of DP MST, the property has the format
> + * 	``mst:<parent>-<ports>`` where ``<parent>`` is the KMS object ID of the
> + * 	parent connector and ``<ports>`` is a hyphen-separated list of DP MST
> + * 	port numbers. Note, KMS object IDs are not stable across reboots.
>   * TILE:
>   * 	Connector tile group property to indicate how a set of DRM connector
>   * 	compose together into one logical screen. This is used by both high-res

Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>

with or without the suggested "guaranteed" wording.

Are DP MST port numbers guaranteed to be tied to the physical hardware
configuration (e.g. how cables are connected) and therefore stable
across reboots? What about stable across kernel upgrades?

If I knew that, I could perhaps manufacture a stable identifier in
userspace by replacing the parent connector ID with a stable connector
designator.


Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2023-10-24  7:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 20:36 [PATCH] drm/doc: describe PATH format for DP MST Simon Ser
2023-10-23 21:32 ` Dmitry Baryshkov
2023-10-24  7:36 ` Pekka Paalanen [this message]
2023-10-24  9:03   ` Simon Ser
2023-10-24 13:03     ` Ville Syrjälä
2023-10-24 13:12       ` Pekka Paalanen
2023-10-24 13:37         ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024103604.6dd7f6d5@eldfell \
    --to=ppaalanen@gmail.com \
    --cc=contact@emersion.fr \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=wayland-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.