From: Detlev Casanova <detlev.casanova@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org,
Daniel Almeida <daniel.almeida@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Detlev Casanova <detlev.casanova@collabora.com>
Subject: [PATCH v2 1/5] media: visl: Fix params permissions/defaults mismatch
Date: Tue, 24 Oct 2023 15:09:46 -0400 [thread overview]
Message-ID: <20231024191027.305622-2-detlev.casanova@collabora.com> (raw)
In-Reply-To: <20231024191027.305622-1-detlev.casanova@collabora.com>
`false` was used as the keep_bitstream_buffers parameter permissions.
This looks more like a default value for the parameter, so change it to
0 to avoid confusion.
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
drivers/media/test-drivers/visl/visl-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/test-drivers/visl/visl-core.c
index 9970dc739ca5..df6515530fbf 100644
--- a/drivers/media/test-drivers/visl/visl-core.c
+++ b/drivers/media/test-drivers/visl/visl-core.c
@@ -74,7 +74,7 @@ MODULE_PARM_DESC(visl_dprintk_nframes,
" the number of frames to trace with dprintk");
bool keep_bitstream_buffers;
-module_param(keep_bitstream_buffers, bool, false);
+module_param(keep_bitstream_buffers, bool, 0);
MODULE_PARM_DESC(keep_bitstream_buffers,
" keep bitstream buffers in debugfs after streaming is stopped");
--
2.41.0
next prev parent reply other threads:[~2023-10-24 19:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 19:09 [PATCH v2 0/5] visl: Adapt output frames for reference comparison Detlev Casanova
2023-10-24 19:09 ` Detlev Casanova [this message]
2023-11-22 15:56 ` [PATCH v2 1/5] media: visl: Fix params permissions/defaults mismatch Hans Verkuil
2023-11-22 16:38 ` Detlev Casanova
2023-11-23 8:41 ` Hans Verkuil
2023-10-24 19:09 ` [PATCH v2 2/5] media: visl: Add a stable_output parameter Detlev Casanova
2023-11-22 16:03 ` Hans Verkuil
2023-11-22 16:49 ` Detlev Casanova
2023-11-23 8:44 ` Hans Verkuil
2023-10-24 19:09 ` [PATCH v2 3/5] doc: visl: Document " Detlev Casanova
2023-10-24 19:09 ` [PATCH v2 4/5] visl: Add a codec specific variability parameter Detlev Casanova
2023-11-22 16:07 ` Hans Verkuil
2023-11-22 16:52 ` Detlev Casanova
2023-10-24 19:09 ` [PATCH v2 5/5] doc: visl: Document codec_variability parameter Detlev Casanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024191027.305622-2-detlev.casanova@collabora.com \
--to=detlev.casanova@collabora.com \
--cc=daniel.almeida@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.