From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CA3C00A8F for ; Tue, 24 Oct 2023 19:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344165AbjJXTPx (ORCPT ); Tue, 24 Oct 2023 15:15:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344021AbjJXTPw (ORCPT ); Tue, 24 Oct 2023 15:15:52 -0400 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 631C1109; Tue, 24 Oct 2023 12:15:50 -0700 (PDT) Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3b2ea7cc821so3393621b6e.1; Tue, 24 Oct 2023 12:15:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698174949; x=1698779749; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fc7wsu+Ez53X61VDpaWVir82UtYO/AqwmwLE+WTcs7o=; b=Ympkgw82amTwWMA7C8Sh93ah33FrMYi8aLpgaRRRxltyRb6tJuNXWzFUQ2B/YHuBel 6hACTWs9dHYkLHdHUyHNsqIPe82p5aGezlWKBF5jwaY58ojq6TXFiOXatAccCWQOAUx4 GdqEcuVCCw+7LffSEYWCATvmnxATyBL83wLjUomtjrpQNGTMGXYlYhRPESuq8ac+cKbl tBPkU6qQm/rxDtrBRhut/gNDb8wOuZSi7JU+5JGW98oB5z1fAQY2UGC0aJ2WcND3aJ1L GDr2TnpYi9jS1e42iQJo2Pr+CWtR/4pP6896cCDifvf5zMWbyqM88RUlyDCNOAVwuPzM HK0A== X-Gm-Message-State: AOJu0YwUHxZTgUE3Hzulnered2bHQrQQf69XVjCcVx6crwRjcjRnGKEq 5D/YVjURPn80iv/GK2/GyA== X-Google-Smtp-Source: AGHT+IER1+W8thq+jVs5LXcjlTIf2E/TkcDrEDQn3qMEpjU+x8WiOWdAZMsl5sTg8R2Hr324uf0jDg== X-Received: by 2002:a05:6808:181:b0:3ab:8574:e8ab with SMTP id w1-20020a056808018100b003ab8574e8abmr14532474oic.21.1698174949695; Tue, 24 Oct 2023 12:15:49 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j5-20020a056830270500b006ce46212341sm1399103otu.54.2023.10.24.12.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:15:49 -0700 (PDT) Received: (nullmailer pid 403998 invoked by uid 1000); Tue, 24 Oct 2023 19:15:48 -0000 Date: Tue, 24 Oct 2023 14:15:48 -0500 From: Rob Herring To: Oreoluwa Babatunde Cc: catalin.marinas@arm.com, will@kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@quicinc.com Subject: Re: [RFC PATCH 1/3] of: reserved_mem: Change the order that reserved_mem regions are stored Message-ID: <20231024191548.GA358703-robh@kernel.org> References: <20231019184825.9712-1-quic_obabatun@quicinc.com> <20231019184825.9712-2-quic_obabatun@quicinc.com> <7e6ddffc-81a5-4183-9e59-7060776c936a@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e6ddffc-81a5-4183-9e59-7060776c936a@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Oct 19, 2023 at 03:45:37PM -0700, Oreoluwa Babatunde wrote: > > On 10/19/2023 12:46 PM, Rob Herring wrote: > > On Thu, Oct 19, 2023 at 1:49 PM Oreoluwa Babatunde > > wrote: > >> The dynamic allocation of the reserved_mem array needs to be done after > >> paging_init() is called because memory allocated using memblock_alloc() > >> is not writeable before that. > >> --- a/arch/arm64/kernel/setup.c > >> +++ b/arch/arm64/kernel/setup.c > >> @@ -27,6 +27,8 @@ > >> #include > >> #include > >> #include > >> +#include > >> + > >> #include > >> #include > >> #include > >> @@ -346,6 +348,8 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > >> > >> paging_init(); > >> > >> + fdt_init_reserved_mem(); > >> + > > You removed this call from the common code and add it to arm64 arch > > code, doesn't that break every other arch? > Yes, the same changes will be needed for every other arch. I was hoping to > get some feedback on the RFC before implementing this on other archs which > is why the change is currently only in arm64. > > The very next thing done here is unflattening the DT. So another call > > from the arch code to the DT code isn't needed either. > Yes, I see that unflatten_device_tree() is being called right after here. > Just to clarify, are you suggesting to move fdt_init_reserved_mem() into the > unflatten_device_tree() call? In general, I want fewer calls between arch code and DT core and for the DT core to be more in control of the ordering that things happen. Your series does the opposite. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D458C07545 for ; Tue, 24 Oct 2023 19:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kicAFJyy+Rf+q4qHbUvkK7HXfxfQAGDn14ljSZPcSvM=; b=BfGZ7Y17QpOtof Gtq2u3Da7g6fU7BkXjlb/sN5FToxcsdSTWvcx2Hcic/lGgRhYn58/hvVnbocA8lxl45wbAE7pxeWo OKhR7GJCsQLm+9LYeg9piyASJ45t3CmQ8owy/f7gxqo8GrDbh4WlBwzix/ArmjkXX0dOOAfKYpu5V CxUF2aMnv8UrqKRZIOwVbWwm7BvPUnDloQDqBzEdIbQQNN1s2MkvlrvBHOT+xjPHHjLF8UTGtJ15A IQkKzYFTCsPVVtsajyB1eSyydMwxqKWMsGWPzDbT4bK1TwGDlZcaxZ7EE9FVzjhkrFYbQ1vIbwh04 lDC4ecIMtDej1eBZInLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvMsd-00Ajmq-1B; Tue, 24 Oct 2023 19:15:55 +0000 Received: from mail-ot1-f46.google.com ([209.85.210.46]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvMsa-00AjmL-0C for linux-arm-kernel@lists.infradead.org; Tue, 24 Oct 2023 19:15:53 +0000 Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6cd09663b1cso2963899a34.3 for ; Tue, 24 Oct 2023 12:15:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698174949; x=1698779749; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fc7wsu+Ez53X61VDpaWVir82UtYO/AqwmwLE+WTcs7o=; b=CehbN4xG1LmwX4zFw/ISGlEtns66MzGLkZnXDv7BzKvoWYzpkUJVT2JR0yX4NnhA/j sMgyEmhNkCg+vfuMa6OP5t4nCrPIauPdK1yPysfMQMl4F86fU6NvE2NZnfCPjuBNI87G qr23jH5LU9fdQ/ylLssB0MAjq02wD7687eOyX6tKCCgBMtcfnlFyBEgdPPPtKMQlQby2 KpSLP3LUfoOnMdnTUIV65I+HAbOseRBsknCglGzLYX+/F09veCKO66RY4I+rvy3dp5nu 7T7tfA95ofoCz1jR0rDKFoTP293EdHsYLtdCpYIXT/geoL7iWCgrRkKpo22JBfqJ8rAU YVKA== X-Gm-Message-State: AOJu0YxlwLHZ/TzOxHA7UC4NGJ79N/+2WcdusTRhCnJoaOO79cEEkJfx OeGxkOLibxpYlYGPgLZx7A== X-Google-Smtp-Source: AGHT+IER1+W8thq+jVs5LXcjlTIf2E/TkcDrEDQn3qMEpjU+x8WiOWdAZMsl5sTg8R2Hr324uf0jDg== X-Received: by 2002:a05:6808:181:b0:3ab:8574:e8ab with SMTP id w1-20020a056808018100b003ab8574e8abmr14532474oic.21.1698174949695; Tue, 24 Oct 2023 12:15:49 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j5-20020a056830270500b006ce46212341sm1399103otu.54.2023.10.24.12.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:15:49 -0700 (PDT) Received: (nullmailer pid 403998 invoked by uid 1000); Tue, 24 Oct 2023 19:15:48 -0000 Date: Tue, 24 Oct 2023 14:15:48 -0500 From: Rob Herring To: Oreoluwa Babatunde Cc: catalin.marinas@arm.com, will@kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@quicinc.com Subject: Re: [RFC PATCH 1/3] of: reserved_mem: Change the order that reserved_mem regions are stored Message-ID: <20231024191548.GA358703-robh@kernel.org> References: <20231019184825.9712-1-quic_obabatun@quicinc.com> <20231019184825.9712-2-quic_obabatun@quicinc.com> <7e6ddffc-81a5-4183-9e59-7060776c936a@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7e6ddffc-81a5-4183-9e59-7060776c936a@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_121552_120478_803C025A X-CRM114-Status: GOOD ( 21.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMTksIDIwMjMgYXQgMDM6NDU6MzdQTSAtMDcwMCwgT3Jlb2x1d2EgQmFiYXR1 bmRlIHdyb3RlOgo+IAo+IE9uIDEwLzE5LzIwMjMgMTI6NDYgUE0sIFJvYiBIZXJyaW5nIHdyb3Rl Ogo+ID4gT24gVGh1LCBPY3QgMTksIDIwMjMgYXQgMTo0OeKAr1BNIE9yZW9sdXdhIEJhYmF0dW5k ZQo+ID4gPHF1aWNfb2JhYmF0dW5AcXVpY2luYy5jb20+IHdyb3RlOgo+ID4+IFRoZSBkeW5hbWlj IGFsbG9jYXRpb24gb2YgdGhlIHJlc2VydmVkX21lbSBhcnJheSBuZWVkcyB0byBiZSBkb25lIGFm dGVyCj4gPj4gcGFnaW5nX2luaXQoKSBpcyBjYWxsZWQgYmVjYXVzZSBtZW1vcnkgYWxsb2NhdGVk IHVzaW5nIG1lbWJsb2NrX2FsbG9jKCkKPiA+PiBpcyBub3Qgd3JpdGVhYmxlIGJlZm9yZSB0aGF0 LgoKCj4gPj4gLS0tIGEvYXJjaC9hcm02NC9rZXJuZWwvc2V0dXAuYwo+ID4+ICsrKyBiL2FyY2gv YXJtNjQva2VybmVsL3NldHVwLmMKPiA+PiBAQCAtMjcsNiArMjcsOCBAQAo+ID4+ICAjaW5jbHVk ZSA8bGludXgvcHJvY19mcy5oPgo+ID4+ICAjaW5jbHVkZSA8bGludXgvbWVtYmxvY2suaD4KPiA+ PiAgI2luY2x1ZGUgPGxpbnV4L29mX2ZkdC5oPgo+ID4+ICsjaW5jbHVkZSA8bGludXgvb2ZfcmVz ZXJ2ZWRfbWVtLmg+Cj4gPj4gKwo+ID4+ICAjaW5jbHVkZSA8bGludXgvZWZpLmg+Cj4gPj4gICNp bmNsdWRlIDxsaW51eC9wc2NpLmg+Cj4gPj4gICNpbmNsdWRlIDxsaW51eC9zY2hlZC90YXNrLmg+ Cj4gPj4gQEAgLTM0Niw2ICszNDgsOCBAQCB2b2lkIF9faW5pdCBfX25vX3Nhbml0aXplX2FkZHJl c3Mgc2V0dXBfYXJjaChjaGFyICoqY21kbGluZV9wKQo+ID4+Cj4gPj4gICAgICAgICBwYWdpbmdf aW5pdCgpOwo+ID4+Cj4gPj4gKyAgICAgICBmZHRfaW5pdF9yZXNlcnZlZF9tZW0oKTsKPiA+PiAr Cj4gPiBZb3UgcmVtb3ZlZCB0aGlzIGNhbGwgZnJvbSB0aGUgY29tbW9uIGNvZGUgYW5kIGFkZCBp dCB0byBhcm02NCBhcmNoCj4gPiBjb2RlLCBkb2Vzbid0IHRoYXQgYnJlYWsgZXZlcnkgb3RoZXIg YXJjaD8KPiBZZXMsIHRoZSBzYW1lIGNoYW5nZXMgd2lsbCBiZSBuZWVkZWQgZm9yIGV2ZXJ5IG90 aGVyIGFyY2guIEkgd2FzIGhvcGluZyB0bwo+IGdldCBzb21lIGZlZWRiYWNrIG9uIHRoZSBSRkMg YmVmb3JlIGltcGxlbWVudGluZyB0aGlzIG9uIG90aGVyIGFyY2hzIHdoaWNoCj4gaXMgd2h5IHRo ZSBjaGFuZ2UgaXMgY3VycmVudGx5IG9ubHkgaW4gYXJtNjQuCj4gPiBUaGUgdmVyeSBuZXh0IHRo aW5nIGRvbmUgaGVyZSBpcyB1bmZsYXR0ZW5pbmcgdGhlIERULiBTbyBhbm90aGVyIGNhbGwKPiA+ IGZyb20gdGhlIGFyY2ggY29kZSB0byB0aGUgRFQgY29kZSBpc24ndCBuZWVkZWQgZWl0aGVyLgo+ IFllcywgSSBzZWUgdGhhdCB1bmZsYXR0ZW5fZGV2aWNlX3RyZWUoKSBpcyBiZWluZyBjYWxsZWQg cmlnaHQgYWZ0ZXIgaGVyZS4KPiBKdXN0IHRvIGNsYXJpZnksIGFyZSB5b3Ugc3VnZ2VzdGluZyB0 byBtb3ZlIGZkdF9pbml0X3Jlc2VydmVkX21lbSgpIGludG8gdGhlCj4gdW5mbGF0dGVuX2Rldmlj ZV90cmVlKCkgY2FsbD8KCkluIGdlbmVyYWwsIEkgd2FudCBmZXdlciBjYWxscyBiZXR3ZWVuIGFy Y2ggY29kZSBhbmQgRFQgY29yZSBhbmQgZm9yIHRoZSAKRFQgY29yZSB0byBiZSBtb3JlIGluIGNv bnRyb2wgb2YgdGhlIG9yZGVyaW5nIHRoYXQgdGhpbmdzIGhhcHBlbi4gWW91ciAKc2VyaWVzIGRv ZXMgdGhlIG9wcG9zaXRlLgoKUm9iCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==