All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Andrey Skvortsov <andrej.skvortzov@gmail.com>
Cc: "Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Jarrah Gosbell" <kernel@undef.tools>,
	"Arnaud Ferraris" <arnaud.ferraris@collabora.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Andre Przywara" <andre.przywara@arm.com>,
	u-boot@lists.denx.de,
	"Detlev Casanova" <detlev.casanova@collabora.com>,
	"Frédéric Danis" <frederic.danis@collabora.com>
Subject: Re: [PATCH] pstore: Use root address-cells/size-cells as defaults for reserved-memory
Date: Tue, 24 Oct 2023 19:16:39 -0400	[thread overview]
Message-ID: <20231024231639.GZ496310@bill-the-cat> (raw)
In-Reply-To: <20230826121652.2487643-1-andrej.skvortzov@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On Sat, Aug 26, 2023 at 03:16:52PM +0300, Andrey Skvortsov wrote:

> u-boot adds reserve-memory node, if it's missing, with following
> properties:
> 
> ```
>     reserved-memory {
>          #address-cells = <2>;
>          #size-cells = <2>;
>          ranges;
>     }
> ```
> 
> But with these default address-cells and size-cells values, pstore
> isn't working on A64. Root node for A64 defines 'address-cells' and
> 'size-cells' as 1.
> 
> dtc complains if reserved-memory has different address-cells and
> size-cells.
> 
> ```
>      Warning (ranges_format): /reserved-memory:ranges: empty "ranges"
>      property but its #address-cells (2) differs from / (1)
> ```
> 
> This patch takes into account address-cells and size-cells of the root
> node and uses them as values for new reserved-memory node.
> 
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

      parent reply	other threads:[~2023-10-24 23:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-26 12:16 [PATCH] pstore: Use root address-cells/size-cells as defaults for reserved-memory Andrey Skvortsov
2023-08-26 13:10 ` Heinrich Schuchardt
2023-08-26 18:41   ` Andre Przywara
2023-10-16 12:23     ` Andrey Skvortsov
2023-08-26 20:06   ` Andrey Skvortsov
2023-10-24 23:16 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024231639.GZ496310@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=andre.przywara@arm.com \
    --cc=andrej.skvortzov@gmail.com \
    --cc=arnaud.ferraris@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=frederic.danis@collabora.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=kernel@undef.tools \
    --cc=pavel@ucw.cz \
    --cc=samuel@sholland.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.