From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85017C0032E for ; Wed, 25 Oct 2023 07:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232224AbjJYHwj (ORCPT ); Wed, 25 Oct 2023 03:52:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231467AbjJYHwj (ORCPT ); Wed, 25 Oct 2023 03:52:39 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C04FDE; Wed, 25 Oct 2023 00:52:36 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93E63C433C7; Wed, 25 Oct 2023 07:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698220355; bh=AjvHbivfFAj4feaP3aHyTgho0kLeTTMjqn0xHKJqObY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Au1eplrqt71V0W8QiBWNe2G4Yt1Oo5Nwe1X9M5FenWXHtTYUyb207aW2LFGcyCWhS zV7j5ngxfjrhePd3EDD3Jm+6rbJM4NaiyRax0zGFz4DBTz+PHXLLknRC2YjWVpJ3Oy jXEp0aJZYsV8DWK0QjVwU1724Ebqkh7EtBUXSTt7FTqH4r8c7cl33Osn2PGke1fPtn LXj9gnwfXVYYHR9uRm8ne146V2qe1GEJ+lrc+a5S49DyJncP47JS5D87NUURR60Mzn hbNMX2JBySi4GYlW9fExrNPnywHtX69EINNWbSk+YzS7o4Tnyl81i4FMjg4bcz4fKS b0ZDKaaj0dTTw== Date: Wed, 25 Oct 2023 13:22:24 +0530 From: Manivannan Sadhasivam To: Mrinmay Sarkar Cc: agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, dmitry.baryshkov@linaro.org, robh@kernel.org, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, quic_parass@quicinc.com, Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Kishon Vijay Abraham I , Vinod Koul , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-phy@lists.infradead.org Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: sa8775p: Add ep pcie0 controller node Message-ID: <20231025075224.GB3648@thinkpad> References: <1697715430-30820-1-git-send-email-quic_msarkar@quicinc.com> <1697715430-30820-6-git-send-email-quic_msarkar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1697715430-30820-6-git-send-email-quic_msarkar@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Oct 19, 2023 at 05:07:10PM +0530, Mrinmay Sarkar wrote: > Add ep pcie dtsi node for pcie0 controller found on sa8775p platform. > It supports gen4 and x2 link width. Due to some stability issue in > gen4 enabling gen3 as of now. > > Signed-off-by: Mrinmay Sarkar > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 48 +++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 13dd44d..2aa7383 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -3714,4 +3714,52 @@ > > status = "disabled"; > }; > + > + pcie0_ep: pcie-ep@1c00000 { > + compatible = "qcom,sa8775p-pcie-ep"; > + reg = <0x0 0x01c00000 0x0 0x3000>, > + <0x0 0x40000000 0x0 0xf20>, > + <0x0 0x40000f20 0x0 0xa8>, > + <0x0 0x40001000 0x0 0x4000>, > + <0x0 0x40200000 0x0 0x100000>, > + <0x0 0x01c03000 0x0 0x1000>, > + <0x0 0x40005000 0x0 0x2000>; Can we sort the reg entries? > + reg-names = "parf", "dbi", "elbi", "atu", "addr_space", > + "mmio", "dma"; > + > + clocks = <&gcc GCC_PCIE_0_AUX_CLK>, > + <&gcc GCC_PCIE_0_CFG_AHB_CLK>, > + <&gcc GCC_PCIE_0_MSTR_AXI_CLK>, > + <&gcc GCC_PCIE_0_SLV_AXI_CLK>, > + <&gcc GCC_PCIE_0_SLV_Q2A_AXI_CLK>; > + > + clock-names = "aux", > + "cfg", > + "bus_master", > + "bus_slave", > + "slave_q2a"; > + > + interrupts = , > + , > + ; > + > + interrupt-names = "global", "doorbell", "dma"; > + > + interconnects = <&pcie_anoc MASTER_PCIE_0 0 &mc_virt SLAVE_EBI1 0>, > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; > + interconnect-names = "pcie-mem", "cpu-pcie"; > + > + iommu-map = <0x0 &pcie_smmu 0x0000 0x1>, > + <0x100 &pcie_smmu 0x0001 0x1>; I think I recommended using "iommu-map" instead of "iommus" property. But looking at it again, I think it is fine to use just "iommus" property as the SID will be associated with the EP directly. Unless you want to have different SID for each function. > + > + resets = <&gcc GCC_PCIE_0_BCR>; > + reset-names = "core"; > + power-domains = <&gcc PCIE_0_GDSC>; > + phys = <&pcie0_phy>; > + phy-names = "pciephy"; > + max-link-speed = <3>; Please add a comment here that you are limiting the Gen speed due to stability issues. Like, max-link-speed = <3>; /* FIXME: Limiting the Gen speed due to stability issues */ > + num-lanes = <2>; Can you check if the controller is cache coherent? If so, we should add "dma-coherent" property. - Mani > + > + status = "disabled"; > + }; > }; > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 138C9C25B6E for ; Wed, 25 Oct 2023 07:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y9DkN0Gi9CtxmEw5uLuzuhKiJXnuJcy9jT6n0/Xlkks=; b=Wo2XjoG9o+fxwj R4u1QOxrH78K+WG/kcFZ26X/8LeSseiZJ/ARY9GwK+j0pKkz8gRxqUUB6YQnEesV8JFvy5JDs3kRk mUNFohIIO6wBW3bhl+idwa4O0gBkd9LLvG7UeswyjS/H9M0oA+c/EVVhkaAVm6ZFr/nK9mGYYQg+0 eOmjpv/KTULDHZBoauCsO3jkrOVEpRIe/8lei6fupHnYXibhyTHghe/PFop524bNjDIJao1fd7OjG BAA68LpXC6T0x5UszpRkrly8gsSyu+Y+dDdLvtYiN0Eb/2KcBj7g//CPo5fDkkFUJbkrLzLstCKu9 zNQqvFT/j/GV5F13ZkYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvYgz-00Bcbm-2V; Wed, 25 Oct 2023 07:52:41 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvYgw-00Bca9-14 for linux-phy@lists.infradead.org; Wed, 25 Oct 2023 07:52:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 4A59FB821BB; Wed, 25 Oct 2023 07:52:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93E63C433C7; Wed, 25 Oct 2023 07:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698220355; bh=AjvHbivfFAj4feaP3aHyTgho0kLeTTMjqn0xHKJqObY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Au1eplrqt71V0W8QiBWNe2G4Yt1Oo5Nwe1X9M5FenWXHtTYUyb207aW2LFGcyCWhS zV7j5ngxfjrhePd3EDD3Jm+6rbJM4NaiyRax0zGFz4DBTz+PHXLLknRC2YjWVpJ3Oy jXEp0aJZYsV8DWK0QjVwU1724Ebqkh7EtBUXSTt7FTqH4r8c7cl33Osn2PGke1fPtn LXj9gnwfXVYYHR9uRm8ne146V2qe1GEJ+lrc+a5S49DyJncP47JS5D87NUURR60Mzn hbNMX2JBySi4GYlW9fExrNPnywHtX69EINNWbSk+YzS7o4Tnyl81i4FMjg4bcz4fKS b0ZDKaaj0dTTw== Date: Wed, 25 Oct 2023 13:22:24 +0530 From: Manivannan Sadhasivam To: Mrinmay Sarkar Cc: agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, dmitry.baryshkov@linaro.org, robh@kernel.org, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, quic_parass@quicinc.com, Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Kishon Vijay Abraham I , Vinod Koul , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-phy@lists.infradead.org Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: sa8775p: Add ep pcie0 controller node Message-ID: <20231025075224.GB3648@thinkpad> References: <1697715430-30820-1-git-send-email-quic_msarkar@quicinc.com> <1697715430-30820-6-git-send-email-quic_msarkar@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1697715430-30820-6-git-send-email-quic_msarkar@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_005238_657483_2C7A5874 X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMTksIDIwMjMgYXQgMDU6MDc6MTBQTSArMDUzMCwgTXJpbm1heSBTYXJrYXIg d3JvdGU6Cj4gQWRkIGVwIHBjaWUgZHRzaSBub2RlIGZvciBwY2llMCBjb250cm9sbGVyIGZvdW5k IG9uIHNhODc3NXAgcGxhdGZvcm0uCj4gSXQgc3VwcG9ydHMgZ2VuNCBhbmQgeDIgbGluayB3aWR0 aC4gRHVlIHRvIHNvbWUgc3RhYmlsaXR5IGlzc3VlIGluCj4gZ2VuNCBlbmFibGluZyBnZW4zIGFz IG9mIG5vdy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNcmlubWF5IFNhcmthciA8cXVpY19tc2Fya2Fy QHF1aWNpbmMuY29tPgo+IC0tLQo+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20vc2E4Nzc1cC5k dHNpIHwgNDggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNo YW5nZWQsIDQ4IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290 L2R0cy9xY29tL3NhODc3NXAuZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9zYTg3NzVw LmR0c2kKPiBpbmRleCAxM2RkNDRkLi4yYWE3MzgzIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQv Ym9vdC9kdHMvcWNvbS9zYTg3NzVwLmR0c2kKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fj b20vc2E4Nzc1cC5kdHNpCj4gQEAgLTM3MTQsNCArMzcxNCw1MiBAQAo+ICAKPiAgCQlzdGF0dXMg PSAiZGlzYWJsZWQiOwo+ICAJfTsKPiArCj4gKwlwY2llMF9lcDogcGNpZS1lcEAxYzAwMDAwIHsK PiArCQljb21wYXRpYmxlID0gInFjb20sc2E4Nzc1cC1wY2llLWVwIjsKPiArCQlyZWcgPSA8MHgw IDB4MDFjMDAwMDAgMHgwIDB4MzAwMD4sCj4gKwkJICAgICAgPDB4MCAweDQwMDAwMDAwIDB4MCAw eGYyMD4sCj4gKwkJICAgICAgPDB4MCAweDQwMDAwZjIwIDB4MCAweGE4PiwKPiArCQkgICAgICA8 MHgwIDB4NDAwMDEwMDAgMHgwIDB4NDAwMD4sCj4gKwkJICAgICAgPDB4MCAweDQwMjAwMDAwIDB4 MCAweDEwMDAwMD4sCj4gKwkJICAgICAgPDB4MCAweDAxYzAzMDAwIDB4MCAweDEwMDA+LAo+ICsJ CSAgICAgIDwweDAgMHg0MDAwNTAwMCAweDAgMHgyMDAwPjsKCkNhbiB3ZSBzb3J0IHRoZSByZWcg ZW50cmllcz8KCj4gKwkJcmVnLW5hbWVzID0gInBhcmYiLCAiZGJpIiwgImVsYmkiLCAiYXR1Iiwg ImFkZHJfc3BhY2UiLAo+ICsJCQkgICAgIm1taW8iLCAiZG1hIjsKPiArCj4gKwkJY2xvY2tzID0g PCZnY2MgR0NDX1BDSUVfMF9BVVhfQ0xLPiwKPiArCQkJPCZnY2MgR0NDX1BDSUVfMF9DRkdfQUhC X0NMSz4sCj4gKwkJCTwmZ2NjIEdDQ19QQ0lFXzBfTVNUUl9BWElfQ0xLPiwKPiArCQkJPCZnY2Mg R0NDX1BDSUVfMF9TTFZfQVhJX0NMSz4sCj4gKwkJCTwmZ2NjIEdDQ19QQ0lFXzBfU0xWX1EyQV9B WElfQ0xLPjsKPiArCj4gKwkJY2xvY2stbmFtZXMgPSAiYXV4IiwKPiArCQkJICAgICAgImNmZyIs Cj4gKwkJCSAgICAgICJidXNfbWFzdGVyIiwKPiArCQkJICAgICAgImJ1c19zbGF2ZSIsCj4gKwkJ CSAgICAgICJzbGF2ZV9xMmEiOwo+ICsKPiArCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMzA2IElS UV9UWVBFX0xFVkVMX0hJR0g+LAo+ICsJCQkgICAgIDxHSUNfU1BJIDE0NyBJUlFfVFlQRV9MRVZF TF9ISUdIPiwKPiArCQkJICAgICA8R0lDX1NQSSA2MzAgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4g Kwo+ICsJCWludGVycnVwdC1uYW1lcyA9ICJnbG9iYWwiLCAiZG9vcmJlbGwiLCAiZG1hIjsKPiAr Cj4gKwkJaW50ZXJjb25uZWN0cyA9IDwmcGNpZV9hbm9jIE1BU1RFUl9QQ0lFXzAgMCAmbWNfdmly dCBTTEFWRV9FQkkxIDA+LAo+ICsJCQkJPCZnZW1fbm9jIE1BU1RFUl9BUFBTU19QUk9DIDAgJmNv bmZpZ19ub2MgU0xBVkVfUENJRV8wIDA+Owo+ICsJCWludGVyY29ubmVjdC1uYW1lcyA9ICJwY2ll LW1lbSIsICJjcHUtcGNpZSI7Cj4gKwo+ICsJCWlvbW11LW1hcCA9IDwweDAgJnBjaWVfc21tdSAw eDAwMDAgMHgxPiwKPiArCQkJICAgIDwweDEwMCAmcGNpZV9zbW11IDB4MDAwMSAweDE+OwoKSSB0 aGluayBJIHJlY29tbWVuZGVkIHVzaW5nICJpb21tdS1tYXAiIGluc3RlYWQgb2YgImlvbW11cyIg cHJvcGVydHkuIEJ1dApsb29raW5nIGF0IGl0IGFnYWluLCBJIHRoaW5rIGl0IGlzIGZpbmUgdG8g dXNlIGp1c3QgImlvbW11cyIgcHJvcGVydHkgYXMgdGhlIFNJRAp3aWxsIGJlIGFzc29jaWF0ZWQg d2l0aCB0aGUgRVAgZGlyZWN0bHkuCgpVbmxlc3MgeW91IHdhbnQgdG8gaGF2ZSBkaWZmZXJlbnQg U0lEIGZvciBlYWNoIGZ1bmN0aW9uLgoKPiArCj4gKwkJcmVzZXRzID0gPCZnY2MgR0NDX1BDSUVf MF9CQ1I+Owo+ICsJCXJlc2V0LW5hbWVzID0gImNvcmUiOwo+ICsJCXBvd2VyLWRvbWFpbnMgPSA8 JmdjYyBQQ0lFXzBfR0RTQz47Cj4gKwkJcGh5cyA9IDwmcGNpZTBfcGh5PjsKPiArCQlwaHktbmFt ZXMgPSAicGNpZXBoeSI7Cj4gKwkJbWF4LWxpbmstc3BlZWQgPSA8Mz47CgpQbGVhc2UgYWRkIGEg Y29tbWVudCBoZXJlIHRoYXQgeW91IGFyZSBsaW1pdGluZyB0aGUgR2VuIHNwZWVkIGR1ZSB0byBz dGFiaWxpdHkKaXNzdWVzLiBMaWtlLAoKCQltYXgtbGluay1zcGVlZCA9IDwzPjsgLyogRklYTUU6 IExpbWl0aW5nIHRoZSBHZW4gc3BlZWQgZHVlIHRvIHN0YWJpbGl0eSBpc3N1ZXMgKi8KCj4gKwkJ bnVtLWxhbmVzID0gPDI+OwoKQ2FuIHlvdSBjaGVjayBpZiB0aGUgY29udHJvbGxlciBpcyBjYWNo ZSBjb2hlcmVudD8gSWYgc28sIHdlIHNob3VsZCBhZGQKImRtYS1jb2hlcmVudCIgcHJvcGVydHku CgotIE1hbmkKCj4gKwo+ICsJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwl9Owo+ICB9Owo+IC0t IAo+IDIuNy40Cj4gCgotLSAK4K6u4K6j4K6/4K614K6j4K+N4K6j4K6p4K+NIOCumuCupOCuvuCu muCuv+CuteCuruCvjQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcGh5Cg==